Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371230 > unrolled thread
| Started by | Borislav Petkov <bp@alien8.de> |
|---|---|
| First post | 2016-04-05 07:40 +0200 |
| Last post | 2016-04-07 13:20 +0200 |
| Articles | 3 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup Borislav Petkov <bp@alien8.de> - 2016-04-05 07:40 +0200
Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup Borislav Petkov <bp@alien8.de> - 2016-04-05 22:20 +0200
Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup Borislav Petkov <bp@alien8.de> - 2016-04-07 13:20 +0200
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-04-05 07:40 +0200 |
| Subject | Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup |
| Message-ID | <rkrSy-6FS-1@gated-at.bofh.it> |
On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> the next revision with a goto.
I'm assuming nothing else changes. Because I've applied 1-4 already.
Yes, no?
If no, then please send only an updated version of this patch as a reply
to this thread here.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-04-05 22:20 +0200 |
| Message-ID | <rkFCa-11B-17@gated-at.bofh.it> |
| In reply to | #1371230 |
On Tue, Apr 05, 2016 at 01:37:49PM -0500, Dinh Nguyen wrote:
> My only suggestion was to change the 3 helper functions(ecc_set_bits,
> ecc_clear_bits, and ecc_test_bits) should be static inline.
That doesn't take care of the iounmap error path Thor is talking about,
AFAICT.
So, I've pushed out what I have applied so far:
http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
Thor, please send me what is outstanding ontop.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-04-07 13:20 +0200 |
| Message-ID | <rlg8F-2Yy-5@gated-at.bofh.it> |
| In reply to | #1371230 |
On Wed, Apr 06, 2016 at 07:36:49PM -0500, Thor Thayer wrote:
> Yes, nothing else changes. The rest was OK. Thanks!
Cool. The two remaining applied and pushed out.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web