Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370283 > unrolled thread

Re: [PATCH] staging: vme: fix bare use of 'unsigned'

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: vme: fix bare use of 'unsigned' Martyn Welch <mwelchuk@gmail.com> - 2016-04-03 22:40 +0200
    Re: [PATCH] staging: vme: fix bare use of 'unsigned' Greg KH <gregkh@linuxfoundation.org> - 2016-04-04 21:50 +0200

#1370283 — Re: [PATCH] staging: vme: fix bare use of 'unsigned'

On 31/03/16 23:53, Clifton Barnes wrote:
> fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> 'unsigned''
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>

Acked-by: Martyn Welch <martyn@welchs.me.uk>

Greg: Whilst this patch seems valid and compiles fine, I no longer have 
access to the hardware for this driver. I'm aware this driver has been 
in the staging tree for a rather long time. I will check to see if 
there's any intention for further work to be done on this driver, if not 
I guess we should be looking to delete it from the staging tree.

Martyn

> ---
>   drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index df992c3..f52a9ed 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
>   }
>   
>   /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
>   {
>   	int data;
>   	struct pio2_card *card = gpio_to_pio2_card(chip);
> @@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
>   }
>   
>   /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
> +static int pio2_gpio_dir_out(struct gpio_chip *chip,
> +			     unsigned int offset, int value)
>   {
>   	int data;
>   	struct pio2_card *card = gpio_to_pio2_card(chip);

[toc] | [next] | [standalone]

#1370838

On Sun, Apr 03, 2016 at 09:36:31PM +0100, Martyn Welch wrote:
> 
> 
> On 31/03/16 23:53, Clifton Barnes wrote:
> > fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> > 'unsigned''
> > 
> > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
> 
> Acked-by: Martyn Welch <martyn@welchs.me.uk>
> 
> Greg: Whilst this patch seems valid and compiles fine, I no longer have
> access to the hardware for this driver. I'm aware this driver has been in
> the staging tree for a rather long time. I will check to see if there's any
> intention for further work to be done on this driver, if not I guess we
> should be looking to delete it from the staging tree.
> 

Thanks, let me know if you want it deleted.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web