Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372246 > unrolled thread

[tip:perf/core] perf trace: Do not process PERF_RECORD_LOST twice

Back to article view | Back to linux.kernel

Contents

  [tip:perf/core] perf trace: Do not process PERF_RECORD_LOST twice tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2016-04-06 09:10 +0200

#1372246 — [tip:perf/core] perf trace: Do not process PERF_RECORD_LOST twice

Commit-ID:  3ed5ca2efff70e9f589087c2013789572901112d
Gitweb:     http://git.kernel.org/tip/3ed5ca2efff70e9f589087c2013789572901112d
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Wed, 30 Mar 2016 16:51:17 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 31 Mar 2016 10:42:22 -0300

perf trace: Do not process PERF_RECORD_LOST twice

We catch this record to provide a visual indication that events are
getting lost, then call the default method to allow extra logging shared
with the other tools to take place.

This extra logging was done twice because we were continuing to the
"default" clause where machine__process_event() will end up calling
machine__process_lost_event() again, fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-wus2zlhw3qo24ye84ewu4aqw@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-trace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 93ac724..6485576 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1618,6 +1618,7 @@ static int trace__process_event(struct trace *trace, struct machine *machine,
 		color_fprintf(trace->output, PERF_COLOR_RED,
 			      "LOST %" PRIu64 " events!\n", event->lost.lost);
 		ret = machine__process_lost_event(machine, event, sample);
+		break;
 	default:
 		ret = machine__process_event(machine, event, sample);
 		break;

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web