Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371957 > unrolled thread
| Started by | Bastien Philbert <bastienphilbert@gmail.com> |
|---|---|
| First post | 2016-04-05 23:30 +0200 |
| Last post | 2016-04-05 23:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-05 23:30 +0200
Re: [PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-04-05 23:40 +0200
| From | Bastien Philbert <bastienphilbert@gmail.com> |
|---|---|
| Date | 2016-04-05 23:30 +0200 |
| Subject | [PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply |
| Message-ID | <rkGHU-1Ji-11@gated-at.bofh.it> |
This adds protection from concurrenct users in the function icmpv6_echo_reply around the call to the function __in6_dev_get by locking/unlocking around this call with calls to the functions rtnl_lock and rtnl_unlock to protect against concurrent users when calling this function in icmpv6_echo_reply as stated in the comments for locking requirements for the function, __in6_dev_get. Signed-off-by: Bastien Philbert <bastienphilbert@gmail.com> --- net/ipv6/icmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 0a37ddc..798434f 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -607,7 +607,9 @@ static void icmpv6_echo_reply(struct sk_buff *skb) hlimit = ip6_sk_dst_hoplimit(np, &fl6, dst); + rtnl_lock(); idev = __in6_dev_get(skb->dev); + rtnl_unlock(); msg.skb = skb; msg.offset = 0; -- 2.5.0
[toc] | [next] | [standalone]
| From | Hannes Frederic Sowa <hannes@stressinduktion.org> |
|---|---|
| Date | 2016-04-05 23:40 +0200 |
| Subject | Re: [PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply |
| Message-ID | <rkGRA-1Og-5@gated-at.bofh.it> |
| In reply to | #1371957 |
On 05.04.2016 23:27, Bastien Philbert wrote: > This adds protection from concurrenct users in the function > icmpv6_echo_reply around the call to the function __in6_dev_get > by locking/unlocking around this call with calls to the functions > rtnl_lock and rtnl_unlock to protect against concurrent users > when calling this function in icmpv6_echo_reply as stated in the > comments for locking requirements for the function, __in6_dev_get. > > Signed-off-by: Bastien Philbert <bastienphilbert@gmail.com> > --- > net/ipv6/icmp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c > index 0a37ddc..798434f 100644 > --- a/net/ipv6/icmp.c > +++ b/net/ipv6/icmp.c > @@ -607,7 +607,9 @@ static void icmpv6_echo_reply(struct sk_buff *skb) > > hlimit = ip6_sk_dst_hoplimit(np, &fl6, dst); > > + rtnl_lock(); > idev = __in6_dev_get(skb->dev); > + rtnl_unlock(); > > msg.skb = skb; > msg.offset = 0; > We can't hold rtnl_lock in bh context. Have you seen a rcu verifier report? I am sure we hold rcu read lock at this point. Bye, Hannes
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web