Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371929 > unrolled thread
| Started by | Mimi Zohar <zohar@linux.vnet.ibm.com> |
|---|---|
| First post | 2016-04-05 22:50 +0200 |
| Last post | 2016-04-06 18:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-04-05 22:50 +0200
Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] David Howells <dhowells@redhat.com> - 2016-04-06 18:20 +0200
Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-04-06 18:50 +0200
| From | Mimi Zohar <zohar@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-04-05 22:50 +0200 |
| Subject | Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] |
| Message-ID | <rkG5c-1el-13@gated-at.bofh.it> |
On Wed, 2016-03-09 at 11:19 +0000, David Howells wrote:
> -#ifdef CONFIG_SYSTEM_TRUSTED_KEYRING
> -/*
> - * Restrict the addition of keys into the IMA keyring.
> - *
> - * Any key that needs to go in .ima keyring must be signed by CA in
> - * either .system or .ima_mok keyrings.
> - */
> -static int restrict_link_by_ima_mok(struct key *keyring,
> - const struct key_type *type,
> - const union key_payload *payload)
> -{
> - int ret;
> -
> - ret = restrict_link_by_builtin_trusted(keyring, type, payload);
> - if (ret != -ENOKEY)
> - return ret;
> -
> - return restrict_link_by_signature(get_ima_mok_keyring(),
> - type, payload);
> -}
> +#if defined(CONFIG_IMA_KEYRINGS_ADD_IF_SIGNED_BY_BUILTIN)
> +#define restrict_link_to_ima restrict_link_by_builtin_trusted
> +#elif defined(CONFIG_IMA_KEYRINGS_ADD_IF_SIGNED_BY_BUILTIN_OR_SECONDARY)
> +#define restrict_link_to_ima restrict_link_by_builtin_and_secondary_trusted
FYI, restrict_link_by_ima_mok() allows keys to be added to the IMA
keyring signed by a key on the .ima_mok keyring, but
restrict_link_by_builtin_and_secondary_trusted() results in "errno:
Required key not available (126)".
Mimi
[toc] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-04-06 18:20 +0200 |
| Subject | Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] |
| Message-ID | <rkYls-6yQ-17@gated-at.bofh.it> |
| In reply to | #1371929 |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > FYI, restrict_link_by_ima_mok() allows keys to be added to the IMA > keyring signed by a key on the .ima_mok keyring, but > restrict_link_by_builtin_and_secondary_trusted() results in "errno: > Required key not available (126)". Is that fixed by fixing restrict_link_by_builtin_and_secondary_trusted() to check the right keyring? David
[toc] | [prev] | [next] | [standalone]
| From | Mimi Zohar <zohar@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-04-06 18:50 +0200 |
| Message-ID | <rkYOu-6Mu-17@gated-at.bofh.it> |
| In reply to | #1372640 |
On Wed, 2016-04-06 at 17:13 +0100, David Howells wrote: > Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > > FYI, restrict_link_by_ima_mok() allows keys to be added to the IMA > > keyring signed by a key on the .ima_mok keyring, but > > restrict_link_by_builtin_and_secondary_trusted() results in "errno: > > Required key not available (126)". > > Is that fixed by fixing restrict_link_by_builtin_and_secondary_trusted() to > check the right keyring? Yes
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web