Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1370206 > unrolled thread

[PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree

Started byÁlvaro Fernández Rojas <noltari@gmail.com>
First post2016-04-03 14:20 +0200
Last post2016-04-04 10:20 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree Álvaro Fernández Rojas   <noltari@gmail.com> - 2016-04-03 14:20 +0200
    Re: [PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree Ralf Baechle <ralf@linux-mips.org> - 2016-04-04 01:20 +0200
      Re: [PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree Álvaro Fernández Rojas <noltari@gmail.com> - 2016-04-04 10:20 +0200

#1370206 — [PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree

FromÁlvaro Fernández Rojas <noltari@gmail.com>
Date2016-04-03 14:20 +0200
Subject[PATCH 2/3] MIPS: BMIPS: improve BCM6358 device tree
Message-ID<rjPay-3aR-5@gated-at.bofh.it>
- Switch to bcm6345-l1-intc interrupt controller.
- Add ehci0 and ohci0 nodes.
- Use proper native-endian syscon property.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 arch/mips/boot/dts/brcm/bcm6358.dtsi | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6358.dtsi b/arch/mips/boot/dts/brcm/bcm6358.dtsi
index 5ac1ef0..5dc8432 100644
--- a/arch/mips/boot/dts/brcm/bcm6358.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6358.dtsi
@@ -53,7 +53,7 @@
 		periph_cntl: syscon@fffe0000 {
 			compatible = "syscon";
 			reg = <0xfffe0000 0xc>;
-			little-endian;
+			native-endian;
 		};
 
 		reboot: syscon-reboot@fffe0008 {
@@ -64,15 +64,15 @@
 		};
 
 		periph_intc: interrupt-controller@fffe000c {
-			compatible = "brcm,bcm3380-l2-intc";
-			reg = <0xfffe0010 0x4 0xfffe000c 0x4>,
-			      <0xfffe003c 0x4 0xfffe0038 0x4>;
+			compatible = "brcm,bcm6345-l1-intc";
+			reg = <0xfffe000c 0x8>,
+			      <0xfffe0038 0x8>;
 
 			interrupt-controller;
 			#interrupt-cells = <1>;
 
 			interrupt-parent = <&cpu_intc>;
-			interrupts = <2>;
+			interrupts = <2>, <3>;
 		};
 
 		leds0: led-controller@fffe00d0 {
@@ -107,5 +107,24 @@
 
 			status = "disabled";
 		};
+
+		ehci0: usb@fffe1300 {
+			compatible = "brcm,bcm6358-ehci", "generic-ehci";
+			reg = <0xfffe1300 0x100>;
+			big-endian;
+			interrupt-parent = <&periph_intc>;
+			interrupts = <10>;
+			status = "disabled";
+		};
+
+		ohci0: usb@fffe1400 {
+			compatible = "brcm,bcm6358-ohci", "generic-ohci";
+			reg = <0xfffe1400 0x100>;
+			big-endian;
+			no-big-frame-no;
+			interrupt-parent = <&periph_intc>;
+			interrupts = <5>;
+			status = "disabled";
+		};
 	};
 };
-- 
2.1.4

[toc] | [next] | [standalone]


#1370312

FromRalf Baechle <ralf@linux-mips.org>
Date2016-04-04 01:20 +0200
Message-ID<rjZtg-2eL-7@gated-at.bofh.it>
In reply to#1370206
On Sun, Apr 03, 2016 at 02:13:04PM +0200, Álvaro Fernández Rojas wrote:

> - Switch to bcm6345-l1-intc interrupt controller.
> - Add ehci0 and ohci0 nodes.
> - Use proper native-endian syscon property.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  arch/mips/boot/dts/brcm/bcm6358.dtsi | 29 ++++++++++++++++++++++++-----

Any reason Why didn't you fold this patch into the "[v3,2/2] bmips: add
device tree example for BCM6358" patch of the other series?

  Ralf

[toc] | [prev] | [next] | [standalone]


#1370428

FromÁlvaro Fernández Rojas <noltari@gmail.com>
Date2016-04-04 10:20 +0200
Message-ID<rk7TP-e4-1@gated-at.bofh.it>
In reply to#1370312
Done,

Álvaro.

> El 4 abr 2016, a las 1:10, Ralf Baechle <ralf@linux-mips.org> escribió:
> 
> On Sun, Apr 03, 2016 at 02:13:04PM +0200, Álvaro Fernández Rojas wrote:
> 
>> - Switch to bcm6345-l1-intc interrupt controller.
>> - Add ehci0 and ohci0 nodes.
>> - Use proper native-endian syscon property.
>> 
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>> ---
>> arch/mips/boot/dts/brcm/bcm6358.dtsi | 29 ++++++++++++++++++++++++-----
> 
> Any reason Why didn't you fold this patch into the "[v3,2/2] bmips: add
> device tree example for BCM6358" patch of the other series?
> 
>  Ralf
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web