Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1369160 > unrolled thread
| Started by | Lijun Ou <oulijun@huawei.com> |
|---|---|
| First post | 2016-04-01 12:20 +0200 |
| Last post | 2016-04-05 17:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH V4 0/3] IB/hns: Add HiSilicon RoCE driver Lijun Ou <oulijun@huawei.com> - 2016-04-01 12:20 +0200
Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support Leon Romanovsky <leon@leon.nu> - 2016-04-02 04:00 +0200
Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support oulijun <oulijun@huawei.com> - 2016-04-05 09:40 +0200
Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support Leon Romanovsky <leon@leon.nu> - 2016-04-05 17:40 +0200
| From | Lijun Ou <oulijun@huawei.com> |
|---|---|
| Date | 2016-04-01 12:20 +0200 |
| Subject | [RESEND PATCH V4 0/3] IB/hns: Add HiSilicon RoCE driver |
| Message-ID | <rj4lj-2Pw-7@gated-at.bofh.it> |
The HiSilicon Network Substem is a long term evolution IP which is supposed to be used in HiSilicon ICT SoC. RoCE is a feature of hns. The driver for HiSilicon RoCE engine is a platform driver. The driver will support mulitple versions of hns. Currently only "v1" for hip06 SoC is supported. Changes v3 -> v4: 1. modify roce.o into hns-roce.o in Makefile and Kconfig file. Changes v2 -> v3: 1. modify the formats of RoCE driver code base v2 by the experts reviewing. also, it used kmalloc_array instead of kmalloc, used kcalloc instead of kzalloc, when refer to memory allocation for array 2. remove some functions without use and unconnected macros 3. modify the binding document with RoCE DT base v2 which added interrupt-names 4. redesign the port_map and si_map in hns_dsaf_roce_reset 5. add HiSilicon RoCE driver maintainers introduction in MAINTAINERS document Changes v1 -> v2: 1. modify the formats of roce driver code by the experts reviewing 2. modify the bindings file with roce dts. add the attribute named interrput-names. 3. modify the way of defining port mode in hns_dsaf_main.c 4. move the Kconfig file into the hns directory and send it with roce Lijun Ou (3): net: hns: Add reset function support for RoCE driver IB/hns: Add HiSilicon RoCE driver support IB/hns: Add binding document for HiSilicon RoCE driver .../bindings/infiniband/hisilicon-hns-roce.txt | 107 + MAINTAINERS | 8 + drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 + drivers/infiniband/hw/hisilicon/hns/Makefile | 9 + drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 + .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++ drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++ drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 + .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++ drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++ .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++ drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++ drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 + drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++ drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 + .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++ drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++ drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 + drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++ .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 + .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++ .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++ drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 84 + drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 30 + drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 62 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 13 + 28 files changed, 10715 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt create mode 100644 drivers/infiniband/hw/hisilicon/hns/Kconfig create mode 100644 drivers/infiniband/hw/hisilicon/hns/Makefile create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_alloc.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_common.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_device.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_main.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_user.h create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c create mode 100644 drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h -- 1.9.1
[toc] | [next] | [standalone]
| From | Leon Romanovsky <leon@leon.nu> |
|---|---|
| Date | 2016-04-02 04:00 +0200 |
| Subject | Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support |
| Message-ID | <rjj10-4IV-3@gated-at.bofh.it> |
| In reply to | #1369160 |
On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote:
> The driver for HiSilicon RoCE is a platform driver.
> The driver will support multiple versions of hardware. Currently only "v1"
> for hip06 SoC is supported.
> The driver includes two parts: common driver and hardware-specific
> operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for
> hardware-specific operations only for v1 engine, and other files(.c and .h)
> for common algorithm and common hardware operations.
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: Znlong <zhaonenglong@huawei.com>
> ---
> MAINTAINERS | 8 +
> drivers/infiniband/Kconfig | 1 +
> drivers/infiniband/hw/Makefile | 1 +
> drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 +
> drivers/infiniband/hw/hisilicon/hns/Makefile | 9 +
> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 +
We are not adding name of company (hisilicon) for infiniband HW drivers
drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c
--->
drivers/infiniband/hw/hns/hns_roce_ah.c
> .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++
^^^^^^
Please fix you paths.
> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 +
> .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++
> .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 +
> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 +
> .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++
> drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 +
> drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++
> .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 +
> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++
> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++
^^^^^^
Do you support v1 of RoCE or v1 of your HW?
> 23 files changed, 10429 insertions(+)
Please appreciate the effort needed to review such large patch and
invest time and effort to divide this to number of small easy review patches.
[toc] | [prev] | [next] | [standalone]
| From | oulijun <oulijun@huawei.com> |
|---|---|
| Date | 2016-04-05 09:40 +0200 |
| Subject | Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support |
| Message-ID | <rktKF-89N-9@gated-at.bofh.it> |
| In reply to | #1369856 |
Hi, Leon Romanovsky
On 2016/4/2 9:58, Leon Romanovsky wrote:
> On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote:
>> The driver for HiSilicon RoCE is a platform driver.
>> The driver will support multiple versions of hardware. Currently only "v1"
>> for hip06 SoC is supported.
>> The driver includes two parts: common driver and hardware-specific
>> operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for
>> hardware-specific operations only for v1 engine, and other files(.c and .h)
>> for common algorithm and common hardware operations.
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Znlong <zhaonenglong@huawei.com>
>> ---
>> MAINTAINERS | 8 +
>> drivers/infiniband/Kconfig | 1 +
>> drivers/infiniband/hw/Makefile | 1 +
>> drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 +
>> drivers/infiniband/hw/hisilicon/hns/Makefile | 9 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 +
>
> We are not adding name of company (hisilicon) for infiniband HW drivers
> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c
> --->
> drivers/infiniband/hw/hns/hns_roce_ah.c
>
Surely, i will modify the location of RoCE driver code after disscussed in next patch
>
>> .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++
> ^^^^^^
> Please fix you paths.
>
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++
>> .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 +
>> drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++
>> .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 +
>> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++
>> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++
> ^^^^^^
> Do you support v1 of RoCE or v1 of your HW?
>
Here, v1 stands for hw, that is, we support v1 of our hw.
>> 23 files changed, 10429 insertions(+)
>
> Please appreciate the effort needed to review such large patch and
> invest time and effort to divide this to number of small easy review patches.
>
Surely, i have pay attention to the patch, but i consider that it is not better to
split the patch into small patch. because it will the base function of RoCE.
For your advice, i will make further efforts to taking a discussion how to reslove the question.
thanks
Lijun Ou
> .
>
[toc] | [prev] | [next] | [standalone]
| From | Leon Romanovsky <leon@leon.nu> |
|---|---|
| Date | 2016-04-05 17:40 +0200 |
| Subject | Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support |
| Message-ID | <rkBfd-61Y-31@gated-at.bofh.it> |
| In reply to | #1371285 |
On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++ > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++ > > ^^^^^^ > > Do you support v1 of RoCE or v1 of your HW? > > > Here, v1 stands for hw, that is, we support v1 of our hw. So you should write hns_roce_hw_v1 and not hns_roce_v1_hw > >> 23 files changed, 10429 insertions(+) > > > > Please appreciate the effort needed to review such large patch and > > invest time and effort to divide this to number of small easy review patches. > > > Surely, i have pay attention to the patch, but i consider that it is not better to > split the patch into small patch. because it will the base function of RoCE. > For your advice, i will make further efforts to taking a discussion how to reslove the question. Faisal Latif's submission [1] can help you to get inspiration. Also please DON'T submit your patches till you get rid of unrelated functions/macros/defines and DMA operations for register access. [1] https://lwn.net/Articles/668721/ > > thanks > Lijun Ou > > . > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web