Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370314 > unrolled thread

[PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit Minchan Kim <minchan@kernel.org> - 2016-04-04 01:50 +0200
    Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is  over limit Andrew Morton <akpm@linux-foundation.org> - 2016-04-05 22:40 +0200

#1370314 — [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

We have been reclaimed highmem zone if buffer_heads is over limit
but [1] changed the behavior so it doesn't reclaim highmem zone
although buffer_heads is over the limit.
This patch restores the logic.

[1] commit 6b4f7799c6a5 ("mm: vmscan: invoke slab shrinkers from shrink_zone()")

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: stable@vger.kernel.org
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index c7696a2e11c7..d84efa03c8a8 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2550,7 +2550,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
 		sc->gfp_mask |= __GFP_HIGHMEM;
 
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					requested_highidx, sc->nodemask) {
+					gfp_zone(sc->gfp_mask), sc->nodemask) {
 		enum zone_type classzone_idx;
 
 		if (!populated_zone(zone))
-- 
1.9.1

[toc] | [next] | [standalone]

#1371922 — Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

On Mon,  4 Apr 2016 08:46:09 +0900 Minchan Kim <minchan@kernel.org> wrote:

> We have been reclaimed highmem zone if buffer_heads is over limit
> but [1] changed the behavior so it doesn't reclaim highmem zone
> although buffer_heads is over the limit.
> This patch restores the logic.
> 
> [1] commit 6b4f7799c6a5 ("mm: vmscan: invoke slab shrinkers from shrink_zone()")
> 
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2550,7 +2550,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
>  		sc->gfp_mask |= __GFP_HIGHMEM;
>  
>  	for_each_zone_zonelist_nodemask(zone, z, zonelist,
> -					requested_highidx, sc->nodemask) {
> +					gfp_zone(sc->gfp_mask), sc->nodemask) {
>  		enum zone_type classzone_idx;
>  
>  		if (!populated_zone(zone))

Wait wut wot.  We broke this over a year ago?  Highmem pagecache pages
pinning buffer_head lowmem used to be a huuuge problem.  Before most of
you were born ;)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web