Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370313 > unrolled thread

[PATCH] mm:vmscan: clean up classzone_idx

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm:vmscan: clean up classzone_idx Minchan Kim <minchan@kernel.org> - 2016-04-04 01:50 +0200
    Re: [PATCH] mm:vmscan: clean up classzone_idx Michal Hocko <mhocko@kernel.org> - 2016-04-04 11:50 +0200

#1370313 — [PATCH] mm:vmscan: clean up classzone_idx

[1] removed classzone_idx so we don't need code related to it.
This patch cleans it up.

[1] mm, oom: rework oom detection

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/vmscan.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index d84efa03c8a8..6e67de2a61ed 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2551,16 +2551,8 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
 
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
 					gfp_zone(sc->gfp_mask), sc->nodemask) {
-		enum zone_type classzone_idx;
-
 		if (!populated_zone(zone))
 			continue;
-
-		classzone_idx = requested_highidx;
-		while (!populated_zone(zone->zone_pgdat->node_zones +
-							classzone_idx))
-			classzone_idx--;
-
 		/*
 		 * Take care memory controller reclaiming has small influence
 		 * to global LRU.
-- 
1.9.1

[toc] | [next] | [standalone]

#1370510

On Mon 04-04-16 08:46:25, Minchan Kim wrote:
> [1] removed classzone_idx so we don't need code related to it.
> This patch cleans it up.
> 
> [1] mm, oom: rework oom detection

As per http://lkml.kernel.org/r/20160404094213.GB13463@dhcp22.suse.cz
the removal of classzone_idx was unintentional and wrong.

> 
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
>  mm/vmscan.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index d84efa03c8a8..6e67de2a61ed 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2551,16 +2551,8 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
>  
>  	for_each_zone_zonelist_nodemask(zone, z, zonelist,
>  					gfp_zone(sc->gfp_mask), sc->nodemask) {
> -		enum zone_type classzone_idx;
> -
>  		if (!populated_zone(zone))
>  			continue;
> -
> -		classzone_idx = requested_highidx;
> -		while (!populated_zone(zone->zone_pgdat->node_zones +
> -							classzone_idx))
> -			classzone_idx--;
> -
>  		/*
>  		 * Take care memory controller reclaiming has small influence
>  		 * to global LRU.
> -- 
> 1.9.1
> 

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web