Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368591 > unrolled thread

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-03-31 22:20 +0200

#1368591 — Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote:
> 
> > Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
> > 
> > Hello Andreas,
> > 
> > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> >> Drop #address-cells and #size-cells, which are not required by the
> >> gpio-keys binding documentation, as button sub-nodes are not devices.
> >> 
> >> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> >> 
> >> While at it, adopt the dashes convention for the node name.
> >> 
> >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Andreas Färber <afaerber@suse.de>
> >> ---
> > 
> > Patch looks good to me.
> > 
> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> I agree.
> 
> Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>

Applied, thank you.

-- 
Dmitry

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web