Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368302 > unrolled thread

[PATCH] writeback: fix the wrong congested state variable definition

Back to article view | Back to linux.kernel

Contents

  [PATCH] writeback: fix the wrong congested state variable definition Kaixu Xia <xiakaixu@huawei.com> - 2016-03-31 15:30 +0200
    Re: [PATCH] writeback: fix the wrong congested state variable  definition Tejun Heo <tj@kernel.org> - 2016-03-31 18:50 +0200
    Re: [PATCH] writeback: fix the wrong congested state variable  definition Jens Axboe <axboe@kernel.dk> - 2016-03-31 20:30 +0200

#1368302 — [PATCH] writeback: fix the wrong congested state variable definition

The right variable definition should be wb_congested_state that
include WB_async_congested and WB_sync_congested. So fix it.

Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
---
 mm/backing-dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index bfbd709..0c6317b 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -898,7 +898,7 @@ static atomic_t nr_wb_congested[2];
 void clear_wb_congested(struct bdi_writeback_congested *congested, int sync)
 {
 	wait_queue_head_t *wqh = &congestion_wqh[sync];
-	enum wb_state bit;
+	enum wb_congested_state bit;
 
 	bit = sync ? WB_sync_congested : WB_async_congested;
 	if (test_and_clear_bit(bit, &congested->state))
@@ -911,7 +911,7 @@ EXPORT_SYMBOL(clear_wb_congested);
 
 void set_wb_congested(struct bdi_writeback_congested *congested, int sync)
 {
-	enum wb_state bit;
+	enum wb_congested_state bit;
 
 	bit = sync ? WB_sync_congested : WB_async_congested;
 	if (!test_and_set_bit(bit, &congested->state))
-- 
1.8.3.4

[toc] | [next] | [standalone]

#1368444 — Re: [PATCH] writeback: fix the wrong congested state variable definition

On Thu, Mar 31, 2016 at 01:19:41PM +0000, Kaixu Xia wrote:
> The right variable definition should be wb_congested_state that
> include WB_async_congested and WB_sync_congested. So fix it.
> 
> Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1368534 — Re: [PATCH] writeback: fix the wrong congested state variable definition

On 03/31/2016 07:19 AM, Kaixu Xia wrote:
> The right variable definition should be wb_congested_state that
> include WB_async_congested and WB_sync_congested. So fix it.

Added, thanks.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web