Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1365983 > unrolled thread

Re: [PATCH 2/2] ARM: uniphier: initialize outer cache for secondary CPUs

Started byArnd Bergmann <arnd@arndb.de>
First post2016-03-29 10:20 +0200
Last post2016-03-31 12:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/2] ARM: uniphier: initialize outer cache for secondary CPUs Arnd Bergmann <arnd@arndb.de> - 2016-03-29 10:20 +0200
    Re: [PATCH 2/2] ARM: uniphier: initialize outer cache for secondary CPUs Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-03-31 12:40 +0200

#1365983 — Re: [PATCH 2/2] ARM: uniphier: initialize outer cache for secondary CPUs

FromArnd Bergmann <arnd@arndb.de>
Date2016-03-29 10:20 +0200
SubjectRe: [PATCH 2/2] ARM: uniphier: initialize outer cache for secondary CPUs
Message-ID<rhX2x-3h3-1@gated-at.bofh.it>
On Tuesday 29 March 2016 15:59:00 kbuild test robot wrote:
> 
> All warnings (new ones prefixed by >>):
> 
> >> WARNING: vmlinux.o(.text+0x557b4): Section mismatch in reference from the function uniphier_cache_secondary_init() to the function .init.text:uniphier_cache_activate_all_ways()
>    The function uniphier_cache_secondary_init() references
>    the function __init uniphier_cache_activate_all_ways().
>    This is often because uniphier_cache_secondary_init lacks a __init
>    annotation or the annotation of uniphier_cache_activate_all_ways is wrong.
> 


I guess the former: uniphier_cache_secondary_init should be __init, as it will
only be run at boot time.

Please resend both patches.

	Arnd

[toc] | [next] | [standalone]


#1368154

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-03-31 12:40 +0200
Message-ID<riIb7-3Af-1@gated-at.bofh.it>
In reply to#1365983
Hi Arnd,

2016-03-29 17:11 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday 29 March 2016 15:59:00 kbuild test robot wrote:
>>
>> All warnings (new ones prefixed by >>):
>>
>> >> WARNING: vmlinux.o(.text+0x557b4): Section mismatch in reference from the function uniphier_cache_secondary_init() to the function .init.text:uniphier_cache_activate_all_ways()
>>    The function uniphier_cache_secondary_init() references
>>    the function __init uniphier_cache_activate_all_ways().
>>    This is often because uniphier_cache_secondary_init lacks a __init
>>    annotation or the annotation of uniphier_cache_activate_all_ways is wrong.
>>
>
>
> I guess the former: uniphier_cache_secondary_init should be __init, as it will
> only be run at boot time.
>
> Please resend both patches.
>

I think the alternative solution suggested by Russell is much better.

I hope Russell will apply his one, and then I retract this series.



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web