Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1366925 > unrolled thread
| Started by | Yuyang Du <yuyang.du@intel.com> |
|---|---|
| First post | 2016-03-30 09:00 +0200 |
| Last post | 2016-03-31 11:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] sched/fair: Update comment after a variable rename Yuyang Du <yuyang.du@intel.com> - 2016-03-30 09:00 +0200
Re: [PATCH] sched/fair: Update comment after a variable rename Yuyang Du <yuyang.du@intel.com> - 2016-03-30 09:10 +0200
[tip:sched/core] sched/fair: Update comments after a variable rename tip-bot for Yuyang Du <tipbot@zytor.com> - 2016-03-31 11:30 +0200
| From | Yuyang Du <yuyang.du@intel.com> |
|---|---|
| Date | 2016-03-30 09:00 +0200 |
| Subject | [PATCH] sched/fair: Update comment after a variable rename |
| Message-ID | <riigF-1wq-9@gated-at.bofh.it> |
Commit ed82b8a1ff76ed7b2709 renamed prio_to_weight to sched_prio_to_weight, but the old name was not updated in a comment. Signed-off-by: Yuyang Du <yuyang.du@intel.com> --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 303d639..68ecc1f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5630,7 +5630,7 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp * W_i,0 = \Sum_j w_i,j (2) * * Where w_i,j is the weight of the j-th runnable task on cpu i. This weight - * is derived from the nice value as per prio_to_weight[]. + * is derived from the nice value as per sched_prio_to_weight[]. * * The weight average is an exponential decay average of the instantaneous * weight: -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Yuyang Du <yuyang.du@intel.com> |
|---|---|
| Date | 2016-03-30 09:10 +0200 |
| Message-ID | <riiql-1QB-7@gated-at.bofh.it> |
| In reply to | #1366925 |
Suddenly realized there is another one not updated. Sorry. --- Subject: [PATCH v2] sched/fair: Update comment after a variable rename Commit ed82b8a1ff76ed7b2709 renamed prio_to_weight to sched_prio_to_weight and prio_to_wmult to sched_prio_to_wmult, but the old names not updated in a comment. Signed-off-by: Yuyang Du <yuyang.du@intel.com> --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 303d639..c5095b0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -204,7 +204,7 @@ static void __update_inv_weight(struct load_weight *lw) * OR * (delta_exec * (weight * lw->inv_weight)) >> WMULT_SHIFT * - * Either weight := NICE_0_LOAD and lw \e prio_to_wmult[], in which case + * Either weight := NICE_0_LOAD and lw \e sched_prio_to_wmult[], in which case * we're guaranteed shift stays positive because inv_weight is guaranteed to * fit 32 bits, and NICE_0_LOAD gives another 10 bits; therefore shift >= 22. * @@ -5630,7 +5630,7 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp * W_i,0 = \Sum_j w_i,j (2) * * Where w_i,j is the weight of the j-th runnable task on cpu i. This weight - * is derived from the nice value as per prio_to_weight[]. + * is derived from the nice value as per sched_prio_to_weight[]. * * The weight average is an exponential decay average of the instantaneous * weight: -- 1.7.9.5
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Yuyang Du <tipbot@zytor.com> |
|---|---|
| Date | 2016-03-31 11:30 +0200 |
| Subject | [tip:sched/core] sched/fair: Update comments after a variable rename |
| Message-ID | <riH5p-2PS-29@gated-at.bofh.it> |
| In reply to | #1366925 |
Commit-ID: 1c3de5e19fc96206dd086e634129d08e5f7b1000
Gitweb: http://git.kernel.org/tip/1c3de5e19fc96206dd086e634129d08e5f7b1000
Author: Yuyang Du <yuyang.du@intel.com>
AuthorDate: Wed, 30 Mar 2016 07:07:51 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 31 Mar 2016 10:49:45 +0200
sched/fair: Update comments after a variable rename
The following commit:
ed82b8a1ff76 ("sched/core: Move the sched_to_prio[] arrays out of line")
renamed prio_to_weight to sched_prio_to_weight, but the old name was not
updated in comments.
Signed-off-by: Yuyang Du <yuyang.du@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1459292871-22531-1-git-send-email-yuyang.du@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1fe9916..4bb5ace 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -204,7 +204,7 @@ static void __update_inv_weight(struct load_weight *lw)
* OR
* (delta_exec * (weight * lw->inv_weight)) >> WMULT_SHIFT
*
- * Either weight := NICE_0_LOAD and lw \e prio_to_wmult[], in which case
+ * Either weight := NICE_0_LOAD and lw \e sched_prio_to_wmult[], in which case
* we're guaranteed shift stays positive because inv_weight is guaranteed to
* fit 32 bits, and NICE_0_LOAD gives another 10 bits; therefore shift >= 22.
*
@@ -5656,7 +5656,7 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
* W_i,0 = \Sum_j w_i,j (2)
*
* Where w_i,j is the weight of the j-th runnable task on cpu i. This weight
- * is derived from the nice value as per prio_to_weight[].
+ * is derived from the nice value as per sched_prio_to_weight[].
*
* The weight average is an exponential decay average of the instantaneous
* weight:
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web