Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1367136 > unrolled thread

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Started byKalle Valo <kvalo@codeaurora.org>
First post2016-03-30 14:00 +0200
Last post2016-03-31 11:10 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style Kalle Valo <kvalo@codeaurora.org> - 2016-03-30 14:00 +0200
    Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to  kernel style Joe Perches <joe@perches.com> - 2016-03-30 23:40 +0200
      Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style Kalle Valo <kvalo@codeaurora.org> - 2016-03-31 09:40 +0200
        Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to  kernel style Joe Perches <joe@perches.com> - 2016-03-31 10:10 +0200
          Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to  kernel style Eliad Peller <eliad@wizery.com> - 2016-03-31 11:10 +0200

#1367136 — Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

FromKalle Valo <kvalo@codeaurora.org>
Date2016-03-30 14:00 +0200
SubjectRe: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Message-ID<rimWZ-4NR-1@gated-at.bofh.it>
Joe Perches <joe@perches.com> writes:

> Using the normal kernel logging mechanisms makes this code
> a bit more like other wireless drivers.

Personally I don't see the point but I don't have any strong opinions. A
bigger problem is that TI drivers are not really in active development
and that's I'm not thrilled to take big patches like this for dormant
drivers.

-- 
Kalle Valo

[toc] | [next] | [standalone]


#1367624 — Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

FromJoe Perches <joe@perches.com>
Date2016-03-30 23:40 +0200
SubjectRe: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Message-ID<riw0h-2Yu-1@gated-at.bofh.it>
In reply to#1367136
On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> > Using the normal kernel logging mechanisms makes this code
> > a bit more like other wireless drivers.
> Personally I don't see the point but I don't have any strong opinions. A
> bigger problem is that TI drivers are not really in active development
> and that's I'm not thrilled to take big patches like this for dormant
> drivers.

Not very dormant.

35 patches in the last year, most of them adding functionality.

[toc] | [prev] | [next] | [standalone]


#1367912

FromKalle Valo <kvalo@codeaurora.org>
Date2016-03-31 09:40 +0200
Message-ID<riFmW-1xL-27@gated-at.bofh.it>
In reply to#1367624
Joe Perches <joe@perches.com> writes:

> On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
>> Joe Perches <joe@perches.com> writes:
>> > Using the normal kernel logging mechanisms makes this code
>> > a bit more like other wireless drivers.
>> Personally I don't see the point but I don't have any strong opinions. A
>> bigger problem is that TI drivers are not really in active development
>> and that's I'm not thrilled to take big patches like this for dormant
>> drivers.
>
> Not very dormant.
>
> 35 patches in the last year, most of them adding functionality.

Oh, I didn't realise it had that many patches. But the driver is
orphaned and doesn't have a maintainer so could I then have an ack from
one of the active contributors that this ok?

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]


#1367936 — Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

FromJoe Perches <joe@perches.com>
Date2016-03-31 10:10 +0200
SubjectRe: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Message-ID<riFPY-20X-13@gated-at.bofh.it>
In reply to#1367912
On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
> > > Joe Perches <joe@perches.com> writes:
> > > > 
> > > > Using the normal kernel logging mechanisms makes this code
> > > > a bit more like other wireless drivers.
> > > Personally I don't see the point but I don't have any strong opinions. A
> > > bigger problem is that TI drivers are not really in active development
> > > and that's I'm not thrilled to take big patches like this for dormant
> > > drivers.
> > Not very dormant.
> > 
> > 35 patches in the last year, most of them adding functionality.
> Oh, I didn't realise it had that many patches. But the driver is
> orphaned and doesn't have a maintainer so could I then have an ack from
> one of the active contributors that this ok?

Fine by me.

$ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/

Kalle Valo <kvalo@codeaurora.org> (maintainer:NETWORKING DRIVERS (WIRELESS),commit_signer:27/35=77%)
Eliad Peller <eliad@wizery.com> (commit_signer:9/35=26%,authored:7/35=20%)
Guy Mishol <guym@ti.com> (commit_signer:6/35=17%,authored:5/35=14%)
Johannes Berg <johannes.berg@intel.com> (commit_signer:6/35=17%,authored:3/35=9%)
Uri Mashiach <uri.mashiach@compulab.co.il> (commit_signer:4/35=11%,authored:4/35=11%)

For those people now added to the cc list,
here's the original patch thread:

https://lkml.org/lkml/2016/3/7/1099

[toc] | [prev] | [next] | [standalone]


#1368035 — Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

FromEliad Peller <eliad@wizery.com>
Date2016-03-31 11:10 +0200
SubjectRe: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Message-ID<riGM3-2Es-33@gated-at.bofh.it>
In reply to#1367936
On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote:
>> Joe Perches <joe@perches.com> writes:
>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
>> > > Joe Perches <joe@perches.com> writes:
>> > > >
>> > > > Using the normal kernel logging mechanisms makes this code
>> > > > a bit more like other wireless drivers.
>> > > Personally I don't see the point but I don't have any strong opinions. A
>> > > bigger problem is that TI drivers are not really in active development
>> > > and that's I'm not thrilled to take big patches like this for dormant
>> > > drivers.
>> > Not very dormant.
>> >
>> > 35 patches in the last year, most of them adding functionality.
>> Oh, I didn't realise it had that many patches. But the driver is
>> orphaned and doesn't have a maintainer so could I then have an ack from
>> one of the active contributors that this ok?
>
> Fine by me.
>
> $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/
>
> Kalle Valo <kvalo@codeaurora.org> (maintainer:NETWORKING DRIVERS (WIRELESS),commit_signer:27/35=77%)
> Eliad Peller <eliad@wizery.com> (commit_signer:9/35=26%,authored:7/35=20%)
> Guy Mishol <guym@ti.com> (commit_signer:6/35=17%,authored:5/35=14%)
> Johannes Berg <johannes.berg@intel.com> (commit_signer:6/35=17%,authored:3/35=9%)
> Uri Mashiach <uri.mashiach@compulab.co.il> (commit_signer:4/35=11%,authored:4/35=11%)
>
> For those people now added to the cc list,
> here's the original patch thread:
>
> https://lkml.org/lkml/2016/3/7/1099

I don't have a strong opinion here either.
(I do like the trailing newline being added automatically, but that's
hardly an issue...)

Eliad.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web