Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367758 > unrolled thread

linux-next: build failure after merge of the gpio tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-31 04:30 +0200
    Re: linux-next: build failure after merge of the gpio tree Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 10:00 +0200

#1367758 — linux-next: build failure after merge of the gpio tree

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
  struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
                          ^
cc1: all warnings being treated as errors

Caused by commit

  0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 31 Mar 2016 13:18:45 +1100
Subject: [PATCH] powerpc: ppc4xx: remove unused local variable

Fixes: 0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/sysdev/ppc4xx_gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c
index 4ab83cd04785..5382d04dd872 100644
--- a/arch/powerpc/sysdev/ppc4xx_gpio.c
+++ b/arch/powerpc/sysdev/ppc4xx_gpio.c
@@ -90,7 +90,6 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 static void
 ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 {
-	struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
 	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);
 	unsigned long flags;
 
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1367928

On Thu, Mar 31, 2016 at 4:22 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
> arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
>   struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
>                           ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
>
> I applied this patch for today:

Thanks Stephen, I indicentally merged an identical patch after
late results from the autobuilder.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web