Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1366313 > unrolled thread
| Started by | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| First post | 2016-03-29 16:10 +0200 |
| Last post | 2016-03-30 00:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-29 16:10 +0200
Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-03-29 21:20 +0200
Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Junichi Nomura <j-nomura@ce.jp.nec.com> - 2016-03-30 00:40 +0200
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Date | 2016-03-29 16:10 +0200 |
| Subject | Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing |
| Message-ID | <ri2vf-7oJ-11@gated-at.bofh.it> |
On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote:
> Hi Al,
>
> Moved to 4.6-rc1 and found NFS mounts were failing moving to the new
> kernel. The NFS mounts are done using autofs. Below is the bisect log
> and attached the kernel .config file. Let me know if you need any other
> information.
AFAICS, it's the same one that got reported yesterday by Junichi Nomura.
Folks, could you check if the delta below fixes it?
diff --git a/fs/namei.c b/fs/namei.c
index 3498d53..0d80c72 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1740,15 +1740,17 @@ static int walk_component(struct nameidata *nd, int flags)
nd->flags);
if (IS_ERR(path.dentry))
return PTR_ERR(path.dentry);
- if (unlikely(d_is_negative(path.dentry))) {
- dput(path.dentry);
- return -ENOENT;
- }
+
path.mnt = nd->path.mnt;
err = follow_managed(&path, nd);
if (unlikely(err < 0))
return err;
+ if (unlikely(d_is_negative(path.dentry))) {
+ path_to_nameidata(&path, nd);
+ return -ENOENT;
+ }
+
seq = 0; /* we are already out of RCU mode */
inode = d_backing_inode(path.dentry);
}
[toc] | [next] | [standalone]
| From | Arend van Spriel <arend.vanspriel@broadcom.com> |
|---|---|
| Date | 2016-03-29 21:20 +0200 |
| Message-ID | <ri7lg-2gu-17@gated-at.bofh.it> |
| In reply to | #1366313 |
On 29-03-16 16:02, Al Viro wrote:
> On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote:
>> Hi Al,
>>
>> Moved to 4.6-rc1 and found NFS mounts were failing moving to the new
>> kernel. The NFS mounts are done using autofs. Below is the bisect log
>> and attached the kernel .config file. Let me know if you need any other
>> information.
>
> AFAICS, it's the same one that got reported yesterday by Junichi Nomura.
> Folks, could you check if the delta below fixes it?
Works for me so you may add
Tested-by: Arend van Spriel <arend@broadcom.com>
Regards,
Arend
> diff --git a/fs/namei.c b/fs/namei.c
> index 3498d53..0d80c72 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1740,15 +1740,17 @@ static int walk_component(struct nameidata *nd, int flags)
> nd->flags);
> if (IS_ERR(path.dentry))
> return PTR_ERR(path.dentry);
> - if (unlikely(d_is_negative(path.dentry))) {
> - dput(path.dentry);
> - return -ENOENT;
> - }
> +
> path.mnt = nd->path.mnt;
> err = follow_managed(&path, nd);
> if (unlikely(err < 0))
> return err;
>
> + if (unlikely(d_is_negative(path.dentry))) {
> + path_to_nameidata(&path, nd);
> + return -ENOENT;
> + }
> +
> seq = 0; /* we are already out of RCU mode */
> inode = d_backing_inode(path.dentry);
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Junichi Nomura <j-nomura@ce.jp.nec.com> |
|---|---|
| Date | 2016-03-30 00:40 +0200 |
| Message-ID | <riasN-4m1-5@gated-at.bofh.it> |
| In reply to | #1366562 |
On 03/30/16 04:17, Arend van Spriel wrote: > On 29-03-16 16:02, Al Viro wrote: >> On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote: >>> Moved to 4.6-rc1 and found NFS mounts were failing moving to the new >>> kernel. The NFS mounts are done using autofs. Below is the bisect log >>> and attached the kernel .config file. Let me know if you need any other >>> information. >> >> AFAICS, it's the same one that got reported yesterday by Junichi Nomura. >> Folks, could you check if the delta below fixes it? > > Works for me so you may add > > Tested-by: Arend van Spriel <arend@broadcom.com> Yes, that works for me, too. Thank you. Tested-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> -- Jun'ichi Nomura, NEC Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web