Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1361637 > unrolled thread
| Started by | Yakir Yang <ykk@rock-chips.com> |
|---|---|
| First post | 2016-03-21 10:40 +0100 |
| Last post | 2016-03-29 13:50 +0200 |
| Articles | 3 on this page of 23 — 5 participants |
Back to article view | Back to linux.kernel
[RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-21 10:40 +0100
[RFC PATCH v1 3/4] ARM: dts: rockchip: add RGA device node for RK3288 Yakir Yang <ykk@rock-chips.com> - 2016-03-21 10:50 +0100
[RFC PATCH v1 4/4] ARM: dst: rockchip: enable RGA support on veyron devices Yakir Yang <ykk@rock-chips.com> - 2016-03-21 10:50 +0100
[RFC PATCH v1 1/4] drm: rockchip: add a common subdrv interfaces Yakir Yang <ykk@rock-chips.com> - 2016-03-21 10:50 +0100
[RFC PATCH v1 2/4] drm: rockchip: add RGA driver support Yakir Yang <ykk@rock-chips.com> - 2016-03-21 10:50 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner <heiko@sntech.de> - 2016-03-21 12:40 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-21 13:20 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stuebner <heiko@sntech.de> - 2016-03-22 01:50 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-22 03:20 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-28 14:30 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner <heiko@sntech.de> - 2016-03-28 20:50 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-28 23:40 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner <heiko@sntech.de> - 2016-03-28 23:50 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-29 00:10 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner <heiko@sntech.de> - 2016-03-29 00:20 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-29 15:20 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-30 22:10 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-29 13:20 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner <heiko@sntech.de> - 2016-03-29 13:50 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-29 13:50 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-29 15:30 +0200
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Andreas Färber <afaerber@suse.de> - 2016-03-22 11:30 +0100
Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang <ykk@rock-chips.com> - 2016-03-29 13:50 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Emil Velikov <emil.l.velikov@gmail.com> |
|---|---|
| Date | 2016-03-29 15:30 +0200 |
| Message-ID | <ri1SA-6PD-23@gated-at.bofh.it> |
| In reply to | #1366187 |
Hi Yakir, On 29 March 2016 at 12:40, Yakir Yang <ykk@rock-chips.com> wrote: > Hi Emil, > > On 03/28/2016 08:21 PM, Emil Velikov wrote: >> >> On 22 March 2016 at 00:42, Heiko Stuebner <heiko@sntech.de> wrote: >>> >>> Hi Yakir, >>> >>> Am Montag, 21. März 2016, 20:17:46 schrieb Yakir Yang: >>>> >>>> On 03/21/2016 07:29 PM, Heiko Stübner wrote: >>>>> >>>>> Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang: >>>>>> >>>>>> This patch set would add the RGA direct rendering based 2d graphics >>>>>> acceleration module. >>>>> >>>>> very cool to see that. >>>> >>>> ;) >>>> >>>>>> This patch set is based on git repository below: >>>>>> git://people.freedesktop.org/~airlied/linux drm-next >>>>>> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 >>>>>> >>>>>> And the RGA driver is based on Exynos G2D driver, it only manages the >>>>>> command lists received from user, so user should make the command list >>>>>> to data and registers needed by operation to use. >>>>>> >>>>>> I have prepared an userspace demo application for testing: >>>>>> https://github.com/yakir-Yang/libdrm-rockchip >>>>>> >>>>>> That is a rockchip libdrm library, and I have write a simple test case >>>>>> "rockchip_rga_test" that would test the below RGA features: >>>>>> - solid >>>>>> - copy >>>>>> - rotation >>>>>> - flip >>>>>> - window clip >>>>>> - dithering >>>>> >>>>> Did you submit your libdrm changes as well? >>>>> >>>>> Userspace-interfaces need to be stable so the other side must also get >>>>> accepted - even before the kernel change if I remember correctly. >>>> >>>> Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. >>>> But I don't find the way to submit patches to libdrm, would you like >>>> share some helps here ;) >>> >>> Looking at the libdrm sources on cgit.freedesktop.org, I did not find any >>> specific manual on submitting patches. >>> >>> But looking at the dri-list archive, dri-devel@lists.freedesktop.org is >>> the >>> right list and looking at the libdrm history it looks like Emil Velikov >>> <emil.l.velikov@gmail.com> seems to be doing maintenance-stuff in libdrm. >>> And as a 3rd recipient, please also include the linux-rockchip list. >>> >>> @Emil, please shout if I read that wrong :-) >>> >> You got it spot on Heiko. There are a few notes though... >> >> As one reuses the existing hardware/IP block, it would be better to >> avoid copy/pasting code around. >> Namely: >> - (if possible) factor out the exynos g2d kernel functionality to a >> separate kernel module and wire up the rockhip (via dt ?) to use it >> - factor out the g2d specifics out of exynos_drm.h (into >> exynos_g2d_drm.h perhaps ?) and make sure exynos_drm.h includes the >> new header >> - if neither of these are possible, then please ensure that the new >> header uses correct types (see the docs [1]), use MIT/X11 license (if >> possible) and link where upstream userspace is happy with the >> interface (ideally more than a simple test app like libdrm) > > > Whops... you have provided the third choice, nice :-D > > And I got little idea about license, where should I use the MIT/X11 > license, should I declare the MIT/X11 license in kernel uapi head > file, but Andreas just remind that kernel do not allow to no GUN > license. Or may be I can: Now that's a lovely typo - (GNU vs GUN) :-) But seriously - what makes you think that the kernel does not allow MIT/X11 licensed code ? Most of the DRM subsystem uses it. > 1. Use GUN license in kernel rockchip_drm.h uapi head file > 2. Use MIT/X11 license in libdrm rockchip_drm.h head file. > I would suggest keeping the license the same in both places (the libdrm ones should be a direct copy of the kernel one produced with `make headers_install`), regardless of which one you opt for. > And I don't understand the "link where upstream userspace is happy > with the interface", could you reference small example here. > Already mentioned elsewhere but for posterity: If designing a new interface one should provide a reference to a maintained upstream project, where the design was approved. Reason being is that unlike ChromeOS's kernel upstream one gets to keep its interfaces forever. And yes, I realise that CrOS folks are trying really hard to upstream things and use vanilla kernel. Regards, Emil
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2016-03-22 11:30 +0100 |
| Message-ID | <rfrJw-2ZK-5@gated-at.bofh.it> |
| In reply to | #1361757 |
Hi Yakir, Am 21.03.2016 um 13:17 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko Stübner wrote: >> Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang: >>> This patch set would add the RGA direct rendering based 2d graphics >>> acceleration module. >> very cool to see that. > ;) >>> This patch set is based on git repository below: >>> git://people.freedesktop.org/~airlied/linux drm-next >>> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 >>> >>> And the RGA driver is based on Exynos G2D driver, it only manages the >>> command lists received from user, so user should make the command list >>> to data and registers needed by operation to use. >>> >>> I have prepared an userspace demo application for testing: >>> https://github.com/yakir-Yang/libdrm-rockchip >>> That is a rockchip libdrm library, and I have write a simple test case >>> "rockchip_rga_test" that would test the below RGA features: >>> - solid >>> - copy >>> - rotation >>> - flip >>> - window clip >>> - dithering >> Did you submit your libdrm changes as well? >> >> Userspace-interfaces need to be stable so the other side must also get >> accepted - even before the kernel change if I remember correctly. > > Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. > But I don't find the way to submit patches to libdrm, would you like > share some helps here ;) If you're using Exynos as an example, please keep in mind that the libdrm license is MIT/X11, not GPL as the kernel. For our Linux distro we had to disable some Exynos parts because they snuck some GPL code in there and redistributing libdrm under GPL would cause a big headache (review of all packages directly or indirectly linking against it). Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Yakir Yang <ykk@rock-chips.com> |
|---|---|
| Date | 2016-03-29 13:50 +0200 |
| Message-ID | <ri0jM-5CR-3@gated-at.bofh.it> |
| In reply to | #1362458 |
Hi Andreas, On 03/22/2016 06:24 PM, Andreas Färber wrote: > Hi Yakir, > > Am 21.03.2016 um 13:17 schrieb Yakir Yang: >> On 03/21/2016 07:29 PM, Heiko Stübner wrote: >>> Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang: >>>> This patch set would add the RGA direct rendering based 2d graphics >>>> acceleration module. >>> very cool to see that. >> ;) >>>> This patch set is based on git repository below: >>>> git://people.freedesktop.org/~airlied/linux drm-next >>>> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 >>>> >>>> And the RGA driver is based on Exynos G2D driver, it only manages the >>>> command lists received from user, so user should make the command list >>>> to data and registers needed by operation to use. >>>> >>>> I have prepared an userspace demo application for testing: >>>> https://github.com/yakir-Yang/libdrm-rockchip >>>> That is a rockchip libdrm library, and I have write a simple test case >>>> "rockchip_rga_test" that would test the below RGA features: >>>> - solid >>>> - copy >>>> - rotation >>>> - flip >>>> - window clip >>>> - dithering >>> Did you submit your libdrm changes as well? >>> >>> Userspace-interfaces need to be stable so the other side must also get >>> accepted - even before the kernel change if I remember correctly. >> Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. >> But I don't find the way to submit patches to libdrm, would you like >> share some helps here ;) > If you're using Exynos as an example, please keep in mind that the > libdrm license is MIT/X11, not GPL as the kernel. For our Linux distro > we had to disable some Exynos parts because they snuck some GPL code in > there and redistributing libdrm under GPL would cause a big headache > (review of all packages directly or indirectly linking against it). Hmmm... I just saw exynos_drm.h still declared the GNU license, is it convince for you to share some specific example here ;) Thanks, - Yakir > Thanks, > Andreas >
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web