Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1365151 > unrolled thread
| Started by | Aniket Sharma <badbuddha91@gmail.com> |
|---|---|
| First post | 2016-03-27 20:00 +0200 |
| Last post | 2016-03-29 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: comedi: Fix 'unsigned' warning style Aniket Sharma <badbuddha91@gmail.com> - 2016-03-27 20:00 +0200
Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style Ian Abbott <abbotti@mev.co.uk> - 2016-03-29 11:40 +0200
| From | Aniket Sharma <badbuddha91@gmail.com> |
|---|---|
| Date | 2016-03-27 20:00 +0200 |
| Subject | [PATCH] Staging: comedi: Fix 'unsigned' warning style |
| Message-ID | <rhn8K-3gG-7@gated-at.bofh.it> |
This patch fixes the checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned runflags;
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
Signed-off-by: Aniket Sharma <badbuddha91@gmail.com>
---
drivers/staging/comedi/comedidev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 1158072..dcb6376 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -173,7 +173,7 @@ struct comedi_subdevice {
void *lock;
void *busy;
- unsigned runflags;
+ unsigned int runflags;
spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */
unsigned int io_bits;
@@ -566,7 +566,7 @@ struct comedi_device {
void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
-struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
+struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
int comedi_dev_put(struct comedi_device *dev);
bool comedi_is_subdevice_running(struct comedi_subdevice *s);
--
1.9.1
[toc] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2016-03-29 11:40 +0200 |
| Message-ID | <rhYhY-3YN-15@gated-at.bofh.it> |
| In reply to | #1365151 |
On 27/03/16 18:52, Aniket Sharma wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned runflags;
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
>
> Signed-off-by: Aniket Sharma <badbuddha91@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1158072..dcb6376 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -173,7 +173,7 @@ struct comedi_subdevice {
>
> void *lock;
> void *busy;
> - unsigned runflags;
> + unsigned int runflags;
> spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */
>
> unsigned int io_bits;
> @@ -566,7 +566,7 @@ struct comedi_device {
>
> void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
>
> -struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
> +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
> int comedi_dev_put(struct comedi_device *dev);
>
> bool comedi_is_subdevice_running(struct comedi_subdevice *s);
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web