Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1365700 > unrolled thread

[PATCH] bpf: doc: "neg" opcode has no operands

Started byKees Cook <keescook@chromium.org>
First post2016-03-29 00:00 +0200
Last post2016-03-31 08:40 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] bpf: doc: "neg" opcode has no operands Kees Cook <keescook@chromium.org> - 2016-03-29 00:00 +0200
    Re: [PATCH] bpf: doc: "neg" opcode has no operands Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-03-29 02:40 +0200
    Re: [PATCH] bpf: doc: "neg" opcode has no operands Daniel Borkmann <daniel@iogearbox.net> - 2016-03-29 10:00 +0200
    Re: [PATCH] bpf: doc: "neg" opcode has no operands Jonathan Corbet <corbet@lwn.net> - 2016-03-31 08:40 +0200

#1365700 — [PATCH] bpf: doc: "neg" opcode has no operands

FromKees Cook <keescook@chromium.org>
Date2016-03-29 00:00 +0200
Subject[PATCH] bpf: doc: "neg" opcode has no operands
Message-ID<rhNmz-4Fv-17@gated-at.bofh.it>
From: Dave Anderson <danderson@google.com>

Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
and thus has no addressing modes.

Signed-off-by: Dave Anderson <danderson@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 Documentation/networking/filter.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/filter.txt b/Documentation/networking/filter.txt
index 96da119a47e7..11f67f181d39 100644
--- a/Documentation/networking/filter.txt
+++ b/Documentation/networking/filter.txt
@@ -230,7 +230,7 @@ opcodes as defined in linux/filter.h stand for:
   mul              0, 4                 A * <x>
   div              0, 4                 A / <x>
   mod              0, 4                 A % <x>
-  neg              0, 4                 !A
+  neg                                   !A
   and              0, 4                 A & <x>
   or               0, 4                 A | <x>
   xor              0, 4                 A ^ <x>
-- 
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security

[toc] | [next] | [standalone]


#1365735

FromAlexei Starovoitov <alexei.starovoitov@gmail.com>
Date2016-03-29 02:40 +0200
Message-ID<rhPRn-6yl-1@gated-at.bofh.it>
In reply to#1365700
On Mon, Mar 28, 2016 at 02:56:47PM -0700, Kees Cook wrote:
> From: Dave Anderson <danderson@google.com>
> 
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
> 
> Signed-off-by: Dave Anderson <danderson@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Alexei Starovoitov <ast@kernel.org>

[toc] | [prev] | [next] | [standalone]


#1365968

FromDaniel Borkmann <daniel@iogearbox.net>
Date2016-03-29 10:00 +0200
Message-ID<rhWJc-2Uj-3@gated-at.bofh.it>
In reply to#1365700
On 03/28/2016 11:56 PM, Kees Cook wrote:
> From: Dave Anderson <danderson@google.com>
>
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.
>
> Signed-off-by: Dave Anderson <danderson@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

[toc] | [prev] | [next] | [standalone]


#1367850

FromJonathan Corbet <corbet@lwn.net>
Date2016-03-31 08:40 +0200
Message-ID<riEqS-P8-7@gated-at.bofh.it>
In reply to#1365700
On Mon, 28 Mar 2016 14:56:47 -0700
Kees Cook <keescook@chromium.org> wrote:

> From: Dave Anderson <danderson@google.com>
> 
> Fixes a copy-paste-o in the BPF opcode table: "neg" takes no arguments
> and thus has no addressing modes.

I've applied this to the docs tree, thanks.

jon

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web