Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1365447 > unrolled thread

[PATCH] rtc: at91sam9: remove duplicate assignment of variable mr

Started byColin King <colin.king@canonical.com>
First post2016-03-28 13:30 +0200
Last post2016-03-29 00:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr Colin King <colin.king@canonical.com> - 2016-03-28 13:30 +0200
    Re: [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-29 00:20 +0200

#1365447 — [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr

FromColin King <colin.king@canonical.com>
Date2016-03-28 13:30 +0200
Subject[PATCH] rtc: at91sam9: remove duplicate assignment of variable mr
Message-ID<rhDwR-6m3-5@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

mr is written twice with the same value, remove one of the
redundant assignments to mr.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/rtc/rtc-at91sam9.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index 7206e2f..99732e6 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers/rtc/rtc-at91sam9.c
@@ -268,7 +268,7 @@ static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
 static int at91_rtc_proc(struct device *dev, struct seq_file *seq)
 {
 	struct sam9_rtc *rtc = dev_get_drvdata(dev);
-	u32 mr = mr = rtt_readl(rtc, MR);
+	u32 mr = rtt_readl(rtc, MR);
 
 	seq_printf(seq, "update_IRQ\t: %s\n",
 			(mr & AT91_RTT_RTTINCIEN) ? "yes" : "no");
-- 
2.7.4

[toc] | [next] | [standalone]


#1365706

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2016-03-29 00:20 +0200
Message-ID<rhNFT-53u-3@gated-at.bofh.it>
In reply to#1365447
On 28/03/2016 at 12:24:00 +0100, Colin King wrote :
> From: Colin Ian King <colin.king@canonical.com>
> 
> mr is written twice with the same value, remove one of the
> redundant assignments to mr.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/rtc/rtc-at91sam9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web