Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365671 > unrolled thread

[GIT PULL 0/1] perf/urgent fix

Back to article view | Back to linux.kernel

Contents

  [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-28 23:00 +0200
    [PATCH 1/1] perf tools: Fix build break on powerpc Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-28 23:00 +0200
      Re: [PATCH 1/1] perf tools: Fix build break on powerpc Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-29 00:40 +0200
    Re: [GIT PULL 0/1] perf/urgent fix Ingo Molnar <mingo@kernel.org> - 2016-03-29 10:50 +0200

#1365671 — [GIT PULL 0/1] perf/urgent fix

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit a49ac9f83b31e41c8311d64bd2b3f97a23dcb38d:

  perf/x86: Move events_sysfs_show() outside CPU_SUP_INTEL (2016-03-25 09:46:53 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160328

for you to fetch changes up to 379649cfeafef29b77d29860741f4d1c5870b65f:

  perf tools: Fix build break on powerpc (2016-03-28 17:46:20 -0300)

----------------------------------------------------------------
perf/urgent fix:

- Fix build break on powerpc due to missing headers with prototypes for
  functions defined in tools/perf/arch/powerpc/util/header.c (Sukadev Bhattiprolu)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Sukadev Bhattiprolu (1):
      perf tools: Fix build break on powerpc

 tools/perf/arch/powerpc/util/header.c | 2 ++
 1 file changed, 2 insertions(+)

[toc] | [next] | [standalone]

#1365673 — [PATCH 1/1] perf tools: Fix build break on powerpc

From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

Commit 531d2410635c ("perf tools: Do not include stringify.h from the
kernel sources") seems to have accidentially removed the inclusion of
"util/header.h" from "arch/powerpc/util/header.c".

"util/header.h" provides the prototype for get_cpuid() and is needed to
build perf on Powerpc:

	arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes]

Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
[ Included "util.h" too, to get the scnprintf() prototype ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/arch/powerpc/util/header.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
index 6138bdef6e63..f8ccee132867 100644
--- a/tools/perf/arch/powerpc/util/header.c
+++ b/tools/perf/arch/powerpc/util/header.c
@@ -4,6 +4,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <linux/stringify.h>
+#include "header.h"
+#include "util.h"
 
 #define mfspr(rn)       ({unsigned long rval; \
 			 asm volatile("mfspr %0," __stringify(rn) \
-- 
2.5.5

[toc] | [prev] | [next] | [standalone]

#1365712 — Re: [PATCH 1/1] perf tools: Fix build break on powerpc

Hi Arnaldo,

On Mon, 28 Mar 2016 17:52:34 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> 
> Commit 531d2410635c ("perf tools: Do not include stringify.h from the
> kernel sources") seems to have accidentially removed the inclusion of
> "util/header.h" from "arch/powerpc/util/header.c".
> 
> "util/header.h" provides the prototype for get_cpuid() and is needed to
> build perf on Powerpc:
> 
> 	arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes]
> 
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> [ Included "util.h" too, to get the scnprintf() prototype ]
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/arch/powerpc/util/header.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 6138bdef6e63..f8ccee132867 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -4,6 +4,8 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <linux/stringify.h>
> +#include "header.h"
> +#include "util.h"
>  
>  #define mfspr(rn)       ({unsigned long rval; \
>  			 asm volatile("mfspr %0," __stringify(rn) \
> -- 
> 2.5.5

Thanks, I will put that in my "fixes" tree until it gets accepted
upstream.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1366016

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit a49ac9f83b31e41c8311d64bd2b3f97a23dcb38d:
> 
>   perf/x86: Move events_sysfs_show() outside CPU_SUP_INTEL (2016-03-25 09:46:53 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160328
> 
> for you to fetch changes up to 379649cfeafef29b77d29860741f4d1c5870b65f:
> 
>   perf tools: Fix build break on powerpc (2016-03-28 17:46:20 -0300)
> 
> ----------------------------------------------------------------
> perf/urgent fix:
> 
> - Fix build break on powerpc due to missing headers with prototypes for
>   functions defined in tools/perf/arch/powerpc/util/header.c (Sukadev Bhattiprolu)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Sukadev Bhattiprolu (1):
>       perf tools: Fix build break on powerpc
> 
>  tools/perf/arch/powerpc/util/header.c | 2 ++
>  1 file changed, 2 insertions(+)

Pulled, thanks a lot Arnaldo!

	Ingo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web