Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364383 > unrolled thread

[PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output

Started byPriit Laes <Priit.Laes@icefire.ee>
First post2016-03-24 19:10 +0100
Last post2016-03-24 19:50 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output Priit Laes <Priit.Laes@icefire.ee> - 2016-03-24 19:10 +0100
    [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output Priit Laes <Priit.Laes@icefire.ee> - 2016-03-24 19:10 +0100
      Re: [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for  simplefb TV output Chen-Yu Tsai <wens@csie.org> - 2016-03-25 04:10 +0100
    [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output Priit Laes <Priit.Laes@icefire.ee> - 2016-03-24 19:10 +0100
      Re: [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for  simplefb TV output Chen-Yu Tsai <wens@csie.org> - 2016-03-25 04:10 +0100
    Re: [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for  simplefb TV output Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-24 19:50 +0100

#1364383 — [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output

FromPriit Laes <Priit.Laes@icefire.ee>
Date2016-03-24 19:10 +0100
Subject[PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output
Message-ID<rghRL-6vv-5@gated-at.bofh.it>
From: Priit Laes <plaes@plaes.org>

DRAM gating driver commit for sun[47]i seems to be missing DRAM gate bit 5 for
simplefb TV output node. Add it.

Priit Laes (2):
  ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
  ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

 arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
 arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.5.0

[toc] | [next] | [standalone]

#1364384 — [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

FromPriit Laes <Priit.Laes@icefire.ee>
Date2016-03-24 19:10 +0100
Subject[PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
Message-ID<rghRM-6vv-17@gated-at.bofh.it>
In reply to#1364383
From: Priit Laes <plaes@plaes.org>

Seems like dram_gate 5 was forgotten when DRAM gating driver was added.

Enable it.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 0940a78..ee4e8e7 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -85,8 +85,9 @@
 			compatible = "allwinner,simple-framebuffer",
 				     "simple-framebuffer";
 			allwinner,pipeline = "de_be0-lcd0-tve0";
-			clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
-				 <&ahb_gates 44>, <&dram_gates 26>;
+			clocks = <&pll5 1>,
+				 <&ahb_gates 34>, <&ahb_gates 36>, <&ahb_gates 44>,
+				 <&dram_gates 5>, <&dram_gates 26>;
 			status = "disabled";
 		};
 	};
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1364543 — Re: [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

FromChen-Yu Tsai <wens@csie.org>
Date2016-03-25 04:10 +0100
SubjectRe: [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
Message-ID<rgqim-3Lz-1@gated-at.bofh.it>
In reply to#1364384
On Fri, Mar 25, 2016 at 2:08 AM, Priit Laes <Priit.Laes@icefire.ee> wrote:
> From: Priit Laes <plaes@plaes.org>
>
> Seems like dram_gate 5 was forgotten when DRAM gating driver was added.
>
> Enable it.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>


Fixes: 0b4bf5a5200b ("ARM: dts: sun7i: Add DRAM gates")

Thanks!

> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 0940a78..ee4e8e7 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -85,8 +85,9 @@
>                         compatible = "allwinner,simple-framebuffer",
>                                      "simple-framebuffer";
>                         allwinner,pipeline = "de_be0-lcd0-tve0";
> -                       clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
> -                                <&ahb_gates 44>, <&dram_gates 26>;
> +                       clocks = <&pll5 1>,
> +                                <&ahb_gates 34>, <&ahb_gates 36>, <&ahb_gates 44>,
> +                                <&dram_gates 5>, <&dram_gates 26>;
>                         status = "disabled";
>                 };
>         };
> --
> 2.5.0
>

[toc] | [prev] | [next] | [standalone]

#1364385 — [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

FromPriit Laes <Priit.Laes@icefire.ee>
Date2016-03-24 19:10 +0100
Subject[PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
Message-ID<rghRM-6vv-19@gated-at.bofh.it>
In reply to#1364383
From: Priit Laes <plaes@plaes.org>

Seems like dram_gate 5 was forgotten when DRAM gate driver was added.

Enable it.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 2c8f5e6..bf70d0a 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -96,7 +96,7 @@
 			allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
 			clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
 				 <&ahb_gates 44>, <&ahb_gates 46>,
-				 <&dram_gates 25>, <&dram_gates 26>;
+				 <&dram_gates 5>, <&dram_gates 25>, <&dram_gates 26>;
 			status = "disabled";
 		};
 	};
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1364545 — Re: [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

FromChen-Yu Tsai <wens@csie.org>
Date2016-03-25 04:10 +0100
SubjectRe: [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
Message-ID<rgqim-3Lz-7@gated-at.bofh.it>
In reply to#1364385
On Fri, Mar 25, 2016 at 2:08 AM, Priit Laes <Priit.Laes@icefire.ee> wrote:
> From: Priit Laes <plaes@plaes.org>
>
> Seems like dram_gate 5 was forgotten when DRAM gate driver was added.
>
> Enable it.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>

Fixes: 82f8582feef4 ("ARM: dts: sun4i: Add DRAM gates")

Thanks!

> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 2c8f5e6..bf70d0a 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -96,7 +96,7 @@
>                         allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
>                         clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
>                                  <&ahb_gates 44>, <&ahb_gates 46>,
> -                                <&dram_gates 25>, <&dram_gates 26>;
> +                                <&dram_gates 5>, <&dram_gates 25>, <&dram_gates 26>;
>                         status = "disabled";
>                 };
>         };
> --
> 2.5.0
>

[toc] | [prev] | [next] | [standalone]

#1364397 — Re: [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-03-24 19:50 +0100
SubjectRe: [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output
Message-ID<rgiut-6NM-5@gated-at.bofh.it>
In reply to#1364383

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Thu, Mar 24, 2016 at 08:08:38PM +0200, Priit Laes wrote:
> From: Priit Laes <plaes@plaes.org>
> 
> DRAM gating driver commit for sun[47]i seems to be missing DRAM gate bit 5 for
> simplefb TV output node. Add it.

Thanks, could you please add the Fixes tag and Cc stable ?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web