Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360084 > unrolled thread

[PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

Started byLucas Stach <l.stach@pengutronix.de>
First post2016-03-17 18:50 +0100
Last post2016-03-24 17:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior Lucas Stach <l.stach@pengutronix.de> - 2016-03-17 18:50 +0100
    Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check  function behavior Vlastimil Babka <vbabka@suse.cz> - 2016-03-24 17:00 +0100
      Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check  function behavior Vlastimil Babka <vbabka@suse.cz> - 2016-03-24 17:00 +0100

#1360084 — [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

FromLucas Stach <l.stach@pengutronix.de>
Date2016-03-17 18:50 +0100
Subject[PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
Message-ID<rdKdA-1Zz-7@gated-at.bofh.it>
Page isolation has not failed if the fin pfn extends beyond the end pfn
and test_pages_isolated checks this correctly. Fix the tracepoint to
report the same result as the actual check function.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 include/trace/events/page_isolation.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
index 6fb644029c80..8738a78e6bf4 100644
--- a/include/trace/events/page_isolation.h
+++ b/include/trace/events/page_isolation.h
@@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
 
 	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
 		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
-		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
+		__entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
 );
 
 #endif /* _TRACE_PAGE_ISOLATION_H */
-- 
2.7.0

[toc] | [next] | [standalone]

#1364292 — Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

FromVlastimil Babka <vbabka@suse.cz>
Date2016-03-24 17:00 +0100
SubjectRe: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
Message-ID<rgfPX-4J1-3@gated-at.bofh.it>
In reply to#1360084
On 03/17/2016 06:40 PM, Lucas Stach wrote:
> Page isolation has not failed if the fin pfn extends beyond the end pfn
> and test_pages_isolated checks this correctly. Fix the tracepoint to
> report the same result as the actual check function.

Right.

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>   include/trace/events/page_isolation.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
> index 6fb644029c80..8738a78e6bf4 100644
> --- a/include/trace/events/page_isolation.h
> +++ b/include/trace/events/page_isolation.h
> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>
>   	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
>   		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
> -		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
> +		__entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
>   );
>
>   #endif /* _TRACE_PAGE_ISOLATION_H */
>

[toc] | [prev] | [next] | [standalone]

#1364298 — Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

FromVlastimil Babka <vbabka@suse.cz>
Date2016-03-24 17:00 +0100
SubjectRe: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
Message-ID<rgfQ0-4J1-45@gated-at.bofh.it>
In reply to#1364292
On 03/24/2016 04:51 PM, Vlastimil Babka wrote:
> On 03/17/2016 06:40 PM, Lucas Stach wrote:
>> Page isolation has not failed if the fin pfn extends beyond the end pfn
>> and test_pages_isolated checks this correctly. Fix the tracepoint to
>> report the same result as the actual check function.
>
> Right.
>
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Note you didn't have Andrew in To/Cc.

>> ---
>>    include/trace/events/page_isolation.h | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
>> index 6fb644029c80..8738a78e6bf4 100644
>> --- a/include/trace/events/page_isolation.h
>> +++ b/include/trace/events/page_isolation.h
>> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>>
>>    	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
>>    		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
>> -		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
>> +		__entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
>>    );
>>
>>    #endif /* _TRACE_PAGE_ISOLATION_H */
>>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web