Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364153 > unrolled thread

Re: [1/2] bcma: fix building without OF_IRQ

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [1/2] bcma: fix building without OF_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-03-24 14:20 +0100
    Re: [1/2] bcma: fix building without OF_IRQ Kalle Valo <kvalo@codeaurora.org> - 2016-03-24 15:00 +0100
      Re: [1/2] bcma: fix building without OF_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-03-24 15:10 +0100

#1364153 — Re: [1/2] bcma: fix building without OF_IRQ

On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
> > The bcma driver core can be built with or without DT support, but
> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> > can happen on platforms that do not support IRQ domains.
> > 
> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
> > 
> > This adds another compile-time check for OF_IRQ, but also
> > gets rid of now unneeded #ifdef checks: Using the simpler
> > IS_ENABLED() check for OF_IRQ also covers the case of not
> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> > was added to allow building on architectures without
> > OF_ADDRESS, but that has been addressed already in
> > b1d06b60e90c ("of: Provide static inline function for
> > of_translate_address if needed").
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Thanks, applied to wireless-drivers.git.
> 

Thanks! I see you have applied patch 1/2 but not patch 2/2.

As mentioned in the comment for patch 2, it should be tested
better, but I want to make sure that someone still has it
on their radar.

	Arnd

[toc] | [next] | [standalone]

#1364179

Arnd Bergmann <arnd@arndb.de> writes:

> On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
>> > The bcma driver core can be built with or without DT support, but
>> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
>> > can happen on platforms that do not support IRQ domains.
>> > 
>> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
>> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
>> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
>> > 
>> > This adds another compile-time check for OF_IRQ, but also
>> > gets rid of now unneeded #ifdef checks: Using the simpler
>> > IS_ENABLED() check for OF_IRQ also covers the case of not
>> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
>> > was added to allow building on architectures without
>> > OF_ADDRESS, but that has been addressed already in
>> > b1d06b60e90c ("of: Provide static inline function for
>> > of_translate_address if needed").
>> > 
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> 
>> Thanks, applied to wireless-drivers.git.
>> 
>
> Thanks! I see you have applied patch 1/2 but not patch 2/2.
>
> As mentioned in the comment for patch 2, it should be tested
> better, but I want to make sure that someone still has it
> on their radar.

Just to avoid any confusions I assume you are talking about this patch:

[v2] bcma: use of_dma_configure() to set initial dma mask
https://patchwork.kernel.org/patch/8608751/

It's on my patchwork queue and I'm planning to apply it to
wireless-drivers-next once it opens again. But I'm not able to test the
patch myself, I hope someone else could do it.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1364184

On Thursday 24 March 2016 15:53:14 Kalle Valo wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
> >> > The bcma driver core can be built with or without DT support, but
> >> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> >> > can happen on platforms that do not support IRQ domains.
> >> > 
> >> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> >> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> >> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
> >> > 
> >> > This adds another compile-time check for OF_IRQ, but also
> >> > gets rid of now unneeded #ifdef checks: Using the simpler
> >> > IS_ENABLED() check for OF_IRQ also covers the case of not
> >> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> >> > was added to allow building on architectures without
> >> > OF_ADDRESS, but that has been addressed already in
> >> > b1d06b60e90c ("of: Provide static inline function for
> >> > of_translate_address if needed").
> >> > 
> >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> 
> >> Thanks, applied to wireless-drivers.git.
> >> 
> >
> > Thanks! I see you have applied patch 1/2 but not patch 2/2.
> >
> > As mentioned in the comment for patch 2, it should be tested
> > better, but I want to make sure that someone still has it
> > on their radar.
> 
> Just to avoid any confusions I assume you are talking about this patch:
> 
> [v2] bcma: use of_dma_configure() to set initial dma mask
> https://patchwork.kernel.org/patch/8608751/

Correct.

> It's on my patchwork queue and I'm planning to apply it to
> wireless-drivers-next once it opens again.

Ok, sounds good.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web