Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364108 > unrolled thread

Re: [PATCH 3/3] drm: bridge: anx78xx: Add anx78xx bridge driver support.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/3] drm: bridge: anx78xx: Add anx78xx bridge driver  support. kbuild test robot <lkp@intel.com> - 2016-03-24 13:10 +0100
    [PATCH] drm: bridge: anx78xx: fix ptr_ret.cocci warnings kbuild test robot <lkp@intel.com> - 2016-03-24 13:10 +0100

#1364108 — Re: [PATCH 3/3] drm: bridge: anx78xx: Add anx78xx bridge driver support.

Hi Enric,

[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.5 next-20160324]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-ANX7814-I2C-bridge-driver/20160324-184430
base:   git://people.freedesktop.org/~airlied/linux.git drm-next


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/bridge/anx78xx.c:632:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1364110 — [PATCH] drm: bridge: anx78xx: fix ptr_ret.cocci warnings

drivers/gpu/drm/bridge/anx78xx.c:632:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 anx78xx.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/gpu/drm/bridge/anx78xx.c
+++ b/drivers/gpu/drm/bridge/anx78xx.c
@@ -629,10 +629,7 @@ static int anx78xx_init_gpio(struct anx7
 
 	/* GPIO for V10 power control */
 	pdata->gpiod_v10 = devm_gpiod_get_optional(dev, "v10", GPIOD_OUT_LOW);
-	if (IS_ERR(pdata->gpiod_v10))
-		return PTR_ERR(pdata->gpiod_v10);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(pdata->gpiod_v10);
 }
 
 static int anx78xx_dp_link_training(struct anx78xx *anx78xx)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web