Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363455 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2016-03-23 15:30 +0100 |
| Last post | 2016-03-24 11:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Peter Zijlstra <peterz@infradead.org> - 2016-03-23 15:30 +0100
Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Jiri Olsa <jolsa@redhat.com> - 2016-03-24 10:50 +0100
Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Peter Zijlstra <peterz@infradead.org> - 2016-03-24 11:50 +0100
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-03-23 15:30 +0100 |
| Subject | Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer |
| Message-ID | <rfRXj-4FL-3@gated-at.bofh.it> |
On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > Fixing this by using ftrace_ops::private value to keep > the perf_event pointer. This way we don't need to search > for triggered event (as tracepoint handler does) and > directly store sample. container_of(ops, struct perf_event, ftrace_ops) would also have worked, right?
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2016-03-24 10:50 +0100 |
| Message-ID | <rga3U-Bd-9@gated-at.bofh.it> |
| In reply to | #1363455 |
On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote: > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > > Fixing this by using ftrace_ops::private value to keep > > the perf_event pointer. This way we don't need to search > > for triggered event (as tracepoint handler does) and > > directly store sample. > > container_of(ops, struct perf_event, ftrace_ops) would also have worked, > right? yes, I think that would work too jirka
[toc] | [prev] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-03-24 11:50 +0100 |
| Message-ID | <rgaZY-1gK-7@gated-at.bofh.it> |
| In reply to | #1364032 |
On Thu, Mar 24, 2016 at 10:47:11AM +0100, Jiri Olsa wrote: > On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote: > > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > > > Fixing this by using ftrace_ops::private value to keep > > > the perf_event pointer. This way we don't need to search > > > for triggered event (as tracepoint handler does) and > > > directly store sample. > > > > container_of(ops, struct perf_event, ftrace_ops) would also have worked, > > right? > > yes, I think that would work too OK, no need to change, I was just seeing if I actually understood the code.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web