Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1364631 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2016-03-25 11:50 +0100 |
| Last post | 2016-03-29 01:50 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-25 11:50 +0100
Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix Christoph Hellwig <hch@lst.de> - 2016-03-25 19:10 +0100
Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix Joe Perches <joe@perches.com> - 2016-03-25 19:30 +0100
Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix "J. Bruce Fields" <bfields@fieldses.org> - 2016-03-29 01:50 +0200
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-03-25 11:50 +0100 |
| Subject | [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix |
| Message-ID | <rgxtw-lf-13@gated-at.bofh.it> |
On 32-bit:
fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
this.
Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
fs/nfsd/blocklayout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
index e55b5242614da7a9..31f3df193bdbb47b 100644
--- a/fs/nfsd/blocklayout.c
+++ b/fs/nfsd/blocklayout.c
@@ -290,7 +290,7 @@ out_free_buf:
return error;
}
-#define NFSD_MDS_PR_KEY 0x0100000000000000
+#define NFSD_MDS_PR_KEY 0x0100000000000000ULL
/*
* We use the client ID as a unique key for the reservations.
--
1.9.1
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-03-25 19:10 +0100 |
| Subject | Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix |
| Message-ID | <rgElj-5GC-3@gated-at.bofh.it> |
| In reply to | #1364631 |
Looks fine, thanks! Reviewed-by: Christoph Hellwig <hch@lst.de>
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-25 19:30 +0100 |
| Subject | Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix |
| Message-ID | <rgEEG-5Pe-15@gated-at.bofh.it> |
| In reply to | #1364795 |
On Fri, 2016-03-25 at 19:04 +0100, Christoph Hellwig wrote:
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Outside of the known 64 bit only uses,
this shows a few oddities too:
$ git grep -P -w -i '0x[0-9a-f]{9,16}(?!ull|ll)'
[toc] | [prev] | [next] | [standalone]
| From | "J. Bruce Fields" <bfields@fieldses.org> |
|---|---|
| Date | 2016-03-29 01:50 +0200 |
| Message-ID | <rhP4Z-5Zv-1@gated-at.bofh.it> |
| In reply to | #1364795 |
On Fri, Mar 25, 2016 at 07:04:22PM +0100, Christoph Hellwig wrote: > Looks fine, thanks! > > Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks, applying for 4.6.--b.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web