Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364638 > unrolled thread

[PATCH] drm/amd: Beef up ACP Kconfig menu text

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/amd: Beef up ACP Kconfig menu text Borislav Petkov <bp@alien8.de> - 2016-03-25 12:30 +0100
    Re: [PATCH] drm/amd: Beef up ACP Kconfig menu text Alex Deucher <alexdeucher@gmail.com> - 2016-03-25 15:30 +0100

#1364638 — [PATCH] drm/amd: Beef up ACP Kconfig menu text

From: Borislav Petkov <bp@suse.de>

The current "text" needs a user to use a crystal ball in order to find
out what this ACP thing is.

Use the text from

  a8fe58cec351 ("drm/amd: add ACP driver support")

to make it a bit more understandable to the rest of the world.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Chunming Zhou <david1.zhou@amd.com>
Cc: Jammy Zhou <Jammy.Zhou@amd.com>
Cc: Maruthi Bayyavarapu <maruthi.bayyavarapu@amd.com>
Cc: Murali Krishna Vemuri <murali-krishna.vemuri@amd.com>
---
 drivers/gpu/drm/amd/acp/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/acp/Kconfig b/drivers/gpu/drm/amd/acp/Kconfig
index 0f734ee05274..ca77ec10147c 100644
--- a/drivers/gpu/drm/amd/acp/Kconfig
+++ b/drivers/gpu/drm/amd/acp/Kconfig
@@ -1,10 +1,14 @@
-menu "ACP Configuration"
+menu "ACP (Audio CoProcessor) Configuration"
 
 config DRM_AMD_ACP
-       bool "Enable ACP IP support"
+       bool "Enable AMD Audio CoProcessor IP support"
        select MFD_CORE
        select PM_GENERIC_DOMAINS if PM
        help
 	Choose this option to enable ACP IP support for AMD SOCs.
+	This adds the ACP (Audio CoProcessor) IP driver and wires
+	it up into the amdgpu driver.  The ACP block provides the DMA
+	engine for the i2s-based ALSA driver. It is required for audio
+	on APUs which utilize an i2s codec.
 
 endmenu
-- 
2.7.3

[toc] | [next] | [standalone]

#1364685

On Fri, Mar 25, 2016 at 7:27 AM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> The current "text" needs a user to use a crystal ball in order to find
> out what this ACP thing is.
>
> Use the text from
>
>   a8fe58cec351 ("drm/amd: add ACP driver support")
>
> to make it a bit more understandable to the rest of the world.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Chunming Zhou <david1.zhou@amd.com>
> Cc: Jammy Zhou <Jammy.Zhou@amd.com>
> Cc: Maruthi Bayyavarapu <maruthi.bayyavarapu@amd.com>
> Cc: Murali Krishna Vemuri <murali-krishna.vemuri@amd.com>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/acp/Kconfig | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/Kconfig b/drivers/gpu/drm/amd/acp/Kconfig
> index 0f734ee05274..ca77ec10147c 100644
> --- a/drivers/gpu/drm/amd/acp/Kconfig
> +++ b/drivers/gpu/drm/amd/acp/Kconfig
> @@ -1,10 +1,14 @@
> -menu "ACP Configuration"
> +menu "ACP (Audio CoProcessor) Configuration"
>
>  config DRM_AMD_ACP
> -       bool "Enable ACP IP support"
> +       bool "Enable AMD Audio CoProcessor IP support"
>         select MFD_CORE
>         select PM_GENERIC_DOMAINS if PM
>         help
>         Choose this option to enable ACP IP support for AMD SOCs.
> +       This adds the ACP (Audio CoProcessor) IP driver and wires
> +       it up into the amdgpu driver.  The ACP block provides the DMA
> +       engine for the i2s-based ALSA driver. It is required for audio
> +       on APUs which utilize an i2s codec.
>
>  endmenu
> --
> 2.7.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web