Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363904 > unrolled thread
| Started by | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| First post | 2016-03-24 05:30 +0100 |
| Last post | 2016-03-25 00:40 +0100 |
| Articles | 20 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:30 +0100
[PATCH v5 15/21] ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12 Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:30 +0100
[PATCH v5 20/21] ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:30 +0100
[PATCH v5 16/21] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12 Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:30 +0100
[PATCH v5 02/21] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:30 +0100
[PATCH v5 07/21] PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
[PATCH v5 09/21] PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Markus Reichl <m.reichl@fivetechno.de> - 2016-03-24 14:50 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-03-24 15:00 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cwchoi00@gmail.com> - 2016-03-24 15:20 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cwchoi00@gmail.com> - 2016-03-24 15:30 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Anand Moon <linux.amoon@gmail.com> - 2016-03-27 14:30 +0200
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cwchoi00@gmail.com> - 2016-03-27 16:00 +0200
[PATCH v5 11/21] MAINTAINERS: Add samsung bus frequency driver entry Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
[PATCH v5 05/21] PM / devfreq: Add governer type with unique number Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
[PATCH v5 13/21] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
[PATCH v5 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-24 05:40 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Markus Reichl <m.reichl@fivetechno.de> - 2016-03-24 15:40 +0100
Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-25 00:40 +0100
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:30 +0100 |
| Subject | [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rg54e-5DB-3@gated-at.bofh.it> |
Dear all,
This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
devfreq device using ondemand governor and devfreq device using passive
governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
detailed issue information. But, this patchset don't modify the anything of
Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
from Exynos Soc Maintainer.
I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
[Description]
This patch-set includes the two features as following. The generic exynos bus
frequency driver is able to support almost Exynos SoCs for bus frequency
scaling. And the new passive governor is able to make the dependency on
between devices for frequency/voltage scaling. I had posted the patch-set[1]
with the similiar concept. This is is revised version for exynos bus frequency.
- Generic exynos bus frequency driver
- New passive governor of DEVFREQ framework
[1] https://lkml.org/lkml/2015/1/7/872
: [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
Changes from v4:
(https://lkml.org/lkml/2015/12/14/43)
- Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
devfreq device recevie the changed frequency of parent
devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
- Add governor type to identify thme using the defined constant
- Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
- Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
- Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
Changes from v3:
(https://lkml.org/lkml/2015/12/11/75)
- Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
- Fix typo of the description on patch14
- Modify the subject and description of patch17
- Reorder the 'bus_xxx' device tree node alphabetically in
both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
Changes from v2:
(https://lkml.org/lkml/2015/12/8/869)
- Fix typo on documentation
- Modify the more appropriate sentence on patch description
- Add the detailed description about both parent and passive bus device
- Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
- Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
- Rename OPP nodes as 'opp@<opp-hz>'
- Delete the duplicate 'opp-microvolt' property of passive devfreq device
- Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
- Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
- Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
on rinato/monk/trats2/odroid-u3 board
- Add the log message if bus device is registered to devfreq framework successfully
- Add the reviewed-by tag from Krzysztof Kozlowski
- Add the tested-by tag from Anand Moon on Odroid U3
- Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
Changes from v1:
(https://lkml.org/lkml/2015/11/26/260)
- Check whether the instance of regulator is NULL or not
when executing regulator_disable() because of only parent
devfreq device has the regulator instance. After fixing it,
the wake-up from suspend state is well working. (patch1)
- Fix bug which checks 'bus-clk' instead of 'bus->regulator'
after calling devm_clk_get() (on patch1)
- Update the documentation to remove the description about
DEVFREQ-EVENT subsystem (on patch2)
- Add the full name of DMC (Dynamic Memory Controller) (on patch2)
- Modify the detailed correlation of buses for Exynos3250
on documentation (patch2)
- Add the MFC bus node for Exynos3250 (on patch11, patch12)
- Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
- Add the PPMU node for exynos4412-odroidu3
- Add the support of bus frequency for exynos4412-odroidu3
Detailed descirption for patch-set:
1. Add generic exynos bus frequency driver
: This patch-set adds the generic exynos bus frequency driver for AXI bus
of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
architecture for bus between DRAM and sub-blocks in SoC.
There are the different buses according to Exynos SoC because Exynos SoC
has the differnt sub-blocks and bus speed. In spite of this difference
among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
unique data of each bus in the devicetree file.
In devicetree, each bus node has a bus clock, regulator, operation-point
and devfreq-event devices which measure the utilization of each bus block.
For example,
- The bus of DMC block in exynos3250.dtsi are listed below:
bus_dmc: bus_dmc {
compatible = "samsung,exynos-bus";
clocks = <&cmu_dmc CLK_DIV_DMC>;
clock-names = "bus";
operating-points-v2 = <&bus_dmc_opp_table>;
status = "disabled";
};
bus_dmc_opp_table: opp_table1 {
compatible = "operating-points-v2";
opp-shared;
opp@50000000 {
opp-hz = /bits/ 64 <50000000>;
opp-microvolt = <800000>;
};
opp@100000000 {
opp-hz = /bits/ 64 <100000000>;
opp-microvolt = <800000>;
};
opp@134000000 {
opp-hz = /bits/ 64 <134000000>;
opp-microvolt = <800000>;
};
opp@200000000 {
opp-hz = /bits/ 64 <200000000>;
opp-microvolt = <825000>;
};
opp@400000000 {
opp-hz = /bits/ 64 <400000000>;
opp-microvolt = <875000>;
};
};
- Usage case to handle the frequency and voltage of bus on runtime
in exynos3250-rinato.dts are listed below:
&bus_dmc {
devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
vdd-supply = <&buck1_reg>; /* VDD_MIF */
status = "okay";
};
2. Add new passive governor of DEVFREQ framework (patch5-patch7)
: This patch-set add the new passive governor for DEVFREQ framework.
The existing governors (ondemand, performance and so on) are used for DVFS
(Dynamic Voltage and Frequency Scaling) drivers. The existing governors
are independently used for specific device driver which don't give the
influence to other device drviers and also don't receive the effect from
other device drivers.
The passive governor depends on operation of parent driver with existing
governors(ondemand, performance and so on) extremely and is not able to
decide the new frequency by oneself. According to the decided new frequency
of parent driver with governor, the passive governor uses it to decide
the appropriate frequency for own device driver. The passive governor
must need the following information from device tree:
For exameple,
There are one more bus device drivers in Exynos3250 which need to
change their source clock according to their utilization on runtime.
But, they share the same power line (e.g., regulator). So, LEFTBUS bus
driver is operated as parent with ondemand governor and then the rest
device driver with passive governor.
The buses of Internal block in exynos3250.dtsi are listed below:
When LEFTBUS bus driver (parent) changes the bus frequency with
ondemand governor on runtime, the rest bus devices which sharing
the same power line (VDD_INT) will change the each bus frequency
according to the decision of LEFTBUS bus driver (parent).
- INT (Internal) block
: VDD_INT |--- LEFTBUS
|--- PERIL
|--- MFC
|--- G3D
|--- RIGHTBUS
|--- FSYS
|--- LCD0
|--- PERIR
|--- ISP
|--- CAM
- The buss of INT block in exynos3250.dtsi are listed below:
bus_leftbus: bus_leftbus {
compatible = "samsung,exynos-bus";
clocks = <&cmu CLK_DIV_GDL>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
status = "disabled";
};
bus_rightbus: bus_rightbus {
compatible = "samsung,exynos-bus";
clocks = <&cmu CLK_DIV_GDR>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
status = "disabled";
};
(Omit the rest bus dt node)
- Usage case to handle the frequency and voltage of bus on runtime
in exynos3250-rinato.dts are listed below:
/* Parent bus device of VDD_INT */
&bus_leftbus {
devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
vdd-supply = <&buck3_reg>;
status = "okay";
};
/* Passive bus device depend on LEFTBUS bus. */
&bus_rightbus {
devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
the phandle of parent device. */
status = "okay";
};
(Omit the rest bus dt node)
Chanwoo Choi (21):
PM / devfreq: exynos: Add generic exynos bus frequency driver
PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
PM / devfreq: Add devfreq_get_devfreq_by_phandle()
PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
PM / devfreq: Add governer type with unique number
PM / devfreq: Add new passive governor
PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
PM / devfreq: exynos: Update documentation for bus devices using passive governor
PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
MAINTAINERS: Add samsung bus frequency driver entry
ARM: dts: Add DMC bus node for Exynos3250
ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
ARM: dts: Add bus nodes using VDD_INT for Exynos3250
ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
.../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
MAINTAINERS | 9 +
arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
arch/arm/boot/dts/exynos4210.dtsi | 159 +++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
drivers/devfreq/Kconfig | 35 +-
drivers/devfreq/Makefile | 4 +-
drivers/devfreq/devfreq.c | 224 ++++-
drivers/devfreq/exynos-bus.c | 561 +++++++++++
drivers/devfreq/exynos/Makefile | 3 -
drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
drivers/devfreq/exynos/exynos4_bus.h | 110 --
drivers/devfreq/exynos/exynos5_bus.c | 431 --------
drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
drivers/devfreq/exynos/exynos_ppmu.h | 86 --
drivers/devfreq/governor.h | 21 +
drivers/devfreq/governor_passive.c | 192 ++++
drivers/devfreq/governor_performance.c | 1 +
drivers/devfreq/governor_powersave.c | 1 +
drivers/devfreq/governor_simpleondemand.c | 1 +
drivers/devfreq/governor_userspace.c | 1 +
include/linux/devfreq.h | 70 ++
27 files changed, 2209 insertions(+), 1948 deletions(-)
create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
create mode 100644 drivers/devfreq/exynos-bus.c
delete mode 100644 drivers/devfreq/exynos/Makefile
delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
create mode 100644 drivers/devfreq/governor_passive.c
--
1.9.1
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:30 +0100 |
| Subject | [PATCH v5 15/21] ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12 |
| Message-ID | <rg54f-5DB-33@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the bus nodes using VDD_MIF for Exynos4x12 SoC.
Exynos4x12 has the following AXI buses to translate data
between DRAM and DMC/ACP/C2C.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 68 +++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 84a23f962946..99a0f4ca3d47 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -281,6 +281,74 @@
clocks = <&clock CLK_SMMU_LITE1>, <&clock CLK_FIMC_LITE1>;
#iommu-cells = <0>;
};
+
+ bus_dmc: bus_dmc {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_DIV_DMC>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_dmc_opp_table>;
+ status = "disabled";
+ };
+
+ bus_acp: bus_acp {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_DIV_ACP>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_acp_opp_table>;
+ status = "disabled";
+ };
+
+ bus_c2c: bus_c2c {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_DIV_C2C>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_dmc_opp_table>;
+ status = "disabled";
+ };
+
+ bus_dmc_opp_table: opp_table1 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ opp-microvolt = <900000>;
+ };
+ opp@134000000 {
+ opp-hz = /bits/ 64 <134000000>;
+ opp-microvolt = <900000>;
+ };
+ opp@160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ opp-microvolt = <900000>;
+ };
+ opp@267000000 {
+ opp-hz = /bits/ 64 <267000000>;
+ opp-microvolt = <950000>;
+ };
+ opp@400000000 {
+ opp-hz = /bits/ 64 <400000000>;
+ opp-microvolt = <1050000>;
+ };
+ };
+
+ bus_acp_opp_table: opp_table2 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ };
+ opp@134000000 {
+ opp-hz = /bits/ 64 <134000000>;
+ };
+ opp@160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ };
+ opp@267000000 {
+ opp-hz = /bits/ 64 <267000000>;
+ };
+ };
};
&combiner {
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:30 +0100 |
| Subject | [PATCH v5 20/21] ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3 |
| Message-ID | <rg54f-5DB-23@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch expands the voltage range of buck1/3 regulator due to as following:
- MIF (Memory Interface) bus frequency needs the range of '900 - 1100 mV'.
- INT (Internal) bus frequency needs the range of '900 - 1050 mV'.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index cba37c974703..b4983cbc4f8c 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -356,8 +356,8 @@
buck1_reg: BUCK1 {
regulator-name = "vdd_mif";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1100000>;
regulator-always-on;
regulator-boot-on;
};
@@ -372,8 +372,8 @@
buck3_reg: BUCK3 {
regulator-name = "vdd_int";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1050000>;
regulator-always-on;
regulator-boot-on;
};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:30 +0100 |
| Subject | [PATCH v5 16/21] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12 |
| Message-ID | <rg54f-5DB-37@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the bus nodes using VDD_INT for Exynos4x12 SoC.
Exynos4x12 has the following AXI buses to translate data between
DRAM and sub-blocks.
Following list specifies the detailed relation between DRAM and sub-blocks:
- ACLK100 clock for PERIL/PERIR/MFC(PCLK)
- ACLK160 clock for CAM/TV/LCD
: The minimum clock of ACLK160 should be over 160MHz.
When drop the clock under 160MHz, show the broken image.
- ACLK133 clock for FSYS
- GDL clock for LEFTBUS
- GDR clock for RIGHTBUS
- SCLK_MFC clock for MFC
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 106 ++++++++++++++++++++++++++++++++++++++
1 file changed, 106 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 99a0f4ca3d47..e5173107ed44 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -349,6 +349,112 @@
opp-hz = /bits/ 64 <267000000>;
};
};
+
+ bus_leftbus: bus_leftbus {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_DIV_GDL>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_leftbus_opp_table>;
+ status = "disabled";
+ };
+
+ bus_rightbus: bus_rightbus {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_DIV_GDR>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_leftbus_opp_table>;
+ status = "disabled";
+ };
+
+ bus_display: bus_display {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_ACLK160>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_display_opp_table>;
+ status = "disabled";
+ };
+
+ bus_fsys: bus_fsys {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_ACLK133>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_fsys_opp_table>;
+ status = "disabled";
+ };
+
+ bus_peri: bus_peri {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_ACLK100>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_peri_opp_table>;
+ status = "disabled";
+ };
+
+ bus_mfc: bus_mfc {
+ compatible = "samsung,exynos-bus";
+ clocks = <&clock CLK_SCLK_MFC>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_leftbus_opp_table>;
+ status = "disabled";
+ };
+
+ bus_leftbus_opp_table: opp_table3 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ opp-microvolt = <900000>;
+ };
+ opp@134000000 {
+ opp-hz = /bits/ 64 <134000000>;
+ opp-microvolt = <925000>;
+ };
+ opp@160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ opp-microvolt = <950000>;
+ };
+ opp@200000000 {
+ opp-hz = /bits/ 64 <200000000>;
+ opp-microvolt = <1000000>;
+ };
+ };
+
+ bus_display_opp_table: opp_table4 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ };
+ opp@200000000 {
+ opp-hz = /bits/ 64 <200000000>;
+ };
+ };
+
+ bus_fsys_opp_table: opp_table5 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ };
+ opp@134000000 {
+ opp-hz = /bits/ 64 <134000000>;
+ };
+ };
+
+ bus_peri_opp_table: opp_table6 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@50000000 {
+ opp-hz = /bits/ 64 <50000000>;
+ };
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ };
+ };
};
&combiner {
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:30 +0100 |
| Subject | [PATCH v5 02/21] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver |
| Message-ID | <rg54f-5DB-27@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the documentation for generic exynos bus frequency
driver.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
.../devicetree/bindings/devfreq/exynos-bus.txt | 95 ++++++++++++++++++++++
1 file changed, 95 insertions(+)
create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
new file mode 100644
index 000000000000..78171b918e3f
--- /dev/null
+++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
@@ -0,0 +1,95 @@
+* Generic Exynos Bus frequency device
+
+The Samsung Exynos SoC has many buses for data transfer between DRAM
+and sub-blocks in SoC. Most Exynos SoCs share the common architecture
+for buses. Generally, each bus of Exynos SoC includes a source clock
+and a power line, which are able to change the clock frequency
+of the bus in runtime. To monitor the usage of each bus in runtime,
+the driver uses the PPMU (Platform Performance Monitoring Unit), which
+is able to measure the current load of sub-blocks.
+
+There are a little different composition among Exynos SoC because each Exynos
+SoC has different sub-blocks. Therefore, shch difference should be specified
+in devicetree file instead of each device driver. In result, this driver
+is able to support the bus frequency for all Exynos SoCs.
+
+Required properties for bus device:
+- compatible: Should be "samsung,exynos-bus".
+- clock-names : the name of clock used by the bus, "bus".
+- clocks : phandles for clock specified in "clock-names" property.
+- operating-points-v2: the OPP table including frequency/voltage information
+ to support DVFS (Dynamic Voltage/Frequency Scaling) feature.
+- vdd-supply: the regulator to provide the buses with the voltage.
+- devfreq-events: the devfreq-event device to monitor the current utilization
+ of buses.
+
+Optional properties for bus device:
+- exynos,saturation-ratio: the percentage value which is used to calibrate
+ the performance count against total cycle count.
+- exynos,voltage-tolerance: the percentage value for bus voltage tolerance
+ which is used to calculate the max voltage.
+
+Example1:
+ Show the AXI buses of Exynos3250 SoC. Exynos3250 divides the buses to
+ power line (regulator). The MIF (Memory Interface) AXI bus is used to
+ transfer data between DRAM and CPU and uses the VDD_MIF regualtor.
+
+ - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block
+
+ - MIF bus's frequency/voltage table
+ -----------------------
+ |Lv| Freq | Voltage |
+ -----------------------
+ |L1| 50000 |800000 |
+ |L2| 100000 |800000 |
+ |L3| 134000 |800000 |
+ |L4| 200000 |825000 |
+ |L5| 400000 |875000 |
+ -----------------------
+
+Example2 :
+ The bus of DMC (Dynamic Memory Controller) block in exynos3250.dtsi
+ is listed below:
+
+ bus_dmc: bus_dmc {
+ compatible = "samsung,exynos-bus";
+ clocks = <&cmu_dmc CLK_DIV_DMC>;
+ clock-names = "bus";
+ operating-points-v2 = <&bus_dmc_opp_table>;
+ status = "disabled";
+ };
+
+ bus_dmc_opp_table: opp_table1 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp@50000000 {
+ opp-hz = /bits/ 64 <50000000>;
+ opp-microvolt = <800000>;
+ };
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ opp-microvolt = <800000>;
+ };
+ opp@134000000 {
+ opp-hz = /bits/ 64 <134000000>;
+ opp-microvolt = <800000>;
+ };
+ opp@200000000 {
+ opp-hz = /bits/ 64 <200000000>;
+ opp-microvolt = <825000>;
+ };
+ opp@400000000 {
+ opp-hz = /bits/ 64 <400000000>;
+ opp-microvolt = <875000>;
+ };
+ };
+
+ Usage case to handle the frequency and voltage of bus on runtime
+ in exynos3250-rinato.dts is listed below:
+
+ &bus_dmc {
+ devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
+ vdd-supply = <&buck1_reg>; /* VDD_MIF */
+ status = "okay";
+ };
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 07/21] PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor |
| Message-ID | <rg5dU-5HE-5@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the support of bus frequency feature for sub-blocks which share
the one power line. If each bus depends on the power line, each bus is not able
to change the voltage by oneself. To optimize the power-consumption on runtime,
some buses using the same power line should change the source clock and
regulator at the same time. So, this patch uses the passive governor to support
the bus frequency for all buses which sharing the one power line.
For example,
Exynos3250 include the two power line for AXI buses as following:
: VDD_MIF : MIF (Memory Interface) provide the DMC (Dynamic Memory Controller)
with the power (regulator).
: VDD_INT : INT (Internal) provide the various sub-blocks with the power
(regulator).
Each bus is included in as follwoing block. In the case of VDD_MIF, only DMC bus
use the power line. So, there is no any depencency between buese. But, in the
case of VDD_INT, various buses share the one power line of VDD_INT. We need to
make the depenency between buses. When using passive governor, there is no
problem to support the bus frequency as DVFS for all buses. One bus should be
operated as the parent bus device which gathering the current load of INT block
and then decides the new frequency with some governors except of passive
governor. After deciding the new frequency by the parent bus device, the rest
bus devices will change the each source clock according to new frequency of the
parent bus device.
- MIF (Memory Interface) block
: VDD_MIF |--- DMC
- INT (Internal) block
: VDD_INT |--- LEFTBUS (parent)
|--- PERIL
|--- MFC
|--- G3D
|--- RIGHTBUS
|--- FSYS
|--- LCD0
|--- PERIR
|--- ISP
|--- CAM
[tjakobi: Reported debugfs error during booting and cw00.choi fix it.]
Reported-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/Kconfig | 1 +
drivers/devfreq/exynos-bus.c | 210 +++++++++++++++++++++++++++++++++----------
2 files changed, 165 insertions(+), 46 deletions(-)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index ae689ad375fa..357b548851a3 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -77,6 +77,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver"
depends on ARCH_EXYNOS
select DEVFREQ_GOV_SIMPLE_ONDEMAND
+ select DEVFREQ_GOV_PASSIVE
select DEVFREQ_EVENT_EXYNOS_PPMU
select PM_DEVFREQ_EVENT
select PM_OPP
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index f79963187fa1..c4249efaf0e1 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -1,7 +1,7 @@
/*
* Generic Exynos Bus frequency driver with DEVFREQ Framework
*
- * Copyright (c) 2015 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2016 Samsung Electronics Co., Ltd.
* Author : Chanwoo Choi <cw00.choi@samsung.com>
*
* This driver support Exynos Bus frequency feature by using
@@ -93,7 +93,7 @@ static int exynos_bus_get_event(struct exynos_bus *bus,
}
/*
- * Must necessary function for devfreq governor
+ * Must necessary function for devfreq simple-ondemand governor
*/
static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags)
{
@@ -202,59 +202,80 @@ static void exynos_bus_exit(struct device *dev)
regulator_disable(bus->regulator);
dev_pm_opp_of_remove_table(dev);
+ clk_disable_unprepare(bus->clk);
}
-static int exynos_bus_parse_of(struct device_node *np,
- struct exynos_bus *bus)
+/*
+ * Must necessary function for devfreq passive governor
+ */
+static int exynos_bus_passive_target(struct device *dev, unsigned long *freq,
+ u32 flags)
{
- struct device *dev = bus->dev;
- unsigned long rate;
- int i, ret, count, size;
+ struct exynos_bus *bus = dev_get_drvdata(dev);
+ struct dev_pm_opp *new_opp;
+ unsigned long old_freq, new_freq;
+ int ret = 0;
- /* Get the clock to provide each bus with source clock */
- bus->clk = devm_clk_get(dev, "bus");
- if (IS_ERR(bus->clk)) {
- dev_err(dev, "failed to get bus clock\n");
- return PTR_ERR(bus->clk);
+ /* Get new opp-bus instance according to new bus clock */
+ rcu_read_lock();
+ new_opp = devfreq_recommended_opp(dev, freq, flags);
+ if (IS_ERR_OR_NULL(new_opp)) {
+ dev_err(dev, "failed to get recommed opp instance\n");
+ rcu_read_unlock();
+ return PTR_ERR(new_opp);
}
- ret = clk_prepare_enable(bus->clk);
- if (ret < 0) {
- dev_err(dev, "failed to get enable clock\n");
- return ret;
- }
+ new_freq = dev_pm_opp_get_freq(new_opp);
+ old_freq = dev_pm_opp_get_freq(bus->curr_opp);
+ rcu_read_unlock();
- /* Get the freq/voltage OPP table to scale the bus frequency */
- rcu_read_lock();
- ret = dev_pm_opp_of_add_table(dev);
+ if (old_freq == new_freq)
+ return 0;
+
+ /* Change the frequency according to new OPP level */
+ mutex_lock(&bus->lock);
+
+ ret = clk_set_rate(bus->clk, new_freq);
if (ret < 0) {
- dev_err(dev, "failed to get OPP table\n");
- rcu_read_unlock();
- goto err_clk;
+ dev_err(dev, "failed to set the clock of bus\n");
+ goto out;
}
- rate = clk_get_rate(bus->clk);
- bus->curr_opp = dev_pm_opp_find_freq_ceil(dev, &rate);
- if (IS_ERR(bus->curr_opp)) {
- dev_err(dev, "failed to find dev_pm_opp\n");
- rcu_read_unlock();
- ret = PTR_ERR(bus->curr_opp);
- goto err_opp;
- }
- rcu_read_unlock();
+ bus->curr_opp = new_opp;
+
+ dev_dbg(dev, "Set the frequency of bus (%lukHz -> %lukHz)\n",
+ old_freq/1000, new_freq/1000);
+out:
+ mutex_unlock(&bus->lock);
+
+ return ret;
+}
+
+static void exynos_bus_passive_exit(struct device *dev)
+{
+ struct exynos_bus *bus = dev_get_drvdata(dev);
+
+ dev_pm_opp_of_remove_table(dev);
+ clk_disable_unprepare(bus->clk);
+}
+
+static int exynos_bus_parent_parse_of(struct device_node *np,
+ struct exynos_bus *bus)
+{
+ struct device *dev = bus->dev;
+ int i, ret, count, size;
/* Get the regulator to provide each bus with the power */
bus->regulator = devm_regulator_get(dev, "vdd");
if (IS_ERR(bus->regulator)) {
dev_err(dev, "failed to get VDD regulator\n");
- ret = PTR_ERR(bus->regulator);
- goto err_opp;
+ return PTR_ERR(bus->regulator);
}
ret = regulator_enable(bus->regulator);
if (ret < 0) {
dev_err(dev, "failed to enable VDD regulator\n");
- goto err_opp;
+ return ret;
}
/*
@@ -305,6 +326,51 @@ static int exynos_bus_parse_of(struct device_node *np,
err_regulator:
regulator_disable(bus->regulator);
+
+ return ret;
+}
+
+static int exynos_bus_parse_of(struct device_node *np,
+ struct exynos_bus *bus)
+{
+ struct device *dev = bus->dev;
+ unsigned long rate;
+ int ret;
+
+ /* Get the clock to provide each bus with source clock */
+ bus->clk = devm_clk_get(dev, "bus");
+ if (IS_ERR(bus->clk)) {
+ dev_err(dev, "failed to get bus clock\n");
+ return PTR_ERR(bus->clk);
+ }
+
+ ret = clk_prepare_enable(bus->clk);
+ if (ret < 0) {
+ dev_err(dev, "failed to get enable clock\n");
+ return ret;
+ }
+
+ /* Get the freq and voltage from OPP table to scale the bus freq */
+ rcu_read_lock();
+ ret = dev_pm_opp_of_add_table(dev);
+ if (ret < 0) {
+ dev_err(dev, "failed to get OPP table\n");
+ rcu_read_unlock();
+ goto err_clk;
+ }
+
+ rate = clk_get_rate(bus->clk);
+ bus->curr_opp = dev_pm_opp_find_freq_ceil(dev, &rate);
+ if (IS_ERR(bus->curr_opp)) {
+ dev_err(dev, "failed to find dev_pm_opp\n");
+ rcu_read_unlock();
+ ret = PTR_ERR(bus->curr_opp);
+ goto err_opp;
+ }
+ rcu_read_unlock();
+
+ return 0;
+
err_opp:
dev_pm_opp_of_remove_table(dev);
err_clk:
@@ -319,8 +385,10 @@ static int exynos_bus_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
struct devfreq_dev_profile *profile;
struct devfreq_simple_ondemand_data *ondemand_data;
+ struct devfreq *parent_devfreq;
struct exynos_bus *bus;
- int ret;
+ int ret, max_state;
+ unsigned long min_freq, max_freq;
if (!np) {
dev_err(dev, "failed to find devicetree node\n");
@@ -337,20 +405,33 @@ static int exynos_bus_probe(struct platform_device *pdev)
/* Parse the device-tree to get the resource information */
ret = exynos_bus_parse_of(np, bus);
if (ret < 0)
- return ret;
+ goto err;
- /* Initalize the struct profile and governor data */
profile = devm_kzalloc(dev, sizeof(*profile), GFP_KERNEL);
- if (!profile)
- return -ENOMEM;
+ if (!profile) {
+ ret = -ENOMEM;
+ goto err;
+ }
+
+ if (of_parse_phandle(dev->of_node, "devfreq", 0))
+ goto passive;
+ else
+ ret = exynos_bus_parent_parse_of(np, bus);
+
+ if (ret < 0)
+ goto err;
+
+ /* Initalize the struct profile and governor data for parent device */
profile->polling_ms = 50;
profile->target = exynos_bus_target;
profile->get_dev_status = exynos_bus_get_dev_status;
profile->exit = exynos_bus_exit;
ondemand_data = devm_kzalloc(dev, sizeof(*ondemand_data), GFP_KERNEL);
- if (!ondemand_data)
- return -ENOMEM;
+ if (!ondemand_data) {
+ ret = -ENOMEM;
+ goto err;
+ }
ondemand_data->upthreshold = 40;
ondemand_data->downdifferential = 5;
@@ -359,14 +440,15 @@ static int exynos_bus_probe(struct platform_device *pdev)
ondemand_data);
if (IS_ERR_OR_NULL(bus->devfreq)) {
dev_err(dev, "failed to add devfreq device\n");
- return PTR_ERR(bus->devfreq);
+ ret = PTR_ERR(bus->devfreq);
+ goto err;
}
/* Register opp_notifier to catch the change of OPP */
ret = devm_devfreq_register_opp_notifier(dev, bus->devfreq);
if (ret < 0) {
dev_err(dev, "failed to register opp notifier\n");
- return ret;
+ goto err;
}
/*
@@ -376,16 +458,52 @@ static int exynos_bus_probe(struct platform_device *pdev)
ret = exynos_bus_enable_edev(bus);
if (ret < 0) {
dev_err(dev, "failed to enable devfreq-event devices\n");
- return ret;
+ goto err;
}
ret = exynos_bus_set_event(bus);
if (ret < 0) {
dev_err(dev, "failed to set event to devfreq-event devices\n");
- return ret;
+ goto err;
+ }
+
+ goto out;
+passive:
+ /* Initalize the struct profile and governor data for passive device */
+ profile->target = exynos_bus_passive_target;
+ profile->exit = exynos_bus_passive_exit;
+
+ /* Get the instance of parent devfreq device */
+ parent_devfreq = devfreq_get_devfreq_by_phandle(dev, 0);
+ if (IS_ERR(parent_devfreq)) {
+ ret = -EPROBE_DEFER;
+ goto err;
}
+ /* Add devfreq device for exynos bus with passive governor */
+ bus->devfreq = devm_devfreq_add_device(dev, profile, "passive",
+ parent_devfreq);
+ if (IS_ERR_OR_NULL(bus->devfreq)) {
+ dev_err(dev,
+ "failed to add devfreq dev with passive governor\n");
+ ret = -EPROBE_DEFER;
+ goto err;
+ }
+
+out:
+ max_state = bus->devfreq->profile->max_state;
+ min_freq = (bus->devfreq->profile->freq_table[0] / 1000);
+ max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000);
+ pr_info("exynos-bus: new bus device registered: %s (%6ld KHz ~ %6ld KHz)\n",
+ dev_name(dev), min_freq, max_freq);
+
return 0;
+
+err:
+ dev_pm_opp_of_remove_table(dev);
+ clk_disable_unprepare(bus->clk);
+
+ return ret;
}
#ifdef CONFIG_PM_SLEEP
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 09/21] PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line |
| Message-ID | <rg5dU-5HE-7@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the detailed corrleation between sub-blocks and power line for Exynos3250, Exynos4210 and Exynos4x12. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- .../devicetree/bindings/devfreq/exynos-bus.txt | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt index 03f13d38f1a1..b098fa2ba5d4 100644 --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt @@ -53,6 +53,57 @@ Optional properties only for parent bus device: - exynos,voltage-tolerance: the percentage value for bus voltage tolerance which is used to calculate the max voltage. +Detailed correlation between sub-blocks and power line according to Exynos SoC: +- In case of Exynos3250, there are two power line as following: + VDD_MIF |--- DMC + + VDD_INT |--- LEFTBUS (parent device) + |--- PERIL + |--- MFC + |--- G3D + |--- RIGHTBUS + |--- PERIR + |--- FSYS + |--- LCD0 + |--- PERIR + |--- ISP + |--- CAM + +- In case of Exynos4210, there is one power line as following: + VDD_INT |--- DMC (parent device) + |--- LEFTBUS + |--- PERIL + |--- MFC(L) + |--- G3D + |--- TV + |--- LCD0 + |--- RIGHTBUS + |--- PERIR + |--- MFC(R) + |--- CAM + |--- FSYS + |--- GPS + |--- LCD0 + |--- LCD1 + +- In case of Exynos4x12, there are two power line as following: + VDD_MIF |--- DMC + + VDD_INT |--- LEFTBUS (parent device) + |--- PERIL + |--- MFC(L) + |--- G3D + |--- TV + |--- IMAGE + |--- RIGHTBUS + |--- PERIR + |--- MFC(R) + |--- CAM + |--- FSYS + |--- GPS + |--- LCD0 + |--- ISP + Example1: Show the AXI buses of Exynos3250 SoC. Exynos3250 divides the buses to power line (regulator). The MIF (Memory Interface) AXI bus is used to -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rg5dU-5HE-11@gated-at.bofh.it> |
| In reply to | #1363904 |
Dear Anand and Tobias,
To Anand,
First of all, thanks to your test on previous patchset.
I removed the your tested-by tag from this version
because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier.
I think that this patch-set need to test with this patchset.
If you possible, could you please test this patch-set? Thanks in advance.
To Tobias,
I fixed the following issues reported by you. Thanks your test and report.
- RCU locking issue
- debugfs error during kernel booting
Best Regards,
Chanwoo Choi
On 2016년 03월 24일 13:25, Chanwoo Choi wrote:
> Dear all,
>
> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
> devfreq device using ondemand governor and devfreq device using passive
> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
> detailed issue information. But, this patchset don't modify the anything of
> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
> from Exynos Soc Maintainer.
>
> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
>
> [Description]
> This patch-set includes the two features as following. The generic exynos bus
> frequency driver is able to support almost Exynos SoCs for bus frequency
> scaling. And the new passive governor is able to make the dependency on
> between devices for frequency/voltage scaling. I had posted the patch-set[1]
> with the similiar concept. This is is revised version for exynos bus frequency.
> - Generic exynos bus frequency driver
> - New passive governor of DEVFREQ framework
> [1] https://lkml.org/lkml/2015/1/7/872
> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>
> Changes from v4:
> (https://lkml.org/lkml/2015/12/14/43)
> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
> devfreq device recevie the changed frequency of parent
> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
> - Add governor type to identify thme using the defined constant
> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>
> Changes from v3:
> (https://lkml.org/lkml/2015/12/11/75)
> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
> - Fix typo of the description on patch14
> - Modify the subject and description of patch17
> - Reorder the 'bus_xxx' device tree node alphabetically in
> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>
> Changes from v2:
> (https://lkml.org/lkml/2015/12/8/869)
> - Fix typo on documentation
> - Modify the more appropriate sentence on patch description
> - Add the detailed description about both parent and passive bus device
> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
> - Rename OPP nodes as 'opp@<opp-hz>'
> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
> on rinato/monk/trats2/odroid-u3 board
> - Add the log message if bus device is registered to devfreq framework successfully
> - Add the reviewed-by tag from Krzysztof Kozlowski
> - Add the tested-by tag from Anand Moon on Odroid U3
> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>
> Changes from v1:
> (https://lkml.org/lkml/2015/11/26/260)
> - Check whether the instance of regulator is NULL or not
> when executing regulator_disable() because of only parent
> devfreq device has the regulator instance. After fixing it,
> the wake-up from suspend state is well working. (patch1)
> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
> after calling devm_clk_get() (on patch1)
> - Update the documentation to remove the description about
> DEVFREQ-EVENT subsystem (on patch2)
> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
> - Modify the detailed correlation of buses for Exynos3250
> on documentation (patch2)
> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
> - Add the PPMU node for exynos4412-odroidu3
> - Add the support of bus frequency for exynos4412-odroidu3
>
> Detailed descirption for patch-set:
> 1. Add generic exynos bus frequency driver
> : This patch-set adds the generic exynos bus frequency driver for AXI bus
> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
> architecture for bus between DRAM and sub-blocks in SoC.
>
> There are the different buses according to Exynos SoC because Exynos SoC
> has the differnt sub-blocks and bus speed. In spite of this difference
> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
> unique data of each bus in the devicetree file.
>
> In devicetree, each bus node has a bus clock, regulator, operation-point
> and devfreq-event devices which measure the utilization of each bus block.
>
> For example,
> - The bus of DMC block in exynos3250.dtsi are listed below:
>
> bus_dmc: bus_dmc {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu_dmc CLK_DIV_DMC>;
> clock-names = "bus";
> operating-points-v2 = <&bus_dmc_opp_table>;
> status = "disabled";
> };
>
> bus_dmc_opp_table: opp_table1 {
> compatible = "operating-points-v2";
> opp-shared;
>
> opp@50000000 {
> opp-hz = /bits/ 64 <50000000>;
> opp-microvolt = <800000>;
> };
> opp@100000000 {
> opp-hz = /bits/ 64 <100000000>;
> opp-microvolt = <800000>;
> };
> opp@134000000 {
> opp-hz = /bits/ 64 <134000000>;
> opp-microvolt = <800000>;
> };
> opp@200000000 {
> opp-hz = /bits/ 64 <200000000>;
> opp-microvolt = <825000>;
> };
> opp@400000000 {
> opp-hz = /bits/ 64 <400000000>;
> opp-microvolt = <875000>;
> };
> };
>
> - Usage case to handle the frequency and voltage of bus on runtime
> in exynos3250-rinato.dts are listed below:
>
> &bus_dmc {
> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> vdd-supply = <&buck1_reg>; /* VDD_MIF */
> status = "okay";
> };
>
> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
> : This patch-set add the new passive governor for DEVFREQ framework.
> The existing governors (ondemand, performance and so on) are used for DVFS
> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
> are independently used for specific device driver which don't give the
> influence to other device drviers and also don't receive the effect from
> other device drivers.
>
> The passive governor depends on operation of parent driver with existing
> governors(ondemand, performance and so on) extremely and is not able to
> decide the new frequency by oneself. According to the decided new frequency
> of parent driver with governor, the passive governor uses it to decide
> the appropriate frequency for own device driver. The passive governor
> must need the following information from device tree:
>
> For exameple,
> There are one more bus device drivers in Exynos3250 which need to
> change their source clock according to their utilization on runtime.
> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
> driver is operated as parent with ondemand governor and then the rest
> device driver with passive governor.
>
> The buses of Internal block in exynos3250.dtsi are listed below:
> When LEFTBUS bus driver (parent) changes the bus frequency with
> ondemand governor on runtime, the rest bus devices which sharing
> the same power line (VDD_INT) will change the each bus frequency
> according to the decision of LEFTBUS bus driver (parent).
>
> - INT (Internal) block
> : VDD_INT |--- LEFTBUS
> |--- PERIL
> |--- MFC
> |--- G3D
> |--- RIGHTBUS
> |--- FSYS
> |--- LCD0
> |--- PERIR
> |--- ISP
> |--- CAM
>
> - The buss of INT block in exynos3250.dtsi are listed below:
> bus_leftbus: bus_leftbus {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu CLK_DIV_GDL>;
> clock-names = "bus";
> operating-points-v2 = <&bus_leftbus_opp_table>;
> status = "disabled";
> };
>
> bus_rightbus: bus_rightbus {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu CLK_DIV_GDR>;
> clock-names = "bus";
> operating-points-v2 = <&bus_leftbus_opp_table>;
> status = "disabled";
> };
>
> (Omit the rest bus dt node)
>
> - Usage case to handle the frequency and voltage of bus on runtime
> in exynos3250-rinato.dts are listed below:
> /* Parent bus device of VDD_INT */
> &bus_leftbus {
> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> vdd-supply = <&buck3_reg>;
> status = "okay";
> };
>
> /* Passive bus device depend on LEFTBUS bus. */
> &bus_rightbus {
> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
> the phandle of parent device. */
> status = "okay";
> };
>
> (Omit the rest bus dt node)
>
> Chanwoo Choi (21):
> PM / devfreq: exynos: Add generic exynos bus frequency driver
> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
> PM / devfreq: Add governer type with unique number
> PM / devfreq: Add new passive governor
> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
> PM / devfreq: exynos: Update documentation for bus devices using passive governor
> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
> MAINTAINERS: Add samsung bus frequency driver entry
> ARM: dts: Add DMC bus node for Exynos3250
> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>
> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
> MAINTAINERS | 9 +
> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
> drivers/devfreq/Kconfig | 35 +-
> drivers/devfreq/Makefile | 4 +-
> drivers/devfreq/devfreq.c | 224 ++++-
> drivers/devfreq/exynos-bus.c | 561 +++++++++++
> drivers/devfreq/exynos/Makefile | 3 -
> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
> drivers/devfreq/exynos/exynos4_bus.h | 110 --
> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
> drivers/devfreq/governor.h | 21 +
> drivers/devfreq/governor_passive.c | 192 ++++
> drivers/devfreq/governor_performance.c | 1 +
> drivers/devfreq/governor_powersave.c | 1 +
> drivers/devfreq/governor_simpleondemand.c | 1 +
> drivers/devfreq/governor_userspace.c | 1 +
> include/linux/devfreq.h | 70 ++
> 27 files changed, 2209 insertions(+), 1948 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
> create mode 100644 drivers/devfreq/exynos-bus.c
> delete mode 100644 drivers/devfreq/exynos/Makefile
> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
> create mode 100644 drivers/devfreq/governor_passive.c
>
[toc] | [prev] | [next] | [standalone]
| From | Markus Reichl <m.reichl@fivetechno.de> |
|---|---|
| Date | 2016-03-24 14:50 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgdOa-3jF-1@gated-at.bofh.it> |
| In reply to | #1363911 |
Hi Chanwoo,
Am 24.03.2016 um 05:30 schrieb Chanwoo Choi:
> Dear Anand and Tobias,
>
> To Anand,
> First of all, thanks to your test on previous patchset.
> I removed the your tested-by tag from this version
> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier.
> I think that this patch-set need to test with this patchset.
> If you possible, could you please test this patch-set? Thanks in advance.
>
> To Tobias,
> I fixed the following issues reported by you. Thanks your test and report.
> - RCU locking issue
> - debugfs error during kernel booting
>
> Best Regards,
> Chanwoo Choi
This set works fine on odroid U3 but gives the following with dmesg |grep devfreq:
[ 2.066890] devfreq bus_dmc: Couldn't update frequency transition information.
[ 2.190238] devfreq bus_leftbus: Couldn't update frequency transition information.
Thanks,
--
Markus Reichl
>
> On 2016년 03월 24일 13:25, Chanwoo Choi wrote:
>> Dear all,
>>
>> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
>> devfreq device using ondemand governor and devfreq device using passive
>> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
>> detailed issue information. But, this patchset don't modify the anything of
>> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
>> from Exynos Soc Maintainer.
>>
>> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
>>
>> [Description]
>> This patch-set includes the two features as following. The generic exynos bus
>> frequency driver is able to support almost Exynos SoCs for bus frequency
>> scaling. And the new passive governor is able to make the dependency on
>> between devices for frequency/voltage scaling. I had posted the patch-set[1]
>> with the similiar concept. This is is revised version for exynos bus frequency.
>> - Generic exynos bus frequency driver
>> - New passive governor of DEVFREQ framework
>> [1] https://lkml.org/lkml/2015/1/7/872
>> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>>
>> Changes from v4:
>> (https://lkml.org/lkml/2015/12/14/43)
>> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
>> devfreq device recevie the changed frequency of parent
>> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
>> - Add governor type to identify thme using the defined constant
>> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
>> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
>> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>>
>> Changes from v3:
>> (https://lkml.org/lkml/2015/12/11/75)
>> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
>> - Fix typo of the description on patch14
>> - Modify the subject and description of patch17
>> - Reorder the 'bus_xxx' device tree node alphabetically in
>> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>>
>> Changes from v2:
>> (https://lkml.org/lkml/2015/12/8/869)
>> - Fix typo on documentation
>> - Modify the more appropriate sentence on patch description
>> - Add the detailed description about both parent and passive bus device
>> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
>> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
>> - Rename OPP nodes as 'opp@<opp-hz>'
>> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
>> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
>> on rinato/monk/trats2/odroid-u3 board
>> - Add the log message if bus device is registered to devfreq framework successfully
>> - Add the reviewed-by tag from Krzysztof Kozlowski
>> - Add the tested-by tag from Anand Moon on Odroid U3
>> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>>
>> Changes from v1:
>> (https://lkml.org/lkml/2015/11/26/260)
>> - Check whether the instance of regulator is NULL or not
>> when executing regulator_disable() because of only parent
>> devfreq device has the regulator instance. After fixing it,
>> the wake-up from suspend state is well working. (patch1)
>> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
>> after calling devm_clk_get() (on patch1)
>> - Update the documentation to remove the description about
>> DEVFREQ-EVENT subsystem (on patch2)
>> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
>> - Modify the detailed correlation of buses for Exynos3250
>> on documentation (patch2)
>> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
>> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
>> - Add the PPMU node for exynos4412-odroidu3
>> - Add the support of bus frequency for exynos4412-odroidu3
>>
>> Detailed descirption for patch-set:
>> 1. Add generic exynos bus frequency driver
>> : This patch-set adds the generic exynos bus frequency driver for AXI bus
>> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
>> architecture for bus between DRAM and sub-blocks in SoC.
>>
>> There are the different buses according to Exynos SoC because Exynos SoC
>> has the differnt sub-blocks and bus speed. In spite of this difference
>> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
>> unique data of each bus in the devicetree file.
>>
>> In devicetree, each bus node has a bus clock, regulator, operation-point
>> and devfreq-event devices which measure the utilization of each bus block.
>>
>> For example,
>> - The bus of DMC block in exynos3250.dtsi are listed below:
>>
>> bus_dmc: bus_dmc {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu_dmc CLK_DIV_DMC>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_dmc_opp_table>;
>> status = "disabled";
>> };
>>
>> bus_dmc_opp_table: opp_table1 {
>> compatible = "operating-points-v2";
>> opp-shared;
>>
>> opp@50000000 {
>> opp-hz = /bits/ 64 <50000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@100000000 {
>> opp-hz = /bits/ 64 <100000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@134000000 {
>> opp-hz = /bits/ 64 <134000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@200000000 {
>> opp-hz = /bits/ 64 <200000000>;
>> opp-microvolt = <825000>;
>> };
>> opp@400000000 {
>> opp-hz = /bits/ 64 <400000000>;
>> opp-microvolt = <875000>;
>> };
>> };
>>
>> - Usage case to handle the frequency and voltage of bus on runtime
>> in exynos3250-rinato.dts are listed below:
>>
>> &bus_dmc {
>> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>> vdd-supply = <&buck1_reg>; /* VDD_MIF */
>> status = "okay";
>> };
>>
>> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
>> : This patch-set add the new passive governor for DEVFREQ framework.
>> The existing governors (ondemand, performance and so on) are used for DVFS
>> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
>> are independently used for specific device driver which don't give the
>> influence to other device drviers and also don't receive the effect from
>> other device drivers.
>>
>> The passive governor depends on operation of parent driver with existing
>> governors(ondemand, performance and so on) extremely and is not able to
>> decide the new frequency by oneself. According to the decided new frequency
>> of parent driver with governor, the passive governor uses it to decide
>> the appropriate frequency for own device driver. The passive governor
>> must need the following information from device tree:
>>
>> For exameple,
>> There are one more bus device drivers in Exynos3250 which need to
>> change their source clock according to their utilization on runtime.
>> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
>> driver is operated as parent with ondemand governor and then the rest
>> device driver with passive governor.
>>
>> The buses of Internal block in exynos3250.dtsi are listed below:
>> When LEFTBUS bus driver (parent) changes the bus frequency with
>> ondemand governor on runtime, the rest bus devices which sharing
>> the same power line (VDD_INT) will change the each bus frequency
>> according to the decision of LEFTBUS bus driver (parent).
>>
>> - INT (Internal) block
>> : VDD_INT |--- LEFTBUS
>> |--- PERIL
>> |--- MFC
>> |--- G3D
>> |--- RIGHTBUS
>> |--- FSYS
>> |--- LCD0
>> |--- PERIR
>> |--- ISP
>> |--- CAM
>>
>> - The buss of INT block in exynos3250.dtsi are listed below:
>> bus_leftbus: bus_leftbus {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu CLK_DIV_GDL>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_leftbus_opp_table>;
>> status = "disabled";
>> };
>>
>> bus_rightbus: bus_rightbus {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu CLK_DIV_GDR>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_leftbus_opp_table>;
>> status = "disabled";
>> };
>>
>> (Omit the rest bus dt node)
>>
>> - Usage case to handle the frequency and voltage of bus on runtime
>> in exynos3250-rinato.dts are listed below:
>> /* Parent bus device of VDD_INT */
>> &bus_leftbus {
>> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
>> vdd-supply = <&buck3_reg>;
>> status = "okay";
>> };
>>
>> /* Passive bus device depend on LEFTBUS bus. */
>> &bus_rightbus {
>> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
>> the phandle of parent device. */
>> status = "okay";
>> };
>>
>> (Omit the rest bus dt node)
>>
>> Chanwoo Choi (21):
>> PM / devfreq: exynos: Add generic exynos bus frequency driver
>> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
>> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
>> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
>> PM / devfreq: Add governer type with unique number
>> PM / devfreq: Add new passive governor
>> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
>> PM / devfreq: exynos: Update documentation for bus devices using passive governor
>> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
>> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
>> MAINTAINERS: Add samsung bus frequency driver entry
>> ARM: dts: Add DMC bus node for Exynos3250
>> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
>> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
>> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
>> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
>> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
>> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
>> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>>
>> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
>> MAINTAINERS | 9 +
>> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
>> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
>> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
>> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
>> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
>> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
>> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
>> drivers/devfreq/Kconfig | 35 +-
>> drivers/devfreq/Makefile | 4 +-
>> drivers/devfreq/devfreq.c | 224 ++++-
>> drivers/devfreq/exynos-bus.c | 561 +++++++++++
>> drivers/devfreq/exynos/Makefile | 3 -
>> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
>> drivers/devfreq/exynos/exynos4_bus.h | 110 --
>> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
>> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
>> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
>> drivers/devfreq/governor.h | 21 +
>> drivers/devfreq/governor_passive.c | 192 ++++
>> drivers/devfreq/governor_performance.c | 1 +
>> drivers/devfreq/governor_powersave.c | 1 +
>> drivers/devfreq/governor_simpleondemand.c | 1 +
>> drivers/devfreq/governor_userspace.c | 1 +
>> include/linux/devfreq.h | 70 ++
>> 27 files changed, 2209 insertions(+), 1948 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> create mode 100644 drivers/devfreq/exynos-bus.c
>> delete mode 100644 drivers/devfreq/exynos/Makefile
>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
>> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
>> create mode 100644 drivers/devfreq/governor_passive.c
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[toc] | [prev] | [next] | [standalone]
| From | Tobias Jakobi <tjakobi@math.uni-bielefeld.de> |
|---|---|
| Date | 2016-03-24 15:00 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgdXR-3nm-27@gated-at.bofh.it> |
| In reply to | #1364170 |
Hello everybody,
Markus Reichl wrote:
> Hi Chanwoo,
>
> Am 24.03.2016 um 05:30 schrieb Chanwoo Choi:
>> Dear Anand and Tobias,
>>
>> To Anand,
>> First of all, thanks to your test on previous patchset.
>> I removed the your tested-by tag from this version
>> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier.
>> I think that this patch-set need to test with this patchset.
>> If you possible, could you please test this patch-set? Thanks in advance.
>>
>> To Tobias,
>> I fixed the following issues reported by you. Thanks your test and report.
>> - RCU locking issue
>> - debugfs error during kernel booting
>>
>> Best Regards,
>> Chanwoo Choi
>
> This set works fine on odroid U3 but gives the following with dmesg |grep devfreq:
>
> [ 2.066890] devfreq bus_dmc: Couldn't update frequency transition information.
> [ 2.190238] devfreq bus_leftbus: Couldn't update frequency transition information.
I have yet to test this new iteration of the patchset, but this message
looks familiar. I already encountered it with the older version applied
to vanilla-4.5.y.
The messages happen when devfreq_update_status() (in
drivers/devfreq/devfreq.c) encounters a uninitialized (zero)
previous_freq. I have currently fixed this in my local tree by just
skipping (goto out) devfreq_update_status() in that case.
Maybe it would be more elegant to set previous_freq to something sane on
probe. IIRC then it is set from initial_freq on probe, but the exynos
code doesn't set this one.
Maybe this info is helpful?
With best wishes,
Tobias
>
> Thanks,
> --
> Markus Reichl
>
>>
>> On 2016년 03월 24일 13:25, Chanwoo Choi wrote:
>>> Dear all,
>>>
>>> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
>>> devfreq device using ondemand governor and devfreq device using passive
>>> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
>>> detailed issue information. But, this patchset don't modify the anything of
>>> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
>>> from Exynos Soc Maintainer.
>>>
>>> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
>>>
>>> [Description]
>>> This patch-set includes the two features as following. The generic exynos bus
>>> frequency driver is able to support almost Exynos SoCs for bus frequency
>>> scaling. And the new passive governor is able to make the dependency on
>>> between devices for frequency/voltage scaling. I had posted the patch-set[1]
>>> with the similiar concept. This is is revised version for exynos bus frequency.
>>> - Generic exynos bus frequency driver
>>> - New passive governor of DEVFREQ framework
>>> [1] https://lkml.org/lkml/2015/1/7/872
>>> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>>>
>>> Changes from v4:
>>> (https://lkml.org/lkml/2015/12/14/43)
>>> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
>>> devfreq device recevie the changed frequency of parent
>>> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
>>> - Add governor type to identify thme using the defined constant
>>> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
>>> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
>>> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>>>
>>> Changes from v3:
>>> (https://lkml.org/lkml/2015/12/11/75)
>>> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
>>> - Fix typo of the description on patch14
>>> - Modify the subject and description of patch17
>>> - Reorder the 'bus_xxx' device tree node alphabetically in
>>> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>>>
>>> Changes from v2:
>>> (https://lkml.org/lkml/2015/12/8/869)
>>> - Fix typo on documentation
>>> - Modify the more appropriate sentence on patch description
>>> - Add the detailed description about both parent and passive bus device
>>> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
>>> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
>>> - Rename OPP nodes as 'opp@<opp-hz>'
>>> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
>>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
>>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
>>> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
>>> on rinato/monk/trats2/odroid-u3 board
>>> - Add the log message if bus device is registered to devfreq framework successfully
>>> - Add the reviewed-by tag from Krzysztof Kozlowski
>>> - Add the tested-by tag from Anand Moon on Odroid U3
>>> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>>>
>>> Changes from v1:
>>> (https://lkml.org/lkml/2015/11/26/260)
>>> - Check whether the instance of regulator is NULL or not
>>> when executing regulator_disable() because of only parent
>>> devfreq device has the regulator instance. After fixing it,
>>> the wake-up from suspend state is well working. (patch1)
>>> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
>>> after calling devm_clk_get() (on patch1)
>>> - Update the documentation to remove the description about
>>> DEVFREQ-EVENT subsystem (on patch2)
>>> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
>>> - Modify the detailed correlation of buses for Exynos3250
>>> on documentation (patch2)
>>> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
>>> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
>>> - Add the PPMU node for exynos4412-odroidu3
>>> - Add the support of bus frequency for exynos4412-odroidu3
>>>
>>> Detailed descirption for patch-set:
>>> 1. Add generic exynos bus frequency driver
>>> : This patch-set adds the generic exynos bus frequency driver for AXI bus
>>> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
>>> architecture for bus between DRAM and sub-blocks in SoC.
>>>
>>> There are the different buses according to Exynos SoC because Exynos SoC
>>> has the differnt sub-blocks and bus speed. In spite of this difference
>>> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
>>> unique data of each bus in the devicetree file.
>>>
>>> In devicetree, each bus node has a bus clock, regulator, operation-point
>>> and devfreq-event devices which measure the utilization of each bus block.
>>>
>>> For example,
>>> - The bus of DMC block in exynos3250.dtsi are listed below:
>>>
>>> bus_dmc: bus_dmc {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu_dmc CLK_DIV_DMC>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_dmc_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> bus_dmc_opp_table: opp_table1 {
>>> compatible = "operating-points-v2";
>>> opp-shared;
>>>
>>> opp@50000000 {
>>> opp-hz = /bits/ 64 <50000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@100000000 {
>>> opp-hz = /bits/ 64 <100000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@134000000 {
>>> opp-hz = /bits/ 64 <134000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@200000000 {
>>> opp-hz = /bits/ 64 <200000000>;
>>> opp-microvolt = <825000>;
>>> };
>>> opp@400000000 {
>>> opp-hz = /bits/ 64 <400000000>;
>>> opp-microvolt = <875000>;
>>> };
>>> };
>>>
>>> - Usage case to handle the frequency and voltage of bus on runtime
>>> in exynos3250-rinato.dts are listed below:
>>>
>>> &bus_dmc {
>>> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>>> vdd-supply = <&buck1_reg>; /* VDD_MIF */
>>> status = "okay";
>>> };
>>>
>>> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
>>> : This patch-set add the new passive governor for DEVFREQ framework.
>>> The existing governors (ondemand, performance and so on) are used for DVFS
>>> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
>>> are independently used for specific device driver which don't give the
>>> influence to other device drviers and also don't receive the effect from
>>> other device drivers.
>>>
>>> The passive governor depends on operation of parent driver with existing
>>> governors(ondemand, performance and so on) extremely and is not able to
>>> decide the new frequency by oneself. According to the decided new frequency
>>> of parent driver with governor, the passive governor uses it to decide
>>> the appropriate frequency for own device driver. The passive governor
>>> must need the following information from device tree:
>>>
>>> For exameple,
>>> There are one more bus device drivers in Exynos3250 which need to
>>> change their source clock according to their utilization on runtime.
>>> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
>>> driver is operated as parent with ondemand governor and then the rest
>>> device driver with passive governor.
>>>
>>> The buses of Internal block in exynos3250.dtsi are listed below:
>>> When LEFTBUS bus driver (parent) changes the bus frequency with
>>> ondemand governor on runtime, the rest bus devices which sharing
>>> the same power line (VDD_INT) will change the each bus frequency
>>> according to the decision of LEFTBUS bus driver (parent).
>>>
>>> - INT (Internal) block
>>> : VDD_INT |--- LEFTBUS
>>> |--- PERIL
>>> |--- MFC
>>> |--- G3D
>>> |--- RIGHTBUS
>>> |--- FSYS
>>> |--- LCD0
>>> |--- PERIR
>>> |--- ISP
>>> |--- CAM
>>>
>>> - The buss of INT block in exynos3250.dtsi are listed below:
>>> bus_leftbus: bus_leftbus {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu CLK_DIV_GDL>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_leftbus_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> bus_rightbus: bus_rightbus {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu CLK_DIV_GDR>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_leftbus_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> (Omit the rest bus dt node)
>>>
>>> - Usage case to handle the frequency and voltage of bus on runtime
>>> in exynos3250-rinato.dts are listed below:
>>> /* Parent bus device of VDD_INT */
>>> &bus_leftbus {
>>> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
>>> vdd-supply = <&buck3_reg>;
>>> status = "okay";
>>> };
>>>
>>> /* Passive bus device depend on LEFTBUS bus. */
>>> &bus_rightbus {
>>> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
>>> the phandle of parent device. */
>>> status = "okay";
>>> };
>>>
>>> (Omit the rest bus dt node)
>>>
>>> Chanwoo Choi (21):
>>> PM / devfreq: exynos: Add generic exynos bus frequency driver
>>> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
>>> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
>>> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
>>> PM / devfreq: Add governer type with unique number
>>> PM / devfreq: Add new passive governor
>>> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
>>> PM / devfreq: exynos: Update documentation for bus devices using passive governor
>>> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
>>> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
>>> MAINTAINERS: Add samsung bus frequency driver entry
>>> ARM: dts: Add DMC bus node for Exynos3250
>>> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
>>> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
>>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
>>> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
>>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
>>> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
>>> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
>>> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
>>> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>>>
>>> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
>>> MAINTAINERS | 9 +
>>> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
>>> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
>>> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
>>> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
>>> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
>>> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
>>> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
>>> drivers/devfreq/Kconfig | 35 +-
>>> drivers/devfreq/Makefile | 4 +-
>>> drivers/devfreq/devfreq.c | 224 ++++-
>>> drivers/devfreq/exynos-bus.c | 561 +++++++++++
>>> drivers/devfreq/exynos/Makefile | 3 -
>>> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
>>> drivers/devfreq/exynos/exynos4_bus.h | 110 --
>>> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
>>> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
>>> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
>>> drivers/devfreq/governor.h | 21 +
>>> drivers/devfreq/governor_passive.c | 192 ++++
>>> drivers/devfreq/governor_performance.c | 1 +
>>> drivers/devfreq/governor_powersave.c | 1 +
>>> drivers/devfreq/governor_simpleondemand.c | 1 +
>>> drivers/devfreq/governor_userspace.c | 1 +
>>> include/linux/devfreq.h | 70 ++
>>> 27 files changed, 2209 insertions(+), 1948 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>>> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>>> create mode 100644 drivers/devfreq/exynos-bus.c
>>> delete mode 100644 drivers/devfreq/exynos/Makefile
>>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
>>> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
>>> create mode 100644 drivers/devfreq/governor_passive.c
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Date | 2016-03-24 15:20 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgehb-3KY-1@gated-at.bofh.it> |
| In reply to | #1364180 |
Hi Tobias, On Thu, Mar 24, 2016 at 10:52 PM, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: > Hello everybody, > > > Markus Reichl wrote: >> Hi Chanwoo, >> >> Am 24.03.2016 um 05:30 schrieb Chanwoo Choi: >>> Dear Anand and Tobias, >>> >>> To Anand, >>> First of all, thanks to your test on previous patchset. >>> I removed the your tested-by tag from this version >>> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier. >>> I think that this patch-set need to test with this patchset. >>> If you possible, could you please test this patch-set? Thanks in advance. >>> >>> To Tobias, >>> I fixed the following issues reported by you. Thanks your test and report. >>> - RCU locking issue >>> - debugfs error during kernel booting >>> >>> Best Regards, >>> Chanwoo Choi >> >> This set works fine on odroid U3 but gives the following with dmesg |grep devfreq: >> >> [ 2.066890] devfreq bus_dmc: Couldn't update frequency transition information. >> [ 2.190238] devfreq bus_leftbus: Couldn't update frequency transition information. > I have yet to test this new iteration of the patchset, but this message > looks familiar. I already encountered it with the older version applied > to vanilla-4.5.y. > > The messages happen when devfreq_update_status() (in > drivers/devfreq/devfreq.c) encounters a uninitialized (zero) > previous_freq. I have currently fixed this in my local tree by just > skipping (goto out) devfreq_update_status() in that case. I agree. Your comment is correct. > > Maybe it would be more elegant to set previous_freq to something sane on > probe. IIRC then it is set from initial_freq on probe, but the exynos > code doesn't set this one. The devfreq have already this issue before sending my patches. So, I think that you better to send your fixup patch. Maybe, the exynos-bus.c read the current frequency in the probe function and then devfreq core should set the devfreq->previous_freq field. > > Maybe this info is helpful? Your info is very helpful. Thanks. Best Regards, Chanwoo Choi
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Date | 2016-03-24 15:30 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgeqR-3Ql-1@gated-at.bofh.it> |
| In reply to | #1364170 |
Hi Makus,
On Thu, Mar 24, 2016 at 10:41 PM, Markus Reichl <m.reichl@fivetechno.de> wrote:
> Hi Chanwoo,
>
> Am 24.03.2016 um 05:30 schrieb Chanwoo Choi:
>> Dear Anand and Tobias,
>>
>> To Anand,
>> First of all, thanks to your test on previous patchset.
>> I removed the your tested-by tag from this version
>> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier.
>> I think that this patch-set need to test with this patchset.
>> If you possible, could you please test this patch-set? Thanks in advance.
>>
>> To Tobias,
>> I fixed the following issues reported by you. Thanks your test and report.
>> - RCU locking issue
>> - debugfs error during kernel booting
>>
>> Best Regards,
>> Chanwoo Choi
>
> This set works fine on odroid U3 but gives the following with dmesg |grep devfreq:
>
> [ 2.066890] devfreq bus_dmc: Couldn't update frequency transition information.
> [ 2.190238] devfreq bus_leftbus: Couldn't update frequency transition information.
Tobias already replied it about this message. The devfreq core need to
be modified
about this issue. But, It is no problem for working exynos-bus.c driver.
If you possible, could you send the Tested-by tag reply about this patch-set?
Best Regards,
Chanwoo Choi
>
> Thanks,
> --
> Markus Reichl
>
>>
>> On 2016년 03월 24일 13:25, Chanwoo Choi wrote:
>>> Dear all,
>>>
>>> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
>>> devfreq device using ondemand governor and devfreq device using passive
>>> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
>>> detailed issue information. But, this patchset don't modify the anything of
>>> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
>>> from Exynos Soc Maintainer.
>>>
>>> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
>>>
>>> [Description]
>>> This patch-set includes the two features as following. The generic exynos bus
>>> frequency driver is able to support almost Exynos SoCs for bus frequency
>>> scaling. And the new passive governor is able to make the dependency on
>>> between devices for frequency/voltage scaling. I had posted the patch-set[1]
>>> with the similiar concept. This is is revised version for exynos bus frequency.
>>> - Generic exynos bus frequency driver
>>> - New passive governor of DEVFREQ framework
>>> [1] https://lkml.org/lkml/2015/1/7/872
>>> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>>>
>>> Changes from v4:
>>> (https://lkml.org/lkml/2015/12/14/43)
>>> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
>>> devfreq device recevie the changed frequency of parent
>>> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
>>> - Add governor type to identify thme using the defined constant
>>> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
>>> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
>>> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>>>
>>> Changes from v3:
>>> (https://lkml.org/lkml/2015/12/11/75)
>>> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
>>> - Fix typo of the description on patch14
>>> - Modify the subject and description of patch17
>>> - Reorder the 'bus_xxx' device tree node alphabetically in
>>> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>>>
>>> Changes from v2:
>>> (https://lkml.org/lkml/2015/12/8/869)
>>> - Fix typo on documentation
>>> - Modify the more appropriate sentence on patch description
>>> - Add the detailed description about both parent and passive bus device
>>> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
>>> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
>>> - Rename OPP nodes as 'opp@<opp-hz>'
>>> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
>>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
>>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
>>> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
>>> on rinato/monk/trats2/odroid-u3 board
>>> - Add the log message if bus device is registered to devfreq framework successfully
>>> - Add the reviewed-by tag from Krzysztof Kozlowski
>>> - Add the tested-by tag from Anand Moon on Odroid U3
>>> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>>>
>>> Changes from v1:
>>> (https://lkml.org/lkml/2015/11/26/260)
>>> - Check whether the instance of regulator is NULL or not
>>> when executing regulator_disable() because of only parent
>>> devfreq device has the regulator instance. After fixing it,
>>> the wake-up from suspend state is well working. (patch1)
>>> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
>>> after calling devm_clk_get() (on patch1)
>>> - Update the documentation to remove the description about
>>> DEVFREQ-EVENT subsystem (on patch2)
>>> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
>>> - Modify the detailed correlation of buses for Exynos3250
>>> on documentation (patch2)
>>> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
>>> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
>>> - Add the PPMU node for exynos4412-odroidu3
>>> - Add the support of bus frequency for exynos4412-odroidu3
>>>
>>> Detailed descirption for patch-set:
>>> 1. Add generic exynos bus frequency driver
>>> : This patch-set adds the generic exynos bus frequency driver for AXI bus
>>> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
>>> architecture for bus between DRAM and sub-blocks in SoC.
>>>
>>> There are the different buses according to Exynos SoC because Exynos SoC
>>> has the differnt sub-blocks and bus speed. In spite of this difference
>>> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
>>> unique data of each bus in the devicetree file.
>>>
>>> In devicetree, each bus node has a bus clock, regulator, operation-point
>>> and devfreq-event devices which measure the utilization of each bus block.
>>>
>>> For example,
>>> - The bus of DMC block in exynos3250.dtsi are listed below:
>>>
>>> bus_dmc: bus_dmc {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu_dmc CLK_DIV_DMC>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_dmc_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> bus_dmc_opp_table: opp_table1 {
>>> compatible = "operating-points-v2";
>>> opp-shared;
>>>
>>> opp@50000000 {
>>> opp-hz = /bits/ 64 <50000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@100000000 {
>>> opp-hz = /bits/ 64 <100000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@134000000 {
>>> opp-hz = /bits/ 64 <134000000>;
>>> opp-microvolt = <800000>;
>>> };
>>> opp@200000000 {
>>> opp-hz = /bits/ 64 <200000000>;
>>> opp-microvolt = <825000>;
>>> };
>>> opp@400000000 {
>>> opp-hz = /bits/ 64 <400000000>;
>>> opp-microvolt = <875000>;
>>> };
>>> };
>>>
>>> - Usage case to handle the frequency and voltage of bus on runtime
>>> in exynos3250-rinato.dts are listed below:
>>>
>>> &bus_dmc {
>>> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>>> vdd-supply = <&buck1_reg>; /* VDD_MIF */
>>> status = "okay";
>>> };
>>>
>>> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
>>> : This patch-set add the new passive governor for DEVFREQ framework.
>>> The existing governors (ondemand, performance and so on) are used for DVFS
>>> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
>>> are independently used for specific device driver which don't give the
>>> influence to other device drviers and also don't receive the effect from
>>> other device drivers.
>>>
>>> The passive governor depends on operation of parent driver with existing
>>> governors(ondemand, performance and so on) extremely and is not able to
>>> decide the new frequency by oneself. According to the decided new frequency
>>> of parent driver with governor, the passive governor uses it to decide
>>> the appropriate frequency for own device driver. The passive governor
>>> must need the following information from device tree:
>>>
>>> For exameple,
>>> There are one more bus device drivers in Exynos3250 which need to
>>> change their source clock according to their utilization on runtime.
>>> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
>>> driver is operated as parent with ondemand governor and then the rest
>>> device driver with passive governor.
>>>
>>> The buses of Internal block in exynos3250.dtsi are listed below:
>>> When LEFTBUS bus driver (parent) changes the bus frequency with
>>> ondemand governor on runtime, the rest bus devices which sharing
>>> the same power line (VDD_INT) will change the each bus frequency
>>> according to the decision of LEFTBUS bus driver (parent).
>>>
>>> - INT (Internal) block
>>> : VDD_INT |--- LEFTBUS
>>> |--- PERIL
>>> |--- MFC
>>> |--- G3D
>>> |--- RIGHTBUS
>>> |--- FSYS
>>> |--- LCD0
>>> |--- PERIR
>>> |--- ISP
>>> |--- CAM
>>>
>>> - The buss of INT block in exynos3250.dtsi are listed below:
>>> bus_leftbus: bus_leftbus {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu CLK_DIV_GDL>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_leftbus_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> bus_rightbus: bus_rightbus {
>>> compatible = "samsung,exynos-bus";
>>> clocks = <&cmu CLK_DIV_GDR>;
>>> clock-names = "bus";
>>> operating-points-v2 = <&bus_leftbus_opp_table>;
>>> status = "disabled";
>>> };
>>>
>>> (Omit the rest bus dt node)
>>>
>>> - Usage case to handle the frequency and voltage of bus on runtime
>>> in exynos3250-rinato.dts are listed below:
>>> /* Parent bus device of VDD_INT */
>>> &bus_leftbus {
>>> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
>>> vdd-supply = <&buck3_reg>;
>>> status = "okay";
>>> };
>>>
>>> /* Passive bus device depend on LEFTBUS bus. */
>>> &bus_rightbus {
>>> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
>>> the phandle of parent device. */
>>> status = "okay";
>>> };
>>>
>>> (Omit the rest bus dt node)
>>>
>>> Chanwoo Choi (21):
>>> PM / devfreq: exynos: Add generic exynos bus frequency driver
>>> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
>>> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
>>> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
>>> PM / devfreq: Add governer type with unique number
>>> PM / devfreq: Add new passive governor
>>> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
>>> PM / devfreq: exynos: Update documentation for bus devices using passive governor
>>> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
>>> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
>>> MAINTAINERS: Add samsung bus frequency driver entry
>>> ARM: dts: Add DMC bus node for Exynos3250
>>> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
>>> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
>>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
>>> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
>>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
>>> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
>>> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
>>> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
>>> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>>>
>>> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
>>> MAINTAINERS | 9 +
>>> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
>>> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
>>> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
>>> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
>>> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
>>> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
>>> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
>>> drivers/devfreq/Kconfig | 35 +-
>>> drivers/devfreq/Makefile | 4 +-
>>> drivers/devfreq/devfreq.c | 224 ++++-
>>> drivers/devfreq/exynos-bus.c | 561 +++++++++++
>>> drivers/devfreq/exynos/Makefile | 3 -
>>> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
>>> drivers/devfreq/exynos/exynos4_bus.h | 110 --
>>> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
>>> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
>>> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
>>> drivers/devfreq/governor.h | 21 +
>>> drivers/devfreq/governor_passive.c | 192 ++++
>>> drivers/devfreq/governor_performance.c | 1 +
>>> drivers/devfreq/governor_powersave.c | 1 +
>>> drivers/devfreq/governor_simpleondemand.c | 1 +
>>> drivers/devfreq/governor_userspace.c | 1 +
>>> include/linux/devfreq.h | 70 ++
>>> 27 files changed, 2209 insertions(+), 1948 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>>> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>>> create mode 100644 drivers/devfreq/exynos-bus.c
>>> delete mode 100644 drivers/devfreq/exynos/Makefile
>>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
>>> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
>>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
>>> create mode 100644 drivers/devfreq/governor_passive.c
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
[toc] | [prev] | [next] | [standalone]
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Date | 2016-03-27 14:30 +0200 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rhhZo-8dF-5@gated-at.bofh.it> |
| In reply to | #1363911 |
Hi Chanwoo Choi,
On 24 March 2016 at 10:00, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Dear Anand and Tobias,
>
> To Anand,
> First of all, thanks to your test on previous patchset.
> I removed the your tested-by tag from this version
> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier.
> I think that this patch-set need to test with this patchset.
> If you possible, could you please test this patch-set? Thanks in advance.
>
I have being following this series, I have tested this series on Odroid U3.
Please feel free to add my Tested tag if needed
Tested-by: Anand Moon <linux.amoon@gmail.com>
Best Regards
-Anand Moon
> To Tobias,
> I fixed the following issues reported by you. Thanks your test and report.
> - RCU locking issue
> - debugfs error during kernel booting
>
> Best Regards,
> Chanwoo Choi
>
> On 2016년 03월 24일 13:25, Chanwoo Choi wrote:
>> Dear all,
>>
>> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
>> devfreq device using ondemand governor and devfreq device using passive
>> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
>> detailed issue information. But, this patchset don't modify the anything of
>> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
>> from Exynos Soc Maintainer.
>>
>> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
>>
>> [Description]
>> This patch-set includes the two features as following. The generic exynos bus
>> frequency driver is able to support almost Exynos SoCs for bus frequency
>> scaling. And the new passive governor is able to make the dependency on
>> between devices for frequency/voltage scaling. I had posted the patch-set[1]
>> with the similiar concept. This is is revised version for exynos bus frequency.
>> - Generic exynos bus frequency driver
>> - New passive governor of DEVFREQ framework
>> [1] https://lkml.org/lkml/2015/1/7/872
>> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>>
>> Changes from v4:
>> (https://lkml.org/lkml/2015/12/14/43)
>> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
>> devfreq device recevie the changed frequency of parent
>> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
>> - Add governor type to identify thme using the defined constant
>> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
>> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
>> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>>
>> Changes from v3:
>> (https://lkml.org/lkml/2015/12/11/75)
>> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
>> - Fix typo of the description on patch14
>> - Modify the subject and description of patch17
>> - Reorder the 'bus_xxx' device tree node alphabetically in
>> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>>
>> Changes from v2:
>> (https://lkml.org/lkml/2015/12/8/869)
>> - Fix typo on documentation
>> - Modify the more appropriate sentence on patch description
>> - Add the detailed description about both parent and passive bus device
>> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
>> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
>> - Rename OPP nodes as 'opp@<opp-hz>'
>> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
>> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
>> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
>> on rinato/monk/trats2/odroid-u3 board
>> - Add the log message if bus device is registered to devfreq framework successfully
>> - Add the reviewed-by tag from Krzysztof Kozlowski
>> - Add the tested-by tag from Anand Moon on Odroid U3
>> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>>
>> Changes from v1:
>> (https://lkml.org/lkml/2015/11/26/260)
>> - Check whether the instance of regulator is NULL or not
>> when executing regulator_disable() because of only parent
>> devfreq device has the regulator instance. After fixing it,
>> the wake-up from suspend state is well working. (patch1)
>> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
>> after calling devm_clk_get() (on patch1)
>> - Update the documentation to remove the description about
>> DEVFREQ-EVENT subsystem (on patch2)
>> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
>> - Modify the detailed correlation of buses for Exynos3250
>> on documentation (patch2)
>> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
>> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
>> - Add the PPMU node for exynos4412-odroidu3
>> - Add the support of bus frequency for exynos4412-odroidu3
>>
>> Detailed descirption for patch-set:
>> 1. Add generic exynos bus frequency driver
>> : This patch-set adds the generic exynos bus frequency driver for AXI bus
>> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
>> architecture for bus between DRAM and sub-blocks in SoC.
>>
>> There are the different buses according to Exynos SoC because Exynos SoC
>> has the differnt sub-blocks and bus speed. In spite of this difference
>> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
>> unique data of each bus in the devicetree file.
>>
>> In devicetree, each bus node has a bus clock, regulator, operation-point
>> and devfreq-event devices which measure the utilization of each bus block.
>>
>> For example,
>> - The bus of DMC block in exynos3250.dtsi are listed below:
>>
>> bus_dmc: bus_dmc {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu_dmc CLK_DIV_DMC>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_dmc_opp_table>;
>> status = "disabled";
>> };
>>
>> bus_dmc_opp_table: opp_table1 {
>> compatible = "operating-points-v2";
>> opp-shared;
>>
>> opp@50000000 {
>> opp-hz = /bits/ 64 <50000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@100000000 {
>> opp-hz = /bits/ 64 <100000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@134000000 {
>> opp-hz = /bits/ 64 <134000000>;
>> opp-microvolt = <800000>;
>> };
>> opp@200000000 {
>> opp-hz = /bits/ 64 <200000000>;
>> opp-microvolt = <825000>;
>> };
>> opp@400000000 {
>> opp-hz = /bits/ 64 <400000000>;
>> opp-microvolt = <875000>;
>> };
>> };
>>
>> - Usage case to handle the frequency and voltage of bus on runtime
>> in exynos3250-rinato.dts are listed below:
>>
>> &bus_dmc {
>> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
>> vdd-supply = <&buck1_reg>; /* VDD_MIF */
>> status = "okay";
>> };
>>
>> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
>> : This patch-set add the new passive governor for DEVFREQ framework.
>> The existing governors (ondemand, performance and so on) are used for DVFS
>> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
>> are independently used for specific device driver which don't give the
>> influence to other device drviers and also don't receive the effect from
>> other device drivers.
>>
>> The passive governor depends on operation of parent driver with existing
>> governors(ondemand, performance and so on) extremely and is not able to
>> decide the new frequency by oneself. According to the decided new frequency
>> of parent driver with governor, the passive governor uses it to decide
>> the appropriate frequency for own device driver. The passive governor
>> must need the following information from device tree:
>>
>> For exameple,
>> There are one more bus device drivers in Exynos3250 which need to
>> change their source clock according to their utilization on runtime.
>> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
>> driver is operated as parent with ondemand governor and then the rest
>> device driver with passive governor.
>>
>> The buses of Internal block in exynos3250.dtsi are listed below:
>> When LEFTBUS bus driver (parent) changes the bus frequency with
>> ondemand governor on runtime, the rest bus devices which sharing
>> the same power line (VDD_INT) will change the each bus frequency
>> according to the decision of LEFTBUS bus driver (parent).
>>
>> - INT (Internal) block
>> : VDD_INT |--- LEFTBUS
>> |--- PERIL
>> |--- MFC
>> |--- G3D
>> |--- RIGHTBUS
>> |--- FSYS
>> |--- LCD0
>> |--- PERIR
>> |--- ISP
>> |--- CAM
>>
>> - The buss of INT block in exynos3250.dtsi are listed below:
>> bus_leftbus: bus_leftbus {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu CLK_DIV_GDL>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_leftbus_opp_table>;
>> status = "disabled";
>> };
>>
>> bus_rightbus: bus_rightbus {
>> compatible = "samsung,exynos-bus";
>> clocks = <&cmu CLK_DIV_GDR>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_leftbus_opp_table>;
>> status = "disabled";
>> };
>>
>> (Omit the rest bus dt node)
>>
>> - Usage case to handle the frequency and voltage of bus on runtime
>> in exynos3250-rinato.dts are listed below:
>> /* Parent bus device of VDD_INT */
>> &bus_leftbus {
>> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
>> vdd-supply = <&buck3_reg>;
>> status = "okay";
>> };
>>
>> /* Passive bus device depend on LEFTBUS bus. */
>> &bus_rightbus {
>> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
>> the phandle of parent device. */
>> status = "okay";
>> };
>>
>> (Omit the rest bus dt node)
>>
>> Chanwoo Choi (21):
>> PM / devfreq: exynos: Add generic exynos bus frequency driver
>> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
>> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
>> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
>> PM / devfreq: Add governer type with unique number
>> PM / devfreq: Add new passive governor
>> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
>> PM / devfreq: exynos: Update documentation for bus devices using passive governor
>> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
>> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
>> MAINTAINERS: Add samsung bus frequency driver entry
>> ARM: dts: Add DMC bus node for Exynos3250
>> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
>> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
>> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
>> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
>> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
>> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
>> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
>> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>>
>> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
>> MAINTAINERS | 9 +
>> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
>> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
>> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
>> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
>> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
>> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
>> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
>> drivers/devfreq/Kconfig | 35 +-
>> drivers/devfreq/Makefile | 4 +-
>> drivers/devfreq/devfreq.c | 224 ++++-
>> drivers/devfreq/exynos-bus.c | 561 +++++++++++
>> drivers/devfreq/exynos/Makefile | 3 -
>> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
>> drivers/devfreq/exynos/exynos4_bus.h | 110 --
>> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
>> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
>> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
>> drivers/devfreq/governor.h | 21 +
>> drivers/devfreq/governor_passive.c | 192 ++++
>> drivers/devfreq/governor_performance.c | 1 +
>> drivers/devfreq/governor_powersave.c | 1 +
>> drivers/devfreq/governor_simpleondemand.c | 1 +
>> drivers/devfreq/governor_userspace.c | 1 +
>> include/linux/devfreq.h | 70 ++
>> 27 files changed, 2209 insertions(+), 1948 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> create mode 100644 drivers/devfreq/exynos-bus.c
>> delete mode 100644 drivers/devfreq/exynos/Makefile
>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
>> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
>> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
>> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
>> create mode 100644 drivers/devfreq/governor_passive.c
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Date | 2016-03-27 16:00 +0200 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rhjou-F8-3@gated-at.bofh.it> |
| In reply to | #1365107 |
Hi Anand, On Sun, Mar 27, 2016 at 9:28 PM, Anand Moon <linux.amoon@gmail.com> wrote: > Hi Chanwoo Choi, > > On 24 March 2016 at 10:00, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Dear Anand and Tobias, >> >> To Anand, >> First of all, thanks to your test on previous patchset. >> I removed the your tested-by tag from this version >> because I modified the devfreq core using DEVFREQ_TRANSITION_NOTIFIER notifier. >> I think that this patch-set need to test with this patchset. >> If you possible, could you please test this patch-set? Thanks in advance. >> > I have being following this series, I have tested this series on Odroid U3. > > Please feel free to add my Tested tag if needed > > Tested-by: Anand Moon <linux.amoon@gmail.com> Thanks for your test again. Best Regards, Chanwoo Choi [snip]
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 11/21] MAINTAINERS: Add samsung bus frequency driver entry |
| Message-ID | <rg5dU-5HE-15@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the 'BUS FREQUENCY DRIVER FOR SAMSUNG EXYNOS' entry to review the patches as maintainer. Patches will be picked up by DEVFREQ maintainer on devfreq git repository. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32bafda47c2f..9040f6a89ffe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3539,6 +3539,15 @@ F: drivers/devfreq/devfreq-event.c F: include/linux/devfreq-event.h F: Documentation/devicetree/bindings/devfreq/event/ +BUS FREQUENCY DRIVER FOR SAMSUNG EXYNOS +M: Chanwoo Choi <cw00.choi@samsung.com> +L: linux-pm@vger.kernel.org +L: linux-samsung-soc@vger.kernel.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git +S: Maintained +F: drivers/devfreq/exynos-bus.c +F: Documentation/devicetree/bindings/devfreq/exynos-bus.txt + DEVICE NUMBER REGISTRY M: Torben Mathiasen <device@lanana.org> W: http://lanana.org/docs/device-list/index.html -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 05/21] PM / devfreq: Add governer type with unique number |
| Message-ID | <rg5dU-5HE-17@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch just adds the governor type to identify them
by using the defined constant.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/governor.h | 6 ++++++
drivers/devfreq/governor_performance.c | 1 +
drivers/devfreq/governor_powersave.c | 1 +
drivers/devfreq/governor_simpleondemand.c | 1 +
drivers/devfreq/governor_userspace.c | 1 +
include/linux/devfreq.h | 2 ++
6 files changed, 12 insertions(+)
diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index fad7d6321978..cf19b923c362 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -18,6 +18,12 @@
#define to_devfreq(DEV) container_of((DEV), struct devfreq, dev)
+/* Devfreq governor type */
+#define DEVFREQ_GOV_ONDEMAND 0x1
+#define DEVFREQ_GOV_PERFORMANCE 0x2
+#define DEVFREQ_GOV_POWERSAVE 0x3
+#define DEVFREQ_GOV_USERSPACE 0x4
+
/* Devfreq events */
#define DEVFREQ_GOV_START 0x1
#define DEVFREQ_GOV_STOP 0x2
diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
index c72f942f30a8..594d8ecb13fb 100644
--- a/drivers/devfreq/governor_performance.c
+++ b/drivers/devfreq/governor_performance.c
@@ -43,6 +43,7 @@ static int devfreq_performance_handler(struct devfreq *devfreq,
static struct devfreq_governor devfreq_performance = {
.name = "performance",
+ .type = DEVFREQ_GOV_PERFORMANCE,
.get_target_freq = devfreq_performance_func,
.event_handler = devfreq_performance_handler,
};
diff --git a/drivers/devfreq/governor_powersave.c b/drivers/devfreq/governor_powersave.c
index 0c6bed567e6d..e2817e1f2a31 100644
--- a/drivers/devfreq/governor_powersave.c
+++ b/drivers/devfreq/governor_powersave.c
@@ -40,6 +40,7 @@ static int devfreq_powersave_handler(struct devfreq *devfreq,
static struct devfreq_governor devfreq_powersave = {
.name = "powersave",
+ .type = DEVFREQ_GOV_POWERSAVE,
.get_target_freq = devfreq_powersave_func,
.event_handler = devfreq_powersave_handler,
};
diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
index ae72ba5e78df..b905a535d486 100644
--- a/drivers/devfreq/governor_simpleondemand.c
+++ b/drivers/devfreq/governor_simpleondemand.c
@@ -126,6 +126,7 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq,
static struct devfreq_governor devfreq_simple_ondemand = {
.name = "simple_ondemand",
+ .type = DEVFREQ_GOV_ONDEMAND,
.get_target_freq = devfreq_simple_ondemand_func,
.event_handler = devfreq_simple_ondemand_handler,
};
diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
index 35de6e83c1fe..c78ab78a5220 100644
--- a/drivers/devfreq/governor_userspace.c
+++ b/drivers/devfreq/governor_userspace.c
@@ -138,6 +138,7 @@ static int devfreq_userspace_handler(struct devfreq *devfreq,
static struct devfreq_governor devfreq_userspace = {
.name = "userspace",
+ .type = DEVFREQ_GOV_USERSPACE,
.get_target_freq = devfreq_userspace_func,
.event_handler = devfreq_userspace_handler,
};
diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
index 152ea342529c..9baf45f661ad 100644
--- a/include/linux/devfreq.h
+++ b/include/linux/devfreq.h
@@ -104,6 +104,7 @@ struct devfreq_dev_profile {
* struct devfreq_governor - Devfreq policy governor
* @node: list node - contains registered devfreq governors
* @name: Governor's name
+ * @type: Governor's type
* @get_target_freq: Returns desired operating frequency for the device.
* Basically, get_target_freq will run
* devfreq_dev_profile.get_dev_status() to get the
@@ -121,6 +122,7 @@ struct devfreq_governor {
struct list_head node;
const char name[DEVFREQ_NAME_LEN];
+ const int type;
int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
int (*event_handler)(struct devfreq *devfreq,
unsigned int event, void *data);
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 13/21] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk |
| Message-ID | <rg5dU-5HE-23@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the DMC (Dynamic Memory Controller) bus frequency node
which includes the devfreq-events and regulator properties. The bus
frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature
with ondemand governor.
The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus
on runtime and the buck1_reg (VDD_MIF power line) supplies the power to
the DMC block.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---
arch/arm/boot/dts/exynos3250-monk.dts | 6 ++++++
arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 9e2840b59ae8..1fd7ecb5c415 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -156,6 +156,12 @@
};
};
+&bus_dmc {
+ devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
+ vdd-supply = <&buck1_reg>;
+ status = "okay";
+};
+
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 1f102f3a1ab1..5175bd7e015f 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -147,6 +147,12 @@
};
};
+&bus_dmc {
+ devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
+ vdd-supply = <&buck1_reg>;
+ status = "okay";
+};
+
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-24 05:40 +0100 |
| Subject | [PATCH v5 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier |
| Message-ID | <rg5dU-5HE-21@gated-at.bofh.it> |
| In reply to | #1363904 |
This patch adds the new DEVFREQ_TRANSITION_NOTIFIER notifier to send
the notification when the frequency of device is changed.
This notifier has two state as following:
- DEVFREQ_PRECHANGE : Notify it before chaning the frequency of device
- DEVFREQ_POSTCHANGE : Notify it after changed the frequency of device
And this patch adds the resourced-managed function to release the resource
automatically when error happen.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/devfreq.c | 163 +++++++++++++++++++++++++++++++++++++++++++++-
include/linux/devfreq.h | 58 ++++++++++++++++-
2 files changed, 219 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 20a9422c2552..1d6c803804d5 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -189,6 +189,29 @@ static struct devfreq_governor *find_devfreq_governor(const char *name)
return ERR_PTR(-ENODEV);
}
+static int devfreq_notify_transition(struct devfreq *devfreq,
+ struct devfreq_freqs *freqs, unsigned int state)
+{
+ if (!devfreq)
+ return -EINVAL;
+
+ switch (state) {
+ case DEVFREQ_PRECHANGE:
+ srcu_notifier_call_chain(&devfreq->transition_notifier_list,
+ DEVFREQ_PRECHANGE, freqs);
+ break;
+
+ case DEVFREQ_POSTCHANGE:
+ srcu_notifier_call_chain(&devfreq->transition_notifier_list,
+ DEVFREQ_POSTCHANGE, freqs);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
/* Load monitoring helper functions for governors use */
/**
@@ -200,7 +223,8 @@ static struct devfreq_governor *find_devfreq_governor(const char *name)
*/
int update_devfreq(struct devfreq *devfreq)
{
- unsigned long freq;
+ struct devfreq_freqs freqs;
+ unsigned long freq, cur_freq;
int err = 0;
u32 flags = 0;
@@ -234,10 +258,22 @@ int update_devfreq(struct devfreq *devfreq)
flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */
}
+ if (devfreq->profile->get_cur_freq)
+ devfreq->profile->get_cur_freq(devfreq->dev.parent, &cur_freq);
+ else
+ cur_freq = devfreq->previous_freq;
+
+ freqs.old = cur_freq;
+ freqs.new = freq;
+ devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
+
err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
if (err)
return err;
+ freqs.new = freq;
+ devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
+
if (devfreq->profile->freq_table)
if (devfreq_update_status(devfreq, freq))
dev_err(&devfreq->dev,
@@ -542,6 +578,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
goto err_out;
}
+ srcu_init_notifier_head(&devfreq->transition_notifier_list);
+
mutex_unlock(&devfreq->lock);
mutex_lock(&devfreq_list_lock);
@@ -1310,6 +1348,129 @@ void devm_devfreq_unregister_opp_notifier(struct device *dev,
}
EXPORT_SYMBOL(devm_devfreq_unregister_opp_notifier);
+/**
+ * devfreq_register_notifier() - Register a driver with devfreq
+ * @devfreq: The devfreq object.
+ * @nb: The notifier block to register.
+ * @list: DEVFREQ_TRANSITION_NOTIFIER.
+ */
+int devfreq_register_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ int ret = 0;
+
+ if (!devfreq)
+ return -EINVAL;
+
+ switch (list) {
+ case DEVFREQ_TRANSITION_NOTIFIER:
+ ret = srcu_notifier_chain_register(
+ &devfreq->transition_notifier_list, nb);
+ break;
+ default:
+ ret = -EINVAL;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL(devfreq_register_notifier);
+
+/*
+ * devfreq_unregister_notifier() - Unregister a driver with devfreq
+ * @devfreq: The devfreq object.
+ * @nb: The notifier block to be unregistered.
+ * @list: DEVFREQ_TRANSITION_NOTIFIER.
+ */
+int devfreq_unregister_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ int ret = 0;
+
+ if (!devfreq)
+ return -EINVAL;
+
+ switch (list) {
+ case DEVFREQ_TRANSITION_NOTIFIER:
+ ret = srcu_notifier_chain_unregister(
+ &devfreq->transition_notifier_list, nb);
+ break;
+ default:
+ ret = -EINVAL;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL(devfreq_unregister_notifier);
+
+struct devfreq_notifier_devres {
+ struct devfreq *devfreq;
+ struct notifier_block *nb;
+ unsigned int list;
+};
+
+static void devm_devfreq_notifier_release(struct device *dev, void *res)
+{
+ struct devfreq_notifier_devres *this = res;
+
+ devfreq_unregister_notifier(this->devfreq, this->nb, this->list);
+}
+
+/**
+ * devm_devfreq_register_notifier()
+ - Resource-managed devfreq_register_notifier()
+ * @dev: The devfreq user device. (parent of devfreq)
+ * @devfreq: The devfreq object.
+ * @nb: The notifier block to be unregistered.
+ * @list: DEVFREQ_TRANSITION_NOTIFIER.
+ */
+int devm_devfreq_register_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ struct devfreq_notifier_devres *ptr;
+ int ret;
+
+ ptr = devres_alloc(devm_devfreq_notifier_release, sizeof(*ptr),
+ GFP_KERNEL);
+ if (!ptr)
+ return -ENOMEM;
+
+ ret = devfreq_register_notifier(devfreq, nb, list);
+ if (ret) {
+ devres_free(ptr);
+ return ret;
+ }
+
+ ptr->devfreq = devfreq;
+ ptr->nb = nb;
+ ptr->list = list;
+ devres_add(dev, ptr);
+
+ return 0;
+}
+EXPORT_SYMBOL(devm_devfreq_register_notifier);
+
+/**
+ * devm_devfreq_unregister_notifier()
+ - Resource-managed devfreq_unregister_notifier()
+ * @dev: The devfreq user device. (parent of devfreq)
+ * @devfreq: The devfreq object.
+ * @nb: The notifier block to be unregistered.
+ * @list: DEVFREQ_TRANSITION_NOTIFIER.
+ */
+void devm_devfreq_unregister_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ WARN_ON(devres_release(dev, devm_devfreq_notifier_release,
+ devm_devfreq_dev_match, devfreq));
+}
+EXPORT_SYMBOL(devm_devfreq_unregister_notifier);
+
MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
MODULE_DESCRIPTION("devfreq class support");
MODULE_LICENSE("GPL");
diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
index aa0b8424ebc3..152ea342529c 100644
--- a/include/linux/devfreq.h
+++ b/include/linux/devfreq.h
@@ -19,6 +19,13 @@
#define DEVFREQ_NAME_LEN 16
+/* DEVFREQ notifier interface */
+#define DEVFREQ_TRANSITION_NOTIFIER (0)
+
+/* Transition notifiers of DEVFREQ_TRANSITION_NOTIFIER */
+#define DEVFREQ_PRECHANGE (0)
+#define DEVFREQ_POSTCHANGE (1)
+
struct devfreq;
/**
@@ -177,6 +184,13 @@ struct devfreq {
unsigned int *trans_table;
unsigned long *time_in_state;
unsigned long last_stat_updated;
+
+ struct srcu_notifier_head transition_notifier_list;
+};
+
+struct devfreq_freqs {
+ unsigned long old;
+ unsigned long new;
};
#if defined(CONFIG_PM_DEVFREQ)
@@ -207,7 +221,20 @@ extern int devm_devfreq_register_opp_notifier(struct device *dev,
struct devfreq *devfreq);
extern void devm_devfreq_unregister_opp_notifier(struct device *dev,
struct devfreq *devfreq);
-
+extern int devfreq_register_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list);
+extern int devfreq_unregister_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list);
+extern int devm_devfreq_register_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list);
+extern void devm_devfreq_unregister_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list);
extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
int index);
@@ -310,6 +337,35 @@ static inline void devm_devfreq_unregister_opp_notifier(struct device *dev,
{
}
+static inline int devfreq_register_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ return 0;
+}
+
+static inline int devfreq_unregister_notifier(struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ return 0;
+}
+
+static inline int devm_devfreq_register_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+ return 0;
+}
+
+static inline void devm_devfreq_unregister_notifier(struct device *dev,
+ struct devfreq *devfreq,
+ struct notifier_block *nb,
+ unsigned int list)
+{
+}
+
static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
int index)
{
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Markus Reichl <m.reichl@fivetechno.de> |
|---|---|
| Date | 2016-03-24 15:40 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgeAy-3Uf-29@gated-at.bofh.it> |
| In reply to | #1363904 |
Hi Chanwoo,
Am 24.03.2016 um 05:25 schrieb Chanwoo Choi:
> Dear all,
>
> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth
> devfreq device using ondemand governor and devfreq device using passive
> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the
> detailed issue information. But, this patchset don't modify the anything of
> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by
> from Exynos Soc Maintainer.
>
> I tested it on exynos3250-rinato and exynos4412-odroidu3 board.
On exynos4412-odroidu3 board:
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Regards,
--
Markus Reichl
>
> [Description]
> This patch-set includes the two features as following. The generic exynos bus
> frequency driver is able to support almost Exynos SoCs for bus frequency
> scaling. And the new passive governor is able to make the dependency on
> between devices for frequency/voltage scaling. I had posted the patch-set[1]
> with the similiar concept. This is is revised version for exynos bus frequency.
> - Generic exynos bus frequency driver
> - New passive governor of DEVFREQ framework
> [1] https://lkml.org/lkml/2015/1/7/872
> : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver
>
> Changes from v4:
> (https://lkml.org/lkml/2015/12/14/43)
> - Add new DEVFREQ_TRANSITION_NOTIFIER notifier. The passive
> devfreq device recevie the changed frequency of parent
> devfreq device through DEVFREQ_TRANSITION_NOTIFIER.
> - Add governor type to identify thme using the defined constant
> - Modify the passive governor using the DEVFREQ_TRANSITION_NOTIFIER notifier.
> - Fix the RCU locking probrlm (Reported-by: Tobias Jakobi)
> - Fix the debugfs error during the kernel booting (Reported-by: Tobias Jakobi)
>
> Changes from v3:
> (https://lkml.org/lkml/2015/12/11/75)
> - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17)
> - Fix typo of the description on patch14
> - Modify the subject and description of patch17
> - Reorder the 'bus_xxx' device tree node alphabetically in
> both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3
>
> Changes from v2:
> (https://lkml.org/lkml/2015/12/8/869)
> - Fix typo on documentation
> - Modify the more appropriate sentence on patch description
> - Add the detailed description about both parent and passive bus device
> - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz)
> - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV)
> - Rename OPP nodes as 'opp@<opp-hz>'
> - Delete the duplicate 'opp-microvolt' property of passive devfreq device
> - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts
> - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3
> - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node
> on rinato/monk/trats2/odroid-u3 board
> - Add the log message if bus device is registered to devfreq framework successfully
> - Add the reviewed-by tag from Krzysztof Kozlowski
> - Add the tested-by tag from Anand Moon on Odroid U3
> - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS
>
> Changes from v1:
> (https://lkml.org/lkml/2015/11/26/260)
> - Check whether the instance of regulator is NULL or not
> when executing regulator_disable() because of only parent
> devfreq device has the regulator instance. After fixing it,
> the wake-up from suspend state is well working. (patch1)
> - Fix bug which checks 'bus-clk' instead of 'bus->regulator'
> after calling devm_clk_get() (on patch1)
> - Update the documentation to remove the description about
> DEVFREQ-EVENT subsystem (on patch2)
> - Add the full name of DMC (Dynamic Memory Controller) (on patch2)
> - Modify the detailed correlation of buses for Exynos3250
> on documentation (patch2)
> - Add the MFC bus node for Exynos3250 (on patch11, patch12)
> - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi
> - Add the PPMU node for exynos4412-odroidu3
> - Add the support of bus frequency for exynos4412-odroidu3
>
> Detailed descirption for patch-set:
> 1. Add generic exynos bus frequency driver
> : This patch-set adds the generic exynos bus frequency driver for AXI bus
> of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common
> architecture for bus between DRAM and sub-blocks in SoC.
>
> There are the different buses according to Exynos SoC because Exynos SoC
> has the differnt sub-blocks and bus speed. In spite of this difference
> among Exynos SoCs, this driver is able to support almost Exynos SoC by adding
> unique data of each bus in the devicetree file.
>
> In devicetree, each bus node has a bus clock, regulator, operation-point
> and devfreq-event devices which measure the utilization of each bus block.
>
> For example,
> - The bus of DMC block in exynos3250.dtsi are listed below:
>
> bus_dmc: bus_dmc {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu_dmc CLK_DIV_DMC>;
> clock-names = "bus";
> operating-points-v2 = <&bus_dmc_opp_table>;
> status = "disabled";
> };
>
> bus_dmc_opp_table: opp_table1 {
> compatible = "operating-points-v2";
> opp-shared;
>
> opp@50000000 {
> opp-hz = /bits/ 64 <50000000>;
> opp-microvolt = <800000>;
> };
> opp@100000000 {
> opp-hz = /bits/ 64 <100000000>;
> opp-microvolt = <800000>;
> };
> opp@134000000 {
> opp-hz = /bits/ 64 <134000000>;
> opp-microvolt = <800000>;
> };
> opp@200000000 {
> opp-hz = /bits/ 64 <200000000>;
> opp-microvolt = <825000>;
> };
> opp@400000000 {
> opp-hz = /bits/ 64 <400000000>;
> opp-microvolt = <875000>;
> };
> };
>
> - Usage case to handle the frequency and voltage of bus on runtime
> in exynos3250-rinato.dts are listed below:
>
> &bus_dmc {
> devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> vdd-supply = <&buck1_reg>; /* VDD_MIF */
> status = "okay";
> };
>
> 2. Add new passive governor of DEVFREQ framework (patch5-patch7)
> : This patch-set add the new passive governor for DEVFREQ framework.
> The existing governors (ondemand, performance and so on) are used for DVFS
> (Dynamic Voltage and Frequency Scaling) drivers. The existing governors
> are independently used for specific device driver which don't give the
> influence to other device drviers and also don't receive the effect from
> other device drivers.
>
> The passive governor depends on operation of parent driver with existing
> governors(ondemand, performance and so on) extremely and is not able to
> decide the new frequency by oneself. According to the decided new frequency
> of parent driver with governor, the passive governor uses it to decide
> the appropriate frequency for own device driver. The passive governor
> must need the following information from device tree:
>
> For exameple,
> There are one more bus device drivers in Exynos3250 which need to
> change their source clock according to their utilization on runtime.
> But, they share the same power line (e.g., regulator). So, LEFTBUS bus
> driver is operated as parent with ondemand governor and then the rest
> device driver with passive governor.
>
> The buses of Internal block in exynos3250.dtsi are listed below:
> When LEFTBUS bus driver (parent) changes the bus frequency with
> ondemand governor on runtime, the rest bus devices which sharing
> the same power line (VDD_INT) will change the each bus frequency
> according to the decision of LEFTBUS bus driver (parent).
>
> - INT (Internal) block
> : VDD_INT |--- LEFTBUS
> |--- PERIL
> |--- MFC
> |--- G3D
> |--- RIGHTBUS
> |--- FSYS
> |--- LCD0
> |--- PERIR
> |--- ISP
> |--- CAM
>
> - The buss of INT block in exynos3250.dtsi are listed below:
> bus_leftbus: bus_leftbus {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu CLK_DIV_GDL>;
> clock-names = "bus";
> operating-points-v2 = <&bus_leftbus_opp_table>;
> status = "disabled";
> };
>
> bus_rightbus: bus_rightbus {
> compatible = "samsung,exynos-bus";
> clocks = <&cmu CLK_DIV_GDR>;
> clock-names = "bus";
> operating-points-v2 = <&bus_leftbus_opp_table>;
> status = "disabled";
> };
>
> (Omit the rest bus dt node)
>
> - Usage case to handle the frequency and voltage of bus on runtime
> in exynos3250-rinato.dts are listed below:
> /* Parent bus device of VDD_INT */
> &bus_leftbus {
> devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> vdd-supply = <&buck3_reg>;
> status = "okay";
> };
>
> /* Passive bus device depend on LEFTBUS bus. */
> &bus_rightbus {
> devfreq = <&bus_leftbus>; /* 'devfreq' property indicates
> the phandle of parent device. */
> status = "okay";
> };
>
> (Omit the rest bus dt node)
>
> Chanwoo Choi (21):
> PM / devfreq: exynos: Add generic exynos bus frequency driver
> PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
> PM / devfreq: Add devfreq_get_devfreq_by_phandle()
> PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier
> PM / devfreq: Add governer type with unique number
> PM / devfreq: Add new passive governor
> PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor
> PM / devfreq: exynos: Update documentation for bus devices using passive governor
> PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line
> PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver
> MAINTAINERS: Add samsung bus frequency driver entry
> ARM: dts: Add DMC bus node for Exynos3250
> ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
> ARM: dts: Add bus nodes using VDD_INT for Exynos3250
> ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
> ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
> ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
> ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes
> ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
> ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
> ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
>
> .../devicetree/bindings/devfreq/exynos-bus.txt | 390 ++++++++
> MAINTAINERS | 9 +
> arch/arm/boot/dts/exynos3250-monk.dts | 47 +-
> arch/arm/boot/dts/exynos3250-rinato.dts | 88 +-
> arch/arm/boot/dts/exynos3250.dtsi | 181 ++++
> arch/arm/boot/dts/exynos4210.dtsi | 159 +++
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 56 +-
> arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 +
> arch/arm/boot/dts/exynos4412-trats2.dts | 88 +-
> arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++
> drivers/devfreq/Kconfig | 35 +-
> drivers/devfreq/Makefile | 4 +-
> drivers/devfreq/devfreq.c | 224 ++++-
> drivers/devfreq/exynos-bus.c | 561 +++++++++++
> drivers/devfreq/exynos/Makefile | 3 -
> drivers/devfreq/exynos/exynos4_bus.c | 1055 --------------------
> drivers/devfreq/exynos/exynos4_bus.h | 110 --
> drivers/devfreq/exynos/exynos5_bus.c | 431 --------
> drivers/devfreq/exynos/exynos_ppmu.c | 119 ---
> drivers/devfreq/exynos/exynos_ppmu.h | 86 --
> drivers/devfreq/governor.h | 21 +
> drivers/devfreq/governor_passive.c | 192 ++++
> drivers/devfreq/governor_performance.c | 1 +
> drivers/devfreq/governor_powersave.c | 1 +
> drivers/devfreq/governor_simpleondemand.c | 1 +
> drivers/devfreq/governor_userspace.c | 1 +
> include/linux/devfreq.h | 70 ++
> 27 files changed, 2209 insertions(+), 1948 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
> create mode 100644 drivers/devfreq/exynos-bus.c
> delete mode 100644 drivers/devfreq/exynos/Makefile
> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c
> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h
> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c
> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c
> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h
> create mode 100644 drivers/devfreq/governor_passive.c
>
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-03-25 00:40 +0100 |
| Subject | Re: [PATCH v5 00/21] PM / devferq: Add generic exynos bus frequency driver and new passive governor |
| Message-ID | <rgn17-1tn-3@gated-at.bofh.it> |
| In reply to | #1364206 |
Hi Markus, On 2016년 03월 24일 23:37, Markus Reichl wrote: > Hi Chanwoo, > > Am 24.03.2016 um 05:25 schrieb Chanwoo Choi: >> Dear all, >> >> This patchset uses the DEVFREQ_TRANSITION_NOTIFIER notifier to connecth >> devfreq device using ondemand governor and devfreq device using passive >> governor. Also I fix the some issue reported by 'Tobias Jakobi' and add the >> detailed issue information. But, this patchset don't modify the anything of >> Device Tree patches (patch12 ~ patch21) which already got the reviewed-by >> from Exynos Soc Maintainer. >> >> I tested it on exynos3250-rinato and exynos4412-odroidu3 board. > > On exynos4412-odroidu3 board: > > Tested-by: Markus Reichl <m.reichl@fivetechno.de> Thanks for your test. Best Regards, Chanwoo Choi [snip]
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web