Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362777 > unrolled thread

[PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io port access static

Back to article view | Back to linux.kernel

Contents

  [PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io port access static Jisheng Zhang <jszhang@marvell.com> - 2016-03-22 15:40 +0100
    Re: [PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io  port access static Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-22 15:50 +0100
      Re: [PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io port access static "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-23 22:30 +0100

#1362777 — [PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io port access static

These frequency register read/write operations' implementations for the
given processor (Intel/AMD MSR access or I/O port access) are only used
internally in acpi-cpufreq, so make them static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 drivers/cpufreq/acpi-cpufreq.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index 59a7b38..985be6e 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -245,7 +245,7 @@ static unsigned extract_freq(u32 val, struct acpi_cpufreq_data *data)
 	}
 }
 
-u32 cpu_freq_read_intel(struct acpi_pct_register *not_used)
+static u32 cpu_freq_read_intel(struct acpi_pct_register *not_used)
 {
 	u32 val, dummy;
 
@@ -253,7 +253,7 @@ u32 cpu_freq_read_intel(struct acpi_pct_register *not_used)
 	return val;
 }
 
-void cpu_freq_write_intel(struct acpi_pct_register *not_used, u32 val)
+static void cpu_freq_write_intel(struct acpi_pct_register *not_used, u32 val)
 {
 	u32 lo, hi;
 
@@ -262,7 +262,7 @@ void cpu_freq_write_intel(struct acpi_pct_register *not_used, u32 val)
 	wrmsr(MSR_IA32_PERF_CTL, lo, hi);
 }
 
-u32 cpu_freq_read_amd(struct acpi_pct_register *not_used)
+static u32 cpu_freq_read_amd(struct acpi_pct_register *not_used)
 {
 	u32 val, dummy;
 
@@ -270,12 +270,12 @@ u32 cpu_freq_read_amd(struct acpi_pct_register *not_used)
 	return val;
 }
 
-void cpu_freq_write_amd(struct acpi_pct_register *not_used, u32 val)
+static void cpu_freq_write_amd(struct acpi_pct_register *not_used, u32 val)
 {
 	wrmsr(MSR_AMD_PERF_CTL, val, 0);
 }
 
-u32 cpu_freq_read_io(struct acpi_pct_register *reg)
+static u32 cpu_freq_read_io(struct acpi_pct_register *reg)
 {
 	u32 val;
 
@@ -283,7 +283,7 @@ u32 cpu_freq_read_io(struct acpi_pct_register *reg)
 	return val;
 }
 
-void cpu_freq_write_io(struct acpi_pct_register *reg, u32 val)
+static void cpu_freq_write_io(struct acpi_pct_register *reg, u32 val)
 {
 	acpi_os_write_port(reg->address, val, reg->bit_width);
 }
-- 
2.8.0.rc3

[toc] | [next] | [standalone]

#1362788 — Re: [PATCH] cpufreq: acpi-cpufreq: make Intel/AMD MSR access, io port access static

On 22-03-16, 22:34, Jisheng Zhang wrote:
> These frequency register read/write operations' implementations for the
> given processor (Intel/AMD MSR access or I/O port access) are only used
> internally in acpi-cpufreq, so make them static.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

[toc] | [prev] | [next] | [standalone]

#1363721

On Tuesday, March 22, 2016 08:13:53 PM Viresh Kumar wrote:
> On 22-03-16, 22:34, Jisheng Zhang wrote:
> > These frequency register read/write operations' implementations for the
> > given processor (Intel/AMD MSR access or I/O port access) are only used
> > internally in acpi-cpufreq, so make them static.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > ---
> >  drivers/cpufreq/acpi-cpufreq.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web