Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1362279 > unrolled thread

Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per  line Greg KH <gregkh@linuxfoundation.org> - 2016-03-22 03:10 +0100

#1362279 — Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line

On Sat, Mar 12, 2016 at 04:01:03PM +0100, Adonis Settouf wrote:
> This patch fixes the checkpatch.pl warning regarding the exceeding 80
> characters on line 36. This patch add a newline after function statement
> on line 52

You did 2 different things in the same patch, that should be 2 patches.

> 
> Signed-off-by: Adonis Settouf <adonis.settouf@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 735a199..5cffc8f 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -30,8 +30,8 @@ enum dot11d_state {
>  };
>  
>  /**
> - * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
> - *		  valid country information element.
> + * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
> + * @CountryIeBuf contains valid country information element.

You forgot to indent like the rest of this comment block did :(

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web