Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1361313 > unrolled thread
| Started by | Parth Sane <laerdevstudios@gmail.com> |
|---|---|
| First post | 2016-03-20 17:00 +0100 |
| Last post | 2016-03-21 22:30 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 17:00 +0100
[PATCH 5/5] staging: rtl9712: Fixed FSF address warning in ieee80211.c Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 17:10 +0100
[PATCH 4/5] staging: rtl9712: Fixed FSF address warning in hal_init.c Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 17:10 +0100
Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings Roger H Newell <newell.roger@gmail.com> - 2016-03-20 18:40 +0100
Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 18:50 +0100
Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings Joshua Clayton <stillcompiling@gmail.com> - 2016-03-21 00:50 +0100
Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings Greg KH <gregkh@linuxfoundation.org> - 2016-03-21 22:30 +0100
| From | Parth Sane <laerdevstudios@gmail.com> |
|---|---|
| Date | 2016-03-20 17:00 +0100 |
| Subject | [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings |
| Message-ID | <reNVL-sU-3@gated-at.bofh.it> |
*** BLURB HERE *** Parth Sane (5): staging: rtl8712: Fixed FSF address warning in basic_types.h staging: rtl8712: Fixed FSF address warning in drv_types.h staging: rtl9712: Fixed FSF address warning in ethernet.h staging: rtl9712: Fixed FSF address warning in hal_init.c staging: rtl9712: Fixed FSF address warning in ieee80211.c drivers/staging/rtl8712/basic_types.h | 4 ---- drivers/staging/rtl8712/drv_types.h | 4 ---- drivers/staging/rtl8712/ethernet.h | 4 ---- drivers/staging/rtl8712/hal_init.c | 4 ---- drivers/staging/rtl8712/ieee80211.c | 4 ---- 5 files changed, 20 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Parth Sane <laerdevstudios@gmail.com> |
|---|---|
| Date | 2016-03-20 17:10 +0100 |
| Subject | [PATCH 5/5] staging: rtl9712: Fixed FSF address warning in ieee80211.c |
| Message-ID | <reO5s-Mq-19@gated-at.bofh.it> |
| In reply to | #1361313 |
Signed-off-by: Parth Sane <laerdevstudios@gmail.com> --- drivers/staging/rtl8712/ieee80211.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d13b4d5..8918654 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Parth Sane <laerdevstudios@gmail.com> |
|---|---|
| Date | 2016-03-20 17:10 +0100 |
| Subject | [PATCH 4/5] staging: rtl9712: Fixed FSF address warning in hal_init.c |
| Message-ID | <reO5t-Mq-29@gated-at.bofh.it> |
| In reply to | #1361313 |
Signed-off-by: Parth Sane <laerdevstudios@gmail.com> --- drivers/staging/rtl8712/hal_init.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 17d2b5f..afa7fe78 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Roger H Newell <newell.roger@gmail.com> |
|---|---|
| Date | 2016-03-20 18:40 +0100 |
| Subject | Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings |
| Message-ID | <rePuy-1CQ-19@gated-at.bofh.it> |
| In reply to | #1361313 |
On Sun, Mar 20, 2016 at 1:28 PM, Parth Sane <laerdevstudios@gmail.com> wrote: > *** BLURB HERE *** > > Parth Sane (5): > staging: rtl8712: Fixed FSF address warning in basic_types.h > staging: rtl8712: Fixed FSF address warning in drv_types.h > staging: rtl9712: Fixed FSF address warning in ethernet.h > staging: rtl9712: Fixed FSF address warning in hal_init.c > staging: rtl9712: Fixed FSF address warning in ieee80211.c > > drivers/staging/rtl8712/basic_types.h | 4 ---- > drivers/staging/rtl8712/drv_types.h | 4 ---- > drivers/staging/rtl8712/ethernet.h | 4 ---- > drivers/staging/rtl8712/hal_init.c | 4 ---- > drivers/staging/rtl8712/ieee80211.c | 4 ---- > 5 files changed, 20 deletions(-) > > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel It looks like all the patches in this set do not contain a commit log in the body. It's up to the maintainer but I'm fairly certain they won't be accepted without a body. On Sun, Mar 20, 2016 at 1:32 PM, Parth Sane <laerdevstudios@gmail.com> wrote: > Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style. > > Parth Sane (5): > staging: rtl8712: Fixed FSF address warning in basic_types.h > staging: rtl8712: Fixed FSF address warning in drv_types.h > staging: rtl9712: Fixed FSF address warning in ethernet.h > staging: rtl9712: Fixed FSF address warning in hal_init.c > staging: rtl9712: Fixed FSF address warning in ieee80211.c > > drivers/staging/rtl8712/basic_types.h | 4 ---- > drivers/staging/rtl8712/drv_types.h | 4 ---- > drivers/staging/rtl8712/ethernet.h | 4 ---- > drivers/staging/rtl8712/hal_init.c | 4 ---- > drivers/staging/rtl8712/ieee80211.c | 4 ---- > 5 files changed, 20 deletions(-) > > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[toc] | [prev] | [next] | [standalone]
| From | Parth Sane <laerdevstudios@gmail.com> |
|---|---|
| Date | 2016-03-20 18:50 +0100 |
| Message-ID | <rePEf-1Gu-23@gated-at.bofh.it> |
| In reply to | #1361333 |
[Multipart message — attachments visible in raw view] — view raw
> Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style. > > Parth Sane (5): > staging: rtl8712: Fixed FSF address warning in basic_types.h > staging: rtl8712: Fixed FSF address warning in drv_types.h > staging: rtl9712: Fixed FSF address warning in ethernet.h > staging: rtl9712: Fixed FSF address warning in hal_init.c > staging: rtl9712: Fixed FSF address warning in ieee80211.c > > drivers/staging/rtl8712/basic_types.h | 4 ---- > drivers/staging/rtl8712/drv_types.h | 4 ---- > drivers/staging/rtl8712/ethernet.h | 4 ---- > drivers/staging/rtl8712/hal_init.c | 4 ---- > drivers/staging/rtl8712/ieee80211.c | 4 ---- > 5 files changed, 20 deletions(-) > > -- > 1.9.1 Hi, The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory. This should possibly suffice. What do you think? Regards, Parth Sane
[toc] | [prev] | [next] | [standalone]
| From | Joshua Clayton <stillcompiling@gmail.com> |
|---|---|
| Date | 2016-03-21 00:50 +0100 |
| Message-ID | <reVgC-5Hg-3@gated-at.bofh.it> |
| In reply to | #1361337 |
On Sunday, March 20, 2016 11:12:32 PM Parth Sane wrote: > > Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style. > > > > Parth Sane (5): > > staging: rtl8712: Fixed FSF address warning in basic_types.h > > staging: rtl8712: Fixed FSF address warning in drv_types.h > > staging: rtl9712: Fixed FSF address warning in ethernet.h > > staging: rtl9712: Fixed FSF address warning in hal_init.c > > staging: rtl9712: Fixed FSF address warning in ieee80211.c > > > > drivers/staging/rtl8712/basic_types.h | 4 ---- > > drivers/staging/rtl8712/drv_types.h | 4 ---- > > drivers/staging/rtl8712/ethernet.h | 4 ---- > > drivers/staging/rtl8712/hal_init.c | 4 ---- > > drivers/staging/rtl8712/ieee80211.c | 4 ---- > > 5 files changed, 20 deletions(-) > > > > -- > > 1.9.1 > Hi, > The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory. > This should possibly suffice. What do you think? > Regards, > Parth Sane The cover letter does not end up in the repository. A cover letter can be helpful, but is not required. You MUST, however add a descriptive commit message to each patch for them to be accepted into the kernel. See Documentation/SubmittingPatches in the kernel sources.
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-03-21 22:30 +0100 |
| Subject | Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings |
| Message-ID | <rffyH-2WC-31@gated-at.bofh.it> |
| In reply to | #1361313 |
On Sun, Mar 20, 2016 at 03:59:09PM +0000, Parth Sane wrote: > *** BLURB HERE *** You forgot to fill this out :( > > Parth Sane (5): > staging: rtl8712: Fixed FSF address warning in basic_types.h > staging: rtl8712: Fixed FSF address warning in drv_types.h > staging: rtl9712: Fixed FSF address warning in ethernet.h > staging: rtl9712: Fixed FSF address warning in hal_init.c > staging: rtl9712: Fixed FSF address warning in ieee80211.c Your subject lines are refering to an unknown driver :(
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web