Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363062 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-03-22 23:50 +0100 |
| Last post | 2016-04-02 14:50 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] gma500: fix missing comma in dsi_errors array initializer Colin King <colin.king@canonical.com> - 2016-03-22 23:50 +0100
Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer Joe Perches <joe@perches.com> - 2016-03-23 00:50 +0100
Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-23 02:30 +0100
Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer Patrik Jakobsson <patrik.r.jakobsson@gmail.com> - 2016-04-02 14:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-03-22 23:50 +0100 |
| Subject | [PATCH] gma500: fix missing comma in dsi_errors array initializer |
| Message-ID | <rfDhE-2E4-7@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
There is a missing comma between two strings in the dsi_errors[]
array initializer, causing two strings to be concatenated and the
array being incorrectly initialized. Add in the missing comma.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
index 6b43ae3..1616af2 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
@@ -72,7 +72,7 @@ static const char *const dsi_errors[] = {
"RX Prot Violation",
"HS Generic Write FIFO Full",
"LP Generic Write FIFO Full",
- "Generic Read Data Avail"
+ "Generic Read Data Avail",
"Special Packet Sent",
"Tearing Effect",
};
--
2.7.3
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-23 00:50 +0100 |
| Subject | Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer |
| Message-ID | <rfEdI-3eJ-1@gated-at.bofh.it> |
| In reply to | #1363062 |
On Tue, 2016-03-22 at 22:49 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing comma between two strings in the dsi_errors[]
> array initializer, causing two strings to be concatenated and the
> array being incorrectly initialized. Add in the missing comma.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 6b43ae3..1616af2 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -72,7 +72,7 @@ static const char *const dsi_errors[] = {
> "RX Prot Violation",
> "HS Generic Write FIFO Full",
> "LP Generic Write FIFO Full",
> - "Generic Read Data Avail"
> + "Generic Read Data Avail",
> "Special Packet Sent",
> "Tearing Effect",
> };
From 2011:
https://lkml.org/lkml/2011/7/8/197
and
commit fc5ace7ed2a58e32047abf65ff8b5a6432e92fac
Author: Dan Carpenter <error27@gmail.com>
Date: Fri Jul 8 09:45:19 2011 +0100
Staging: gma500: typo in array initialization
There is a comma missing here between the strings so they were
concatenated by mistake.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Apparently this wasn't merged back into this version.
Are there any other changes in that old staging version that
also need to be merged back?
[toc] | [prev] | [next] | [standalone]
| From | One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> |
|---|---|
| Date | 2016-03-23 02:30 +0100 |
| Subject | Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer |
| Message-ID | <rfFMu-4q1-7@gated-at.bofh.it> |
| In reply to | #1363130 |
On Tue, 22 Mar 2016 16:40:18 -0700 Joe Perches <joe@perches.com> wrote: > On Tue, 2016-03-22 at 22:49 +0000, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > There is a missing comma between two strings in the dsi_errors[] > > array initializer, causing two strings to be concatenated and the > > array being incorrectly initialized. Add in the missing comma. I sent that a while ago, and there's also a patch to remove bogus code from mdfld_dsi_dpi.c outstanding somewhere Alan
[toc] | [prev] | [next] | [standalone]
| From | Patrik Jakobsson <patrik.r.jakobsson@gmail.com> |
|---|---|
| Date | 2016-04-02 14:50 +0200 |
| Message-ID | <rjta2-3KA-9@gated-at.bofh.it> |
| In reply to | #1363150 |
On Wed, Mar 23, 2016 at 2:28 AM, One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote: > On Tue, 22 Mar 2016 16:40:18 -0700 > Joe Perches <joe@perches.com> wrote: > >> On Tue, 2016-03-22 at 22:49 +0000, Colin King wrote: >> > From: Colin Ian King <colin.king@canonical.com> >> > >> > There is a missing comma between two strings in the dsi_errors[] >> > array initializer, causing two strings to be concatenated and the >> > array being incorrectly initialized. Add in the missing comma. > > I sent that a while ago, and there's also a patch to remove bogus code > from mdfld_dsi_dpi.c outstanding somewhere I have a version of the missing comma fix that I'll send out with -fixes soon. I should have done that a couple of months ago. Which patch is the mdffld_dsi_dpi cleanup? I can't find anything related to that. -Patrik > > > Alan >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web