Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363078 > unrolled thread

[PATCH] x86, msr, remove unused native_read_tscp()

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86, msr, remove unused native_read_tscp() Prarit Bhargava <prarit@redhat.com> - 2016-03-23 00:10 +0100
    Re: [PATCH] x86, msr, remove unused native_read_tscp() Andy Lutomirski <luto@amacapital.net> - 2016-03-23 00:20 +0100
    [tip:x86/urgent] x86/msr: Remove unused native_read_tscp() tip-bot for Prarit Bhargava <tipbot@zytor.com> - 2016-03-23 12:50 +0100

#1363078 — [PATCH] x86, msr, remove unused native_read_tscp()

After e76b027 ("x86,vdso: Use LSL unconditionally for vgetcpu")
native_read_tscp() is unused in the kernel.  The function can be removed
like native_read_tsc() was.

[prarit@prarit linux]$ git grep native_read_tscp
arch/x86/include/asm/msr.h:45:static inline unsigned long long native_read_tscp(unsigned int *aux)

Cc: x86@kernel.org
Cc: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
 arch/x86/include/asm/msr.h |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index 93fb7c1..7a79ee2 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -42,14 +42,6 @@ struct saved_msrs {
 	struct saved_msr *array;
 };
 
-static inline unsigned long long native_read_tscp(unsigned int *aux)
-{
-	unsigned long low, high;
-	asm volatile(".byte 0x0f,0x01,0xf9"
-		     : "=a" (low), "=d" (high), "=c" (*aux));
-	return low | ((u64)high << 32);
-}
-
 /*
  * both i386 and x86_64 returns 64-bit value in edx:eax, but gcc's "A"
  * constraint has different meanings. For i386, "A" means exactly
-- 
1.7.9.3

[toc] | [next] | [standalone]

#1363114

On Tue, Mar 22, 2016 at 4:06 PM, Prarit Bhargava <prarit@redhat.com> wrote:
> After e76b027 ("x86,vdso: Use LSL unconditionally for vgetcpu")
> native_read_tscp() is unused in the kernel.  The function can be removed
> like native_read_tsc() was.

Fine with me.  We can always re-add it if we need it in the future.

--Andy

[toc] | [prev] | [next] | [standalone]

#1363366 — [tip:x86/urgent] x86/msr: Remove unused native_read_tscp()

Commit-ID:  9da77666d6975219281fd400eb9608a047337414
Gitweb:     http://git.kernel.org/tip/9da77666d6975219281fd400eb9608a047337414
Author:     Prarit Bhargava <prarit@redhat.com>
AuthorDate: Tue, 22 Mar 2016 19:06:08 -0400
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 23 Mar 2016 12:34:17 +0100

x86/msr: Remove unused native_read_tscp()

After e76b027 ("x86,vdso: Use LSL unconditionally for vgetcpu")
native_read_tscp() is unused in the kernel. The function can be removed like
native_read_tsc() was.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Acked-by: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/1458687968-9106-1-git-send-email-prarit@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/include/asm/msr.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index 93fb7c1..7a79ee2 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -42,14 +42,6 @@ struct saved_msrs {
 	struct saved_msr *array;
 };
 
-static inline unsigned long long native_read_tscp(unsigned int *aux)
-{
-	unsigned long low, high;
-	asm volatile(".byte 0x0f,0x01,0xf9"
-		     : "=a" (low), "=d" (high), "=c" (*aux));
-	return low | ((u64)high << 32);
-}
-
 /*
  * both i386 and x86_64 returns 64-bit value in edx:eax, but gcc's "A"
  * constraint has different meanings. For i386, "A" means exactly

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web