Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1360999 > unrolled thread

[PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

Started byAndreas Dannenberg <dannenberg@ti.com>
First post2016-03-19 00:30 +0100
Last post2016-03-21 15:10 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Andreas Dannenberg <dannenberg@ti.com> - 2016-03-19 00:30 +0100
    Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Rob Herring <robh@kernel.org> - 2016-03-21 13:50 +0100
      Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Andreas Dannenberg <dannenberg@ti.com> - 2016-03-21 15:10 +0100

#1360999 — [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

FromAndreas Dannenberg <dannenberg@ti.com>
Date2016-03-19 00:30 +0100
Subject[PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Message-ID<rec0a-3uD-5@gated-at.bofh.it>
The Texas Instruments TAS5720L/M device is a high-efficiency mono
Class-D audio power amplifier optimized for high transient power
capability to use the dynamic power headroom of small loudspeakers.
Its digital time division multiplexed (TDM) interface enables up to
16 devices to share the same bus.

Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
 .../devicetree/bindings/sound/tas5720.txt          | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt

diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b/Documentation/devicetree/bindings/sound/tas5720.txt
new file mode 100644
index 0000000..3775a3f
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/tas5720.txt
@@ -0,0 +1,37 @@
+Texas Instruments TAS5720 Mono Audio amplifier
+
+The TAS5720 serial control bus communicates through the I2C protocol only.
+
+Required properties:
+
+- compatible : "ti,tas5720"
+- reg : I2C slave address
+
+Optional properties:
+
+- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
+- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
+- interrupts-extended : reference to a GPIO pin connected to the TAS5720
+                        FAULTZ pin for error reporting purposes
+
+Note that in case of codec errors the driver relies on the TAS5720 datasheet-
+proposed "Auto Recovery Circuit" (connection between the FAULTZ and SDZ device
+pins) for continued operation. This connection should always be made independent
+of whether the optional interrupt-based fault-reporting feature is used.
+
+For more product information please see the links below:
+
+http://www.ti.com/product/TAS5720L
+http://www.ti.com/product/TAS5720M
+
+Example:
+
+tas5720: tas5720@6c {
+	status = "okay";
+	compatible = "ti,tas5720";
+	reg = <0x6c>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&tas572x_int_pin>;
+	interrupts-extended = <&gpio1 28 IRQ_TYPE_EDGE_FALLING>;
+};
-- 
2.6.4

[toc] | [next] | [standalone]


#1361798 — Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

FromRob Herring <robh@kernel.org>
Date2016-03-21 13:50 +0100
SubjectRe: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Message-ID<rf7rs-5J5-17@gated-at.bofh.it>
In reply to#1360999
On Fri, Mar 18, 2016 at 06:27:57PM -0500, Andreas Dannenberg wrote:
> The Texas Instruments TAS5720L/M device is a high-efficiency mono
> Class-D audio power amplifier optimized for high transient power
> capability to use the dynamic power headroom of small loudspeakers.
> Its digital time division multiplexed (TDM) interface enables up to
> 16 devices to share the same bus.
> 
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
>  .../devicetree/bindings/sound/tas5720.txt          | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b/Documentation/devicetree/bindings/sound/tas5720.txt
> new file mode 100644
> index 0000000..3775a3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas5720.txt
> @@ -0,0 +1,37 @@
> +Texas Instruments TAS5720 Mono Audio amplifier
> +
> +The TAS5720 serial control bus communicates through the I2C protocol only.
> +
> +Required properties:
> +
> +- compatible : "ti,tas5720"
> +- reg : I2C slave address
> +
> +Optional properties:
> +
> +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> +                        FAULTZ pin for error reporting purposes

There's no point in having interrupts-extended here with a single 
interrupt. It is fine to use, but really that's outside the scope of 
this binding. So I'd just document "interrupts" here as that is what 
most docs do, and that implies interrupts-extended could be used.

Rob

[toc] | [prev] | [next] | [standalone]


#1361871 — Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

FromAndreas Dannenberg <dannenberg@ti.com>
Date2016-03-21 15:10 +0100
SubjectRe: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Message-ID<rf8GT-6NS-9@gated-at.bofh.it>
In reply to#1361798
On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote:
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> > +                        FAULTZ pin for error reporting purposes
> 
> There's no point in having interrupts-extended here with a single 
> interrupt. It is fine to use, but really that's outside the scope of 
> this binding. So I'd just document "interrupts" here as that is what 
> most docs do, and that implies interrupts-extended could be used.

Hi Rob,
Good point. Will remove it for v2.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web