Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1361750 > unrolled thread

[PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition

Started by"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
First post2016-03-21 13:10 +0100
Last post2016-03-21 14:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-03-21 13:10 +0100
    Re: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release}  definition Michal Hocko <mhocko@kernel.org> - 2016-03-21 14:00 +0100

#1361750 — [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition

From"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date2016-03-21 13:10 +0100
Subject[PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition
Message-ID<rf6OK-5pB-5@gated-at.bofh.it>
All users gone. We can remove these macros.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 include/linux/pagemap.h | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index b3fc0370c14f..7e1ab155c67c 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -86,21 +86,6 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask)
 				(__force unsigned long)mask;
 }
 
-/*
- * The page cache can be done in larger chunks than
- * one page, because it allows for more efficient
- * throughput (it can then be mapped into user
- * space in smaller chunks for same flexibility).
- *
- * Or rather, it _will_ be done in larger chunks.
- */
-#define PAGE_CACHE_SHIFT	PAGE_SHIFT
-#define PAGE_CACHE_SIZE		PAGE_SIZE
-#define PAGE_CACHE_MASK		PAGE_MASK
-#define PAGE_CACHE_ALIGN(addr)	(((addr)+PAGE_CACHE_SIZE-1)&PAGE_CACHE_MASK)
-
-#define page_cache_get(page)		get_page(page)
-#define page_cache_release(page)	put_page(page)
 void release_pages(struct page **pages, int nr, bool cold);
 
 /*
-- 
2.7.0

[toc] | [next] | [standalone]


#1361809 — Re: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition

FromMichal Hocko <mhocko@kernel.org>
Date2016-03-21 14:00 +0100
SubjectRe: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition
Message-ID<rf7B8-5Mj-13@gated-at.bofh.it>
In reply to#1361750
On Mon 21-03-16 15:06:38, Kirill A. Shutemov wrote:
> All users gone. We can remove these macros.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

\o/

Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

> ---
>  include/linux/pagemap.h | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index b3fc0370c14f..7e1ab155c67c 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -86,21 +86,6 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask)
>  				(__force unsigned long)mask;
>  }
>  
> -/*
> - * The page cache can be done in larger chunks than
> - * one page, because it allows for more efficient
> - * throughput (it can then be mapped into user
> - * space in smaller chunks for same flexibility).
> - *
> - * Or rather, it _will_ be done in larger chunks.
> - */
> -#define PAGE_CACHE_SHIFT	PAGE_SHIFT
> -#define PAGE_CACHE_SIZE		PAGE_SIZE
> -#define PAGE_CACHE_MASK		PAGE_MASK
> -#define PAGE_CACHE_ALIGN(addr)	(((addr)+PAGE_CACHE_SIZE-1)&PAGE_CACHE_MASK)
> -
> -#define page_cache_get(page)		get_page(page)
> -#define page_cache_release(page)	put_page(page)
>  void release_pages(struct page **pages, int nr, bool cold);
>  
>  /*
> -- 
> 2.7.0

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web