Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361779 > unrolled thread

[PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers/media/media-devnode: add missing mutex lock in  error handler Max Kellermann <max@duempel.org> - 2016-03-21 13:30 +0100

#1361779 — [PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

All accesses to media_devnode_nums must be protected with
media_devnode_lock.  The error code path in media_devnode_register()
did not do this, however.

Signed-off-by: Max Kellermann <max@duempel.org>
---
 drivers/media/media-devnode.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c
index cea35bf..4d7e8dd 100644
--- a/drivers/media/media-devnode.c
+++ b/drivers/media/media-devnode.c
@@ -266,8 +266,11 @@ int __must_check media_devnode_register(struct media_devnode *mdev,
 	return 0;
 
 error:
+	mutex_lock(&media_devnode_lock);
 	cdev_del(&mdev->cdev);
 	clear_bit(mdev->minor, media_devnode_nums);
+	mutex_unlock(&media_devnode_lock);
+
 	return ret;
 }
 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web