Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1361413 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-03-20 20:00 +0100 |
| Last post | 2016-03-21 13:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: da9063: remove unused array mask_events_buf Colin King <colin.king@canonical.com> - 2016-03-20 20:00 +0100
RE: [PATCH] mfd: da9063: remove unused array mask_events_buf "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> - 2016-03-21 12:00 +0100
Re: [PATCH] mfd: da9063: remove unused array mask_events_buf Lee Jones <lee.jones@linaro.org> - 2016-03-21 13:00 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-03-20 20:00 +0100 |
| Subject | [PATCH] mfd: da9063: remove unused array mask_events_buf |
| Message-ID | <reQK1-2nU-101@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
mask_events_buf is not used, so remove this redundant array.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/da9063-irq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
index 2630263..0aa760e 100644
--- a/drivers/mfd/da9063-irq.c
+++ b/drivers/mfd/da9063-irq.c
@@ -27,8 +27,6 @@
#define DA9063_REG_EVENT_D_OFFSET 3
#define EVENTS_BUF_LEN 4
-static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
-
struct da9063_irq_data {
u16 reg;
u8 mask;
--
2.7.3
[toc] | [next] | [standalone]
| From | "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> |
|---|---|
| Date | 2016-03-21 12:00 +0100 |
| Message-ID | <rf5J0-4pj-15@gated-at.bofh.it> |
| In reply to | #1361413 |
On 20 March 2016 18:54 Colin King wrote:
> Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf
> From: Colin Ian King <colin.king@canonical.com>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4
I guess EVENTS_BUF_LEN can go as well.
If this is not added, I will send a patch later.
Regards,
Steve
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;
> --
> 2.7.3
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-03-21 13:00 +0100 |
| Message-ID | <rf6F5-52Q-23@gated-at.bofh.it> |
| In reply to | #1361413 |
On Sun, 20 Mar 2016, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)
I've amended the $SUBJECT line to conform to the subsystem style.
Patch applied, thanks.
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4
>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web