Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361577 > unrolled thread

[PATCH] mwifiex: advertise low priority scan feature

Started byWei-Ning Huang <wnhuang@chromium.org>
First post2016-03-21 09:10 +0100
Last post2016-03-29 13:00 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mwifiex: advertise low priority scan feature Wei-Ning Huang <wnhuang@chromium.org> - 2016-03-21 09:10 +0100
    Re: [PATCH] mwifiex: advertise low priority scan feature Wei-Ning Huang <wnhuang@google.com> - 2016-03-21 09:20 +0100
    RE: [PATCH] mwifiex: advertise low priority scan feature Amitkumar Karwar <akarwar@marvell.com> - 2016-03-21 09:30 +0100
    Re: [PATCH] mwifiex: advertise low priority scan feature Kalle Valo <kvalo@codeaurora.org> - 2016-03-21 11:30 +0100
      Re: [PATCH] mwifiex: advertise low priority scan feature Wei-Ning Huang <wnhuang@google.com> - 2016-03-22 05:20 +0100
        Re: [PATCH] mwifiex: advertise low priority scan feature Wei-Ning Huang <wnhuang@google.com> - 2016-03-29 13:00 +0200

#1361577 — [PATCH] mwifiex: advertise low priority scan feature

FromWei-Ning Huang <wnhuang@chromium.org>
Date2016-03-21 09:10 +0100
Subject[PATCH] mwifiex: advertise low priority scan feature
Message-ID<rf34v-2NK-29@gated-at.bofh.it>
From: Amitkumar Karwar <akarwar@marvell.com>

Low priority scan handling code which delays or aborts scan
operation based on Tx traffic is removed recently. The reason
is firmware already takes care of it in our new feature scan
channel gap. Hence we should advertise low priority scan
support to cfg80211.

This patch fixes a problem in which OBSS scan request from
wpa_supplicant was being rejected by cfg80211.

Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index bb7235e..7dafc5b 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
 
 	wiphy->features |= NL80211_FEATURE_HT_IBSS |
 			   NL80211_FEATURE_INACTIVITY_TIMER |
+			   NL80211_FEATURE_LOW_PRIORITY_SCAN |
 			   NL80211_FEATURE_NEED_OBSS_SCAN;
 
 	if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
-- 
2.8.0.rc3.226.g39d4020

[toc] | [next] | [standalone]

#1361583

FromWei-Ning Huang <wnhuang@google.com>
Date2016-03-21 09:20 +0100
Message-ID<rf3ea-2Ra-11@gated-at.bofh.it>
In reply to#1361577
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>

On Mon, Mar 21, 2016 at 4:07 PM, Wei-Ning Huang <wnhuang@chromium.org> wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index bb7235e..7dafc5b 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
>
>         wiphy->features |= NL80211_FEATURE_HT_IBSS |
>                            NL80211_FEATURE_INACTIVITY_TIMER |
> +                          NL80211_FEATURE_LOW_PRIORITY_SCAN |
>                            NL80211_FEATURE_NEED_OBSS_SCAN;
>
>         if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
> --
> 2.8.0.rc3.226.g39d4020
>



-- 
Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan |
wnhuang@google.com | Cell: +886 910-380678

[toc] | [prev] | [next] | [standalone]

#1361598

FromAmitkumar Karwar <akarwar@marvell.com>
Date2016-03-21 09:30 +0100
Message-ID<rf3nQ-2Wt-11@gated-at.bofh.it>
In reply to#1361577
> From: linux-wireless-owner@vger.kernel.org [mailto:linux-wireless-
> owner@vger.kernel.org] On Behalf Of Wei-Ning Huang
> Sent: Monday, March 21, 2016 1:37 PM
> To: Linux Wireless
> Cc: LKML; Amitkumar Karwar; djkurtz@chromium.org; Wei-Ning Huang;
> Nishant Sarmukadam; kvalo@codeaurora.org; netdev@vger.kernel.org
> Subject: [PATCH] mwifiex: advertise low priority scan feature
> 
> From: Amitkumar Karwar <akarwar@marvell.com>
> 
> Low priority scan handling code which delays or aborts scan operation
> based on Tx traffic is removed recently. The reason is firmware already
> takes care of it in our new feature scan channel gap. Hence we should
> advertise low priority scan support to cfg80211.
> 
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
> 
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index bb7235e..7dafc5b 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct
> mwifiex_adapter *adapter)
> 
>  	wiphy->features |= NL80211_FEATURE_HT_IBSS |
>  			   NL80211_FEATURE_INACTIVITY_TIMER |
> +			   NL80211_FEATURE_LOW_PRIORITY_SCAN |
>  			   NL80211_FEATURE_NEED_OBSS_SCAN;
> 
>  	if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))

Acked-by: Amitkumar Karwar <akarwar@marvell.com>

Regards,
Amitkumar

[toc] | [prev] | [next] | [standalone]

#1361677

FromKalle Valo <kvalo@codeaurora.org>
Date2016-03-21 11:30 +0100
Message-ID<rf5fY-4c5-7@gated-at.bofh.it>
In reply to#1361577
Wei-Ning Huang <wnhuang@chromium.org> writes:

> From: Amitkumar Karwar <akarwar@marvell.com>
>
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>

The From line states that this is written by Amitkumar but there's no
Signed-off-By line from him. I can't take this without that, please
resend.

(Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.)

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1362323

FromWei-Ning Huang <wnhuang@google.com>
Date2016-03-22 05:20 +0100
Message-ID<rflXr-7A0-5@gated-at.bofh.it>
In reply to#1361677
Hi Kalle,

Thanks for the review. I accidentally removed the s-o-b line from
akarwar in this version.
The original patch can be found at:
https://chromium-review.googlesource.com/#/c/246052/
I've resent a new one.

Wei-Ning

On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Wei-Ning Huang <wnhuang@chromium.org> writes:
>
>> From: Amitkumar Karwar <akarwar@marvell.com>
>>
>> Low priority scan handling code which delays or aborts scan
>> operation based on Tx traffic is removed recently. The reason
>> is firmware already takes care of it in our new feature scan
>> channel gap. Hence we should advertise low priority scan
>> support to cfg80211.
>>
>> This patch fixes a problem in which OBSS scan request from
>> wpa_supplicant was being rejected by cfg80211.
>>
>> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
>
> The From line states that this is written by Amitkumar but there's no
> Signed-off-By line from him. I can't take this without that, please
> resend.
>
> (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.)
>
> --
> Kalle Valo



-- 
Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan |
wnhuang@google.com | Cell: +886 910-380678

[toc] | [prev] | [next] | [standalone]

#1366154

FromWei-Ning Huang <wnhuang@google.com>
Date2016-03-29 13:00 +0200
Message-ID<rhZxo-4TD-11@gated-at.bofh.it>
In reply to#1362323
I've resent the patch here: https://patchwork.kernel.org/patch/8637861/
Thanks!

Wei-Ning

On Tue, Mar 22, 2016 at 12:12 PM, Wei-Ning Huang <wnhuang@google.com> wrote:
> Hi Kalle,
>
> Thanks for the review. I accidentally removed the s-o-b line from
> akarwar in this version.
> The original patch can be found at:
> https://chromium-review.googlesource.com/#/c/246052/
> I've resent a new one.
>
> Wei-Ning
>
> On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Wei-Ning Huang <wnhuang@chromium.org> writes:
>>
>>> From: Amitkumar Karwar <akarwar@marvell.com>
>>>
>>> Low priority scan handling code which delays or aborts scan
>>> operation based on Tx traffic is removed recently. The reason
>>> is firmware already takes care of it in our new feature scan
>>> channel gap. Hence we should advertise low priority scan
>>> support to cfg80211.
>>>
>>> This patch fixes a problem in which OBSS scan request from
>>> wpa_supplicant was being rejected by cfg80211.
>>>
>>> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
>>
>> The From line states that this is written by Amitkumar but there's no
>> Signed-off-By line from him. I can't take this without that, please
>> resend.
>>
>> (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.)
>>
>> --
>> Kalle Valo
>
>
>
> --
> Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan |
> wnhuang@google.com | Cell: +886 910-380678



-- 
Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan |
wnhuang@google.com | Cell: +886 910-380678

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web