Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361112 > unrolled thread

drivers/gpu/drm/nouveau/nouveau_connector.c:60:5: sparse: symbol 'nouveau_hdmimhz' was not declared. Should it be static?

Back to article view | Back to linux.kernel

Contents

  drivers/gpu/drm/nouveau/nouveau_connector.c:60:5: sparse: symbol  'nouveau_hdmimhz' was not declared. Should it be static? kbuild test robot <fengguang.wu@intel.com> - 2016-03-19 15:20 +0100
    [RFC PATCH linus] drm/nouveau/kms: nouveau_hdmimhz can be static kbuild test robot <fengguang.wu@intel.com> - 2016-03-19 15:20 +0100

#1361112 — drivers/gpu/drm/nouveau/nouveau_connector.c:60:5: sparse: symbol 'nouveau_hdmimhz' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6b5f04b6cf8ebab9a65d9c0026c650bb2538fd0f
commit: 1a0c96c075bb4517d4ce4fb6750ee0a3cf38714c drm/nouveau/kms: allow 225/297MHz pixel clocks for HDMI on Fermi/Kepler
date:   10 weeks ago
reproduce:
        # apt-get install sparse
        git checkout 1a0c96c075bb4517d4ce4fb6750ee0a3cf38714c
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/nouveau/nouveau_connector.c:60:5: sparse: symbol 'nouveau_hdmimhz' was not declared. Should it be static?
   drivers/gpu/drm/nouveau/nouveau_connector.c:1081:29: sparse: cast to restricted __le16
   drivers/gpu/drm/nouveau/nouveau_connector.c:1083:39: sparse: cast to restricted __le16

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1361114 — [RFC PATCH linus] drm/nouveau/kms: nouveau_hdmimhz can be static

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 nouveau_connector.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index ae96ebc..b845482 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -60,7 +60,7 @@ int nouveau_duallink = 1;
 module_param_named(duallink, nouveau_duallink, int, 0400);
 
 MODULE_PARM_DESC(hdmimhz, "Force a maximum HDMI pixel clock (in MHz)");
-int nouveau_hdmimhz = 0;
+static int nouveau_hdmimhz = 0;
 module_param_named(hdmimhz, nouveau_hdmimhz, int, 0400);
 
 struct nouveau_encoder *

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web