Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361055 > unrolled thread

Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Heiko Stuebner <heiko@sntech.de> - 2016-03-19 09:10 +0100
    Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Heiko Stuebner <heiko@sntech.de> - 2016-03-31 19:20 +0200
      Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Heiko Stuebner <heiko@sntech.de> - 2016-03-31 22:50 +0200

#1361055 — Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes

Am Mittwoch, 16. März 2016, 14:58:39 schrieb Andreas Färber:
> A dtc update results in warnings for nodes with reg property but without
> unit address in the node name, so rename /memory to /memory@0.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

applied to a dts64-fixes branch for 4.6, after changing the commit message to
----
A dtc update results in warnings for nodes with reg property but without
unit address in the node name, so rename /memory to /memory@startaddress
(memory starts at 0 in the case of the rk3368).
----

To clarify that the @0 is not arbitary chosen.


Heiko

[toc] | [next] | [standalone]

#1368460

Am Samstag, 19. März 2016, 09:04:08 schrieb Heiko Stuebner:
> Am Mittwoch, 16. März 2016, 14:58:39 schrieb Andreas Färber:
> > A dtc update results in warnings for nodes with reg property but without
> > unit address in the node name, so rename /memory to /memory@0.
> > 
> > Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> applied to a dts64-fixes branch for 4.6, after changing the commit message
> to ----
> A dtc update results in warnings for nodes with reg property but without
> unit address in the node name, so rename /memory to /memory@startaddress
> (memory starts at 0 in the case of the rk3368).
> ----
> 
> To clarify that the @0 is not arbitary chosen.

This dtc update in question hasn't landed in v4.6-rc1 and from what I 
gathered will need some changes. The patch is obviously still correct, but I 
have now moved it from v4.6-fixes to the regular v4.7 64bit dts changes.


Heiko

[toc] | [prev] | [next] | [standalone]

#1368702

Am Donnerstag, 31. März 2016, 19:15:43 schrieb Heiko Stuebner:
> Am Samstag, 19. März 2016, 09:04:08 schrieb Heiko Stuebner:
> > Am Mittwoch, 16. März 2016, 14:58:39 schrieb Andreas Färber:
> > > A dtc update results in warnings for nodes with reg property but
> > > without
> > > unit address in the node name, so rename /memory to /memory@0.
> > > 
> > > Signed-off-by: Andreas Färber <afaerber@suse.de>
> > 
> > applied to a dts64-fixes branch for 4.6, after changing the commit
> > message to ----
> > A dtc update results in warnings for nodes with reg property but without
> > unit address in the node name, so rename /memory to /memory@startaddress
> > (memory starts at 0 in the case of the rk3368).
> > ----
> > 
> > To clarify that the @0 is not arbitary chosen.
> 
> This dtc update in question hasn't landed in v4.6-rc1 and from what I
> gathered will need some changes. The patch is obviously still correct, but
> I have now moved it from v4.6-fixes to the regular v4.7 64bit dts
> changes.

also it seems "memory" is special and memory without unitname will stay 
allowed [0], especially as uboot or other bootloaders may expect such a node 
to insert the actual amount of memory into it.

Looking at uboot, fdt_fixup_memory_banks seems to look explicitly for a 
"memory" node, so I'm actually not sure, if this is safe to keep at all.


[0] http://www.spinics.net/lists/arm-kernel/msg494038.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web