Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1358794 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2016-03-16 11:20 +0100 |
| Last post | 2016-03-16 13:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-16 11:20 +0100
Re: [PATCH v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Lee Jones <lee.jones@linaro.org> - 2016-03-16 13:00 +0100
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-03-16 11:20 +0100 |
| Subject | [PATCH v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM |
| Message-ID | <rdgIy-7B0-13@gated-at.bofh.it> |
The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet direct dependencies. This fixes warning on allyesconfig on ARCH=um: warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- Changes since v1: 1. Remove the comment why HAS_IOMEM dependency was added. 2. Exdended description. --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index a9727dab9e72..8ad8f91a72e1 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3 config PHY_HI6220_USB tristate "hi6220 USB PHY support" depends on (ARCH_HISI && ARM64) || COMPILE_TEST + depends on HAS_IOMEM select GENERIC_PHY select MFD_SYSCON help -- 2.5.0
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-03-16 13:00 +0100 |
| Subject | Re: [PATCH v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM |
| Message-ID | <rdihj-8te-9@gated-at.bofh.it> |
| In reply to | #1358794 |
On Wed, 16 Mar 2016, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > This fixes warning on allyesconfig on ARCH=um: > > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && > DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW > && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && > S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && > RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && > ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) > selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > Changes since v1: > 1. Remove the comment why HAS_IOMEM dependency was added. > 2. Exdended description. > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones <lee.jones@linaro.org> Please take this soon, as it's breaking -next (soon to be Mainline). > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index a9727dab9e72..8ad8f91a72e1 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3 > config PHY_HI6220_USB > tristate "hi6220 USB PHY support" > depends on (ARCH_HISI && ARM64) || COMPILE_TEST > + depends on HAS_IOMEM > select GENERIC_PHY > select MFD_SYSCON > help -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web