Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358920 > unrolled thread

[PATCH v2] Documentation: devicetree: Clean up gpio-keys example

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Andreas Färber <afaerber@suse.de> - 2016-03-16 13:00 +0100
    Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Javier Martinez Canillas <javier@dowhile0.org> - 2016-03-16 15:50 +0100
      Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Julien Chauveau <chauveau.julien@gmail.com> - 2016-03-16 23:00 +0100

#1358920 — [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

Drop #address-cells and #size-cells, which are not required by the
gpio-keys binding documentation, as button sub-nodes are not devices.

Rename sub-nodes to avoid new dtc unit address warnings when copied.

While at it, adopt the dashes convention for the node name.

Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2:
 * Changed node name from underscore to dash
 * Inserted white lines
 * Renamed sub-nodes (Geert, Julien)
 
 Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 21641236c095..a94940481e55 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -32,17 +32,17 @@ Optional subnode-properties:
 
 Example nodes:
 
-	gpio_keys {
+	gpio-keys {
 			compatible = "gpio-keys";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			autorepeat;
-			button@21 {
+
+			up {
 				label = "GPIO Key UP";
 				linux,code = <103>;
 				gpios = <&gpio1 0 1>;
 			};
-			button@22 {
+
+			down {
 				label = "GPIO Key DOWN";
 				linux,code = <108>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
-- 
2.6.2

[toc] | [next] | [standalone]

#1359057

Hello Andreas,

On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier

[toc] | [prev] | [next] | [standalone]

#1359384

> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
> 
> Hello Andreas,
> 
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>> 
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>> 
>> While at it, adopt the dashes convention for the node name.
>> 
>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Javier Martinez Canillas <javier@dowhile0.org>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
> 
> Patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

I agree.

Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web