Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1358247 > unrolled thread

[RFC v2 -next 0/2] virtio-net: Advised MTU feature

Started byAaron Conole <aconole@redhat.com>
First post2016-03-15 22:10 +0100
Last post2016-03-17 22:30 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [RFC v2 -next 0/2] virtio-net: Advised MTU feature Aaron Conole <aconole@redhat.com> - 2016-03-15 22:10 +0100
    Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature Rick Jones <rick.jones2@hpe.com> - 2016-03-15 22:40 +0100
      Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature Aaron Conole <aconole@redhat.com> - 2016-03-17 22:30 +0100
    Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature Pankaj Gupta <pagupta@redhat.com> - 2016-03-16 06:00 +0100
      Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature Aaron Conole <aconole@redhat.com> - 2016-03-17 22:30 +0100

#1358247 — [RFC v2 -next 0/2] virtio-net: Advised MTU feature

FromAaron Conole <aconole@redhat.com>
Date2016-03-15 22:10 +0100
Subject[RFC v2 -next 0/2] virtio-net: Advised MTU feature
Message-ID<rd4o2-7FE-11@gated-at.bofh.it>
The following series adds the ability for a hypervisor to set an MTU on the
guest during feature negotiation phase. This is useful for VM orchestration
when, for instance, tunneling is involved and the MTU of the various systems
should be homogenous.

The first patch adds the feature bit as described in the proposed VFIO spec
addition found at
https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html

The second patch adds a user of the bit, and a warning when the guest changes
the MTU from the hypervisor advised MTU. Future patches may add more thorough
error handling.

v2:
* Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni
* Additional test before printing a warning

Aaron Conole (2):
  virtio: Start feature MTU support
  virtio_net: Read the advised MTU

 drivers/net/virtio_net.c        | 12 ++++++++++++
 include/uapi/linux/virtio_net.h |  3 +++
 2 files changed, 15 insertions(+)

-- 
2.5.0

[toc] | [next] | [standalone]


#1358268

FromRick Jones <rick.jones2@hpe.com>
Date2016-03-15 22:40 +0100
Message-ID<rd4R5-7Rt-53@gated-at.bofh.it>
In reply to#1358247
On 03/15/2016 02:04 PM, Aaron Conole wrote:
> The following series adds the ability for a hypervisor to set an MTU on the
> guest during feature negotiation phase. This is useful for VM orchestration
> when, for instance, tunneling is involved and the MTU of the various systems
> should be homogenous.
>
> The first patch adds the feature bit as described in the proposed VFIO spec
> addition found at
> https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html
>
> The second patch adds a user of the bit, and a warning when the guest changes
> the MTU from the hypervisor advised MTU. Future patches may add more thorough
> error handling.

How do you see this interacting with VMs getting MTU settings via DHCP?

rick jones

>
> v2:
> * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni
> * Additional test before printing a warning
>
> Aaron Conole (2):
>    virtio: Start feature MTU support
>    virtio_net: Read the advised MTU
>
>   drivers/net/virtio_net.c        | 12 ++++++++++++
>   include/uapi/linux/virtio_net.h |  3 +++
>   2 files changed, 15 insertions(+)
>

[toc] | [prev] | [next] | [standalone]


#1360209

FromAaron Conole <aconole@redhat.com>
Date2016-03-17 22:30 +0100
Message-ID<rdNEu-4pc-17@gated-at.bofh.it>
In reply to#1358268
Rick Jones <rick.jones2@hpe.com> writes:

> On 03/15/2016 02:04 PM, Aaron Conole wrote:
>> The following series adds the ability for a hypervisor to set an MTU on the
>> guest during feature negotiation phase. This is useful for VM orchestration
>> when, for instance, tunneling is involved and the MTU of the various systems
>> should be homogenous.
>>
>> The first patch adds the feature bit as described in the proposed VFIO spec
>> addition found at
>> https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html
>>
>> The second patch adds a user of the bit, and a warning when the guest changes
>> the MTU from the hypervisor advised MTU. Future patches may add more thorough
>> error handling.
>
> How do you see this interacting with VMs getting MTU settings via DHCP?

This is intended for networks where the VMs are not given MTU via
DHCP. I don't think it should negatively interfere with such a
network. Does that make sense?

-Aaron

> rick jones
>
>>
>> v2:
>> * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni
>> * Additional test before printing a warning
>>
>> Aaron Conole (2):
>>    virtio: Start feature MTU support
>>    virtio_net: Read the advised MTU
>>
>>   drivers/net/virtio_net.c        | 12 ++++++++++++
>>   include/uapi/linux/virtio_net.h |  3 +++
>>   2 files changed, 15 insertions(+)
>>

[toc] | [prev] | [next] | [standalone]


#1358524

FromPankaj Gupta <pagupta@redhat.com>
Date2016-03-16 06:00 +0100
Message-ID<rdbIS-3R6-7@gated-at.bofh.it>
In reply to#1358247
> 
> The following series adds the ability for a hypervisor to set an MTU on the
> guest during feature negotiation phase. This is useful for VM orchestration
> when, for instance, tunneling is involved and the MTU of the various systems
> should be homogenous.
> 
> The first patch adds the feature bit as described in the proposed VFIO spec

You mean VIRTIO spec?

> addition found at
> https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html
> 
> The second patch adds a user of the bit, and a warning when the guest changes
> the MTU from the hypervisor advised MTU. Future patches may add more thorough
> error handling.
> 
> v2:
> * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni
> * Additional test before printing a warning
> 
> Aaron Conole (2):
>   virtio: Start feature MTU support
>   virtio_net: Read the advised MTU
> 
>  drivers/net/virtio_net.c        | 12 ++++++++++++
>  include/uapi/linux/virtio_net.h |  3 +++
>  2 files changed, 15 insertions(+)
> 
> --
> 2.5.0
> 
> 

[toc] | [prev] | [next] | [standalone]


#1360206

FromAaron Conole <aconole@redhat.com>
Date2016-03-17 22:30 +0100
Message-ID<rdNEu-4pc-3@gated-at.bofh.it>
In reply to#1358524
Pankaj Gupta <pagupta@redhat.com> writes:

>> 
>> The following series adds the ability for a hypervisor to set an MTU on the
>> guest during feature negotiation phase. This is useful for VM orchestration
>> when, for instance, tunneling is involved and the MTU of the various systems
>> should be homogenous.
>> 
>> The first patch adds the feature bit as described in the proposed VFIO spec
>
> You mean VIRTIO spec?

Yes, sorry.

>> addition found at
>> https://lists.oasis-open.org/archives/virtio-dev/201603/msg00001.html
>> 
>> The second patch adds a user of the bit, and a warning when the guest changes
>> the MTU from the hypervisor advised MTU. Future patches may add more thorough
>> error handling.
>> 
>> v2:
>> * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni
>> * Additional test before printing a warning
>> 
>> Aaron Conole (2):
>>   virtio: Start feature MTU support
>>   virtio_net: Read the advised MTU
>> 
>>  drivers/net/virtio_net.c        | 12 ++++++++++++
>>  include/uapi/linux/virtio_net.h |  3 +++
>>  2 files changed, 15 insertions(+)
>> 
>> --
>> 2.5.0
>> 
>> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web