Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359863 > unrolled thread

[PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer

Started byPeter Griffin <peter.griffin@linaro.org>
First post2016-03-17 14:50 +0100
Last post2016-03-19 09:40 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Peter Griffin <peter.griffin@linaro.org> - 2016-03-17 14:50 +0100
    Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Heiko Stübner <heiko@sntech.de> - 2016-03-17 15:00 +0100
      Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL  pointer Peter Griffin <peter.griffin@linaro.org> - 2016-03-17 15:10 +0100
    Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Heiko Stuebner <heiko@sntech.de> - 2016-03-19 09:40 +0100

#1359863 — [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer

FromPeter Griffin <peter.griffin@linaro.org>
Date2016-03-17 14:50 +0100
Subject[PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
Message-ID<rdGtj-844-9@gated-at.bofh.it>
This fixes the following sparse build warning:

     mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 arch/arm/mach-rockchip/platsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index d42a07e..4d827a0 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu)
 	if (dev)
 		np = dev->of_node;
 	else
-		np = of_get_cpu_node(cpu, 0);
+		np = of_get_cpu_node(cpu, NULL);
 
 	return of_reset_control_get(np, NULL);
 }
-- 
1.9.1

[toc] | [next] | [standalone]

#1359874

FromHeiko Stübner <heiko@sntech.de>
Date2016-03-17 15:00 +0100
Message-ID<rdGD2-87J-31@gated-at.bofh.it>
In reply to#1359863
Hi Peter,

no need to resend for that (will be lost when applying anyway), but for future 
patches please consider the things below:

Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin:
> This fixes the following sparse build warning:
> 
>      mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

please bring aling tags received in previous versions to future ones, like the 
one from Lee:

Acked-by: Lee Jones <lee.jones@linaro.org>

> ---

changes in v2:
- beautify commit message


otherwise, patch looks nice and I'll pick it up shortly


Thanks for catching this
Heiko

>  arch/arm/mach-rockchip/platsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/platsmp.c
> b/arch/arm/mach-rockchip/platsmp.c index d42a07e..4d827a0 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int
> cpu) if (dev)
>  		np = dev->of_node;
>  	else
> -		np = of_get_cpu_node(cpu, 0);
> +		np = of_get_cpu_node(cpu, NULL);
> 
>  	return of_reset_control_get(np, NULL);
>  }

[toc] | [prev] | [next] | [standalone]

#1359882 — Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer

FromPeter Griffin <peter.griffin@linaro.org>
Date2016-03-17 15:10 +0100
SubjectRe: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
Message-ID<rdGMI-8rO-41@gated-at.bofh.it>
In reply to#1359874
Hi Heiko,

On Thu, 17 Mar 2016, Heiko Stübner wrote:

> Hi Peter,
> 
> no need to resend for that (will be lost when applying anyway), but for future 
> patches please consider the things below:
> 
> Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin:
> > This fixes the following sparse build warning:
> > 
> >      mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> 
> please bring aling tags received in previous versions to future ones, like the 
> one from Lee:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Will do, I didn't notice Lee had also Acked it. I should have been paying more
attention and not re-spinning whilst in a conf call.
> 
> > ---
> 
> changes in v2:
> - beautify commit message
> 
> 
> otherwise, patch looks nice and I'll pick it up shortly
> 
> 
> Thanks for catching this

No problem, thanks for the feedback and taking the patch.

regards,

Peter.

[toc] | [prev] | [next] | [standalone]

#1361058

FromHeiko Stuebner <heiko@sntech.de>
Date2016-03-19 09:40 +0100
Message-ID<rekAp-5Ls-1@gated-at.bofh.it>
In reply to#1359863
Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin:
> This fixes the following sparse build warning:
> 
>      mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

applied to soc32-fixes for 4.6 with Lee's Ack


Thanks
Heiko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web