Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1358248 > unrolled thread
| Started by | Rob Landley <rob@landley.net> |
|---|---|
| First post | 2016-03-15 22:20 +0100 |
| Last post | 2016-03-16 08:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Remove v850 from linux/elf-em.h Rob Landley <rob@landley.net> - 2016-03-15 22:20 +0100
Re: [PATCH] Remove v850 from linux/elf-em.h David Daney <ddaney.cavm@gmail.com> - 2016-03-16 00:30 +0100
Re: [PATCH] Remove v850 from linux/elf-em.h Rob Landley <rob@landley.net> - 2016-03-16 08:20 +0100
| From | Rob Landley <rob@landley.net> |
|---|---|
| Date | 2016-03-15 22:20 +0100 |
| Subject | [PATCH] Remove v850 from linux/elf-em.h |
| Message-ID | <rd4xH-7J5-1@gated-at.bofh.it> |
From: Rob Landley <rob@landley.net> The v850 port was removed by commits f606ddf42fd4 and 07a887d399b8 in 2008. These #defines are not used in the current kernel. Signed-off-by: Rob Landley <rob@landley.net> --- include/uapi/linux/elf-em.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h index b56dfcf..c3fdfe7 100644 --- a/include/uapi/linux/elf-em.h +++ b/include/uapi/linux/elf-em.h @@ -30,7 +30,6 @@ #define EM_X86_64 62 /* AMD x86-64 */ #define EM_S390 22 /* IBM S/390 */ #define EM_CRIS 76 /* Axis Communications 32-bit embedded processor */ -#define EM_V850 87 /* NEC v850 */ #define EM_M32R 88 /* Renesas M32R */ #define EM_MN10300 89 /* Panasonic/MEI MN10300, AM33 */ #define EM_OPENRISC 92 /* OpenRISC 32-bit embedded processor */ @@ -50,8 +49,6 @@ */ #define EM_ALPHA 0x9026 -/* Bogus old v850 magic number, used by old tools. */ -#define EM_CYGNUS_V850 0x9080 /* Bogus old m32r magic number, used by old tools. */ #define EM_CYGNUS_M32R 0x9041 /* This is the old interim value for S/390 architecture */ --
[toc] | [next] | [standalone]
| From | David Daney <ddaney.cavm@gmail.com> |
|---|---|
| Date | 2016-03-16 00:30 +0100 |
| Message-ID | <rd6zv-B2-9@gated-at.bofh.it> |
| In reply to | #1358248 |
On 03/15/2016 02:10 PM, Rob Landley wrote: > From: Rob Landley <rob@landley.net> > > The v850 port was removed by commits f606ddf42fd4 and 07a887d399b8 in 2008. > These #defines are not used in the current kernel. > > Signed-off-by: Rob Landley <rob@landley.net> > --- > include/uapi/linux/elf-em.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h > index b56dfcf..c3fdfe7 100644 > --- a/include/uapi/linux/elf-em.h > +++ b/include/uapi/linux/elf-em.h > @@ -30,7 +30,6 @@ > #define EM_X86_64 62 /* AMD x86-64 */ > #define EM_S390 22 /* IBM S/390 */ > #define EM_CRIS 76 /* Axis Communications 32-bit embedded processor */ > -#define EM_V850 87 /* NEC v850 */ Can you do this to userspace visible files? I thought only additions and obvious corrections were allowed. Removing symbols could cause build breakage for something. > #define EM_M32R 88 /* Renesas M32R */ > #define EM_MN10300 89 /* Panasonic/MEI MN10300, AM33 */ > #define EM_OPENRISC 92 /* OpenRISC 32-bit embedded processor */ > @@ -50,8 +49,6 @@ > */ > #define EM_ALPHA 0x9026 > > -/* Bogus old v850 magic number, used by old tools. */ > -#define EM_CYGNUS_V850 0x9080 > /* Bogus old m32r magic number, used by old tools. */ > #define EM_CYGNUS_M32R 0x9041 > /* This is the old interim value for S/390 architecture */ >
[toc] | [prev] | [next] | [standalone]
| From | Rob Landley <rob@landley.net> |
|---|---|
| Date | 2016-03-16 08:20 +0100 |
| Message-ID | <rddUl-5zP-3@gated-at.bofh.it> |
| In reply to | #1358335 |
On 03/15/2016 06:22 PM, David Daney wrote: > On 03/15/2016 02:10 PM, Rob Landley wrote: >> From: Rob Landley <rob@landley.net> >> >> The v850 port was removed by commits f606ddf42fd4 and 07a887d399b8 in >> 2008. >> These #defines are not used in the current kernel. >> >> Signed-off-by: Rob Landley <rob@landley.net> >> --- >> include/uapi/linux/elf-em.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h >> index b56dfcf..c3fdfe7 100644 >> --- a/include/uapi/linux/elf-em.h >> +++ b/include/uapi/linux/elf-em.h >> @@ -30,7 +30,6 @@ >> #define EM_X86_64 62 /* AMD x86-64 */ >> #define EM_S390 22 /* IBM S/390 */ >> #define EM_CRIS 76 /* Axis Communications 32-bit embedded >> processor */ >> -#define EM_V850 87 /* NEC v850 */ > > Can you do this to userspace visible files? Commit 6f6f467eaaa0 did and nobody seemed to mind? > I thought only additions and obvious corrections were allowed. Removing > symbols could cause build breakage for something. There's a /usr/include/elf.h in glibc with 3 times as many EM_BLAH symbols as this one defines. Something that cares about identifying architectures Linux doesn't actually support would presumably use that header instead of this one. This is the only architecture included in this file that isn't currently supported by Linux (except the mips symbols with the comment about them not being used, which have been there since the first version of the file). I found this while auditing toybox's "file" command. (We just copied the constant values into our own table, but when making the table I was checking which values the actual Linux ELF loaders in the various arch directories would bind to.) Rob
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web