Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356979 > unrolled thread
| Started by | Felipe Balbi <felipe.balbi@linux.intel.com> |
|---|---|
| First post | 2016-03-14 08:00 +0100 |
| Last post | 2016-03-14 09:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] usb: dwc3: add disable receiver detection in P3 quirk Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-03-14 08:00 +0100
RE: [PATCH] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat <rajesh.bhagat@nxp.com> - 2016-03-14 09:40 +0100
| From | Felipe Balbi <felipe.balbi@linux.intel.com> |
|---|---|
| Date | 2016-03-14 08:00 +0100 |
| Subject | Re: [PATCH] usb: dwc3: add disable receiver detection in P3 quirk |
| Message-ID | <rcuDU-co-15@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi,
Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:
> [ text/plain ]
> Some freescale QorIQ platforms require to disable receiver detection
> in P3 for correct detection of USB devices. If GUSB3PIPECTL(DISRXDETINP3)
> is set, Core will change PHY power state to P2 and then perform receiver
> detection. After receiver detection, Core will change PHY power state to
> P3. Same quirk would be added in dts file in future patches.
>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> ---
> drivers/usb/dwc3/core.c | 6 ++++++
> drivers/usb/dwc3/core.h | 2 ++
> drivers/usb/dwc3/platform_data.h | 1 +
> 3 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index de5e01f..b2f2b08 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -446,6 +446,9 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
> if (dwc->u2ss_inp3_quirk)
> reg |= DWC3_GUSB3PIPECTL_U2SSINP3OK;
>
> + if (dwc->dis_rxdet_inp3_quirk)
> + reg |= DWC3_GUSB3PIPECTL_DISRXDETINP3;
> +
> if (dwc->req_p1p2p3_quirk)
> reg |= DWC3_GUSB3PIPECTL_REQP1P2P3;
>
> @@ -903,6 +906,8 @@ static int dwc3_probe(struct platform_device *pdev)
> "snps,u2exit_lfps_quirk");
> dwc->u2ss_inp3_quirk = device_property_read_bool(dev,
> "snps,u2ss_inp3_quirk");
> + dwc->dis_rxdet_inp3_quirk = device_property_read_bool(dev,
> + "snps,dis_rxdet_inp3_quirk");
not documented under Documentation/devicetree/bindings/usb/dwc3.txt.
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index e4f8b90..41cc22c 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -193,6 +193,7 @@
> /* Global USB3 PIPE Control Register */
> #define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
> #define DWC3_GUSB3PIPECTL_U2SSINP3OK (1 << 29)
> +#define DWC3_GUSB3PIPECTL_DISRXDETINP3 (1 << 28)
> #define DWC3_GUSB3PIPECTL_REQP1P2P3 (1 << 24)
> #define DWC3_GUSB3PIPECTL_DEP1P2P3(n) ((n) << 19)
> #define DWC3_GUSB3PIPECTL_DEP1P2P3_MASK DWC3_GUSB3PIPECTL_DEP1P2P3(7)
> @@ -873,6 +874,7 @@ struct dwc3 {
>
> unsigned tx_de_emphasis_quirk:1;
> unsigned tx_de_emphasis:2;
> + unsigned dis_rxdet_inp3_quirk:1;
_must_ be sorted alphabetically and you _must_ update the kernel doc
above this structure.
> };
>
> /* -------------------------------------------------------------------------- */
> diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
> index 2bb4d3a..9df1dfb 100644
> --- a/drivers/usb/dwc3/platform_data.h
> +++ b/drivers/usb/dwc3/platform_data.h
> @@ -46,6 +46,7 @@ struct dwc3_platform_data {
>
> unsigned tx_de_emphasis_quirk:1;
> unsigned tx_de_emphasis:2;
> + unsigned dis_rxdet_inp3_quirk:1;
likewise.
--
balbi
[toc] | [next] | [standalone]
| From | Rajesh Bhagat <rajesh.bhagat@nxp.com> |
|---|---|
| Date | 2016-03-14 09:40 +0100 |
| Message-ID | <rcwcG-1jA-15@gated-at.bofh.it> |
| In reply to | #1356979 |
> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com]
> Sent: Monday, March 14, 2016 12:26 PM
> To: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-omap@vger.kernel.org; Sriram Dash
> <sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Subject: Re: [PATCH] usb: dwc3: add disable receiver detection in P3 quirk
>
>
> Hi,
>
Hello Felipe,
Thanks for the comments.
> Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:
> > [ text/plain ]
> > Some freescale QorIQ platforms require to disable receiver detection
> > in P3 for correct detection of USB devices. If
> > GUSB3PIPECTL(DISRXDETINP3) is set, Core will change PHY power state to
> > P2 and then perform receiver detection. After receiver detection, Core
> > will change PHY power state to P3. Same quirk would be added in dts file in future
> patches.
> >
> > Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> > ---
> > drivers/usb/dwc3/core.c | 6 ++++++
> > drivers/usb/dwc3/core.h | 2 ++
> > drivers/usb/dwc3/platform_data.h | 1 +
> > 3 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> > de5e01f..b2f2b08 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -446,6 +446,9 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
> > if (dwc->u2ss_inp3_quirk)
> > reg |= DWC3_GUSB3PIPECTL_U2SSINP3OK;
> >
> > + if (dwc->dis_rxdet_inp3_quirk)
> > + reg |= DWC3_GUSB3PIPECTL_DISRXDETINP3;
> > +
> > if (dwc->req_p1p2p3_quirk)
> > reg |= DWC3_GUSB3PIPECTL_REQP1P2P3;
> >
> > @@ -903,6 +906,8 @@ static int dwc3_probe(struct platform_device *pdev)
> > "snps,u2exit_lfps_quirk");
> > dwc->u2ss_inp3_quirk = device_property_read_bool(dev,
> > "snps,u2ss_inp3_quirk");
> > + dwc->dis_rxdet_inp3_quirk = device_property_read_bool(dev,
> > + "snps,dis_rxdet_inp3_quirk");
>
> not documented under Documentation/devicetree/bindings/usb/dwc3.txt.
>
Will take care in v2.
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
> > e4f8b90..41cc22c 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -193,6 +193,7 @@
> > /* Global USB3 PIPE Control Register */
> > #define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
> > #define DWC3_GUSB3PIPECTL_U2SSINP3OK (1 << 29)
> > +#define DWC3_GUSB3PIPECTL_DISRXDETINP3 (1 << 28)
> > #define DWC3_GUSB3PIPECTL_REQP1P2P3 (1 << 24)
> > #define DWC3_GUSB3PIPECTL_DEP1P2P3(n) ((n) << 19)
> > #define DWC3_GUSB3PIPECTL_DEP1P2P3_MASK
> DWC3_GUSB3PIPECTL_DEP1P2P3(7)
> > @@ -873,6 +874,7 @@ struct dwc3 {
> >
> > unsigned tx_de_emphasis_quirk:1;
> > unsigned tx_de_emphasis:2;
> > + unsigned dis_rxdet_inp3_quirk:1;
>
> _must_ be sorted alphabetically and you _must_ update the kernel doc above this
> structure.
>
Will take care in v2.
> > };
> >
> > /*
> > ----------------------------------------------------------------------
> > ---- */ diff --git a/drivers/usb/dwc3/platform_data.h
> > b/drivers/usb/dwc3/platform_data.h
> > index 2bb4d3a..9df1dfb 100644
> > --- a/drivers/usb/dwc3/platform_data.h
> > +++ b/drivers/usb/dwc3/platform_data.h
> > @@ -46,6 +46,7 @@ struct dwc3_platform_data {
> >
> > unsigned tx_de_emphasis_quirk:1;
> > unsigned tx_de_emphasis:2;
> > + unsigned dis_rxdet_inp3_quirk:1;
>
> likewise.
>
Will take care in v2.
> --
> balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web