Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357936 > unrolled thread

[PATCH] ARC: axs10x - add Ethernet PHY description in .dts

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-15 10:30 +0100
    Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-15 15:40 +0100
      Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-15 16:00 +0100

#1357936 — [PATCH] ARC: axs10x - add Ethernet PHY description in .dts

Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

That's what happens on eth0 up:
--------------------------->8------------------------
libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
--------------------------->8------------------------

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Phil Reid <preid@electromag.com.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org # 4.5.x
---
 arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c..04b999e 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
 			clocks = <&apbclk>;
 			clock-names = "stmmaceth";
 			max-speed = <100>;
+			mdio0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "snps,dwmac-mdio";
+				phy0: ethernet-phy@0 {
+					reg = <1>;
+				};
+			};
 		};
 
 		ehci@0x40000 {
-- 
2.5.0

[toc] | [next] | [standalone]

#1358074

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>
> That's what happens on eth0 up:
> --------------------------->8------------------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> --------------------------->8------------------------
>
> Simplest solution is to add PHY description in board's .dts.
> And so we do here.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Phil Reid <preid@electromag.com.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org # 4.5.x
> ---
>   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 44a578c..04b999e 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -47,6 +47,14 @@
>   			clocks = <&apbclk>;
>   			clock-names = "stmmaceth";
>   			max-speed = <100>;
> +			mdio0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "snps,dwmac-mdio";
> +				phy0: ethernet-phy@0 {

    The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1358084

Hi Sergei,

On Tue, 2016-03-15 at 17:38 +-0300, Sergei Shtylyov wrote:
+AD4- Hello.
+AD4- 
+AD4- On 3/15/2016 12:29 PM, Alexey Brodkin wrote:
+AD4- 
+AD4- +AD4- 
+AD4- +AD4- Following commit broke DW GMAC functionality on AXS10x boards:
+AD4- +AD4- http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id+AD0-e34d65696d2ef13dc32f2a162556c86c461ed763
+AD4- +AD4- 
+AD4- +AD4- That's what happens on eth0 up:
+AD4- +AD4- ---------------------------+AD4-8------------------------
+AD4- +AD4- libphy: PHY stmmac-0:ffffffff not found
+AD4- +AD4- eth0: Could not attach to PHY
+AD4- +AD4- stmmac+AF8-open: Cannot attach to PHY (error: -19)
+AD4- +AD4- ---------------------------+AD4-8------------------------
+AD4- +AD4- 
+AD4- +AD4- Simplest solution is to add PHY description in board's .dts.
+AD4- +AD4- And so we do here.
+AD4- +AD4- 
+AD4- +AD4- Signed-off-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4-
+AD4- +AD4- Cc: Rob Herring +ADw-robh+AEA-kernel.org+AD4-
+AD4- +AD4- Cc: Phil Reid +ADw-preid+AEA-electromag.com.au+AD4-
+AD4- +AD4- Cc: David S. Miller +ADw-davem+AEA-davemloft.net+AD4-
+AD4- +AD4- Cc: linux-kernel+AEA-vger.kernel.org
+AD4- +AD4- Cc: netdev+AEA-vger.kernel.org
+AD4- +AD4- Cc: stable+AEA-vger.kernel.org +ACM- 4.5.x
+AD4- +AD4- ---
+AD4- +AD4- +AKA- arch/arc/boot/dts/axs10x+AF8-mb.dtsi +AHw- 8 +-+-+-+-+-+-+-+-
+AD4- +AD4- +AKA- 1 file changed, 8 insertions(+-)
+AD4- +AD4- 
+AD4- +AD4- diff --git a/arch/arc/boot/dts/axs10x+AF8-mb.dtsi b/arch/arc/boot/dts/axs10x+AF8-mb.dtsi
+AD4- +AD4- index 44a578c..04b999e 100644
+AD4- +AD4- --- a/arch/arc/boot/dts/axs10x+AF8-mb.dtsi
+AD4- +AD4- +-+-+- b/arch/arc/boot/dts/axs10x+AF8-mb.dtsi
+AD4- +AD4- +AEAAQA- -47,6 +-47,14 +AEAAQA-
+AD4- +AD4- +AKAAoA-			clocks +AD0- +ADwAJg-apbclk+AD4AOw-
+AD4- +AD4- +AKAAoA-			clock-names +AD0- +ACI-stmmaceth+ACIAOw-
+AD4- +AD4- +AKAAoA-			max-speed +AD0- +ADw-100+AD4AOw-
+AD4- +AD4- +-			mdio0 +AHs-
+AD4- +AD4- +-				+ACM-address-cells +AD0- +ADw-1+AD4AOw-
+AD4- +AD4- +-				+ACM-size-cells +AD0- +ADw-0+AD4AOw-
+AD4- +AD4- +-				compatible +AD0- +ACI-snps,dwmac-mdio+ACIAOw-
+AD4- +AD4- +-				phy0: ethernet-phy+AEA-0 +AHs-
+AD4- +AKAAoACgAKA-The naming is inconsistent with the +ACI-reg+ACI- prop specified, should be +AEA-1.

Makes sense.
Will re-send it with mentioned fix.

-Alexey

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web