Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356816 > unrolled thread

[PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board

Started byChanwoo Choi <cw00.choi@samsung.com>
First post2016-03-14 03:10 +0100
Last post2016-03-15 02:50 +0100
Articles 9 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-14 03:10 +0100
    Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-14 09:40 +0100
      Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-14 09:50 +0100
        Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-14 10:50 +0100
          Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-14 11:30 +0100
            Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-15 01:30 +0100
              Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Jaehoon Chung <jh80.chung@samsung.com> - 2016-03-15 02:00 +0100
                Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-15 02:50 +0100
                Re: [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for  exynos3250-artik5-devel board Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-15 02:50 +0100

#1356816 — [PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-03-14 03:10 +0100
Subject[PATCH 09/10] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-devel board
Message-ID<rcq7g-5Io-13@gated-at.bofh.it>
From: Jaehoon Chung <jh80.chung@samsung.com>

This patch adds MSHC (Mobile Storage Host Controller) dt node for
Exynos3250 SoC. MSHC is an interface between the system and the SD card

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
index d17c28969118..a371baf8536d 100644
--- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
+++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
@@ -21,6 +21,22 @@
 			"samsung,exynos3250", "samsung,exynos3";
 };
 
+&mshc_2 {
+	num-slots = <1>;
+	cap-sd-highspeed;
+	disable-wp;
+	card-detect-delay = <200>;
+	clock-frequency = <100000000>;
+	clock-freq-min-max = <400000 100000000>;
+	samsung,dw-mshc-ciu-div = <1>;
+	samsung,dw-mshc-sdr-timing = <0 1>;
+	samsung,dw-mshc-ddr-timing = <1 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
+	bus-width = <4>;
+	status = "okay";
+};
+
 &serial_2 {
 	status = "okay";
 };
-- 
1.9.1

[toc] | [next] | [standalone]

#1357053

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-14 09:40 +0100
Message-ID<rcwcF-1jA-11@gated-at.bofh.it>
In reply to#1356816
On 14.03.2016 11:04, Chanwoo Choi wrote:
> From: Jaehoon Chung <jh80.chung@samsung.com>
> 
> This patch adds MSHC (Mobile Storage Host Controller) dt node for
> Exynos3250 SoC. MSHC is an interface between the system and the SD card
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
> index d17c28969118..a371baf8536d 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
> @@ -21,6 +21,22 @@
>  			"samsung,exynos3250", "samsung,exynos3";
>  };
>  
> +&mshc_2 {
> +	num-slots = <1>;
> +	cap-sd-highspeed;
> +	disable-wp;
> +	card-detect-delay = <200>;
> +	clock-frequency = <100000000>;
> +	clock-freq-min-max = <400000 100000000>;
> +	samsung,dw-mshc-ciu-div = <1>;
> +	samsung,dw-mshc-sdr-timing = <0 1>;
> +	samsung,dw-mshc-ddr-timing = <1 2>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
> +	bus-width = <4>;
> +	status = "okay";

vqmmc-supply = ldo3?

Best regards,
Krzysztof

> +};
> +
>  &serial_2 {
>  	status = "okay";
>  };
>

[toc] | [prev] | [next] | [standalone]

#1357068

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-03-14 09:50 +0100
Message-ID<rcwmm-1mS-21@gated-at.bofh.it>
In reply to#1357053
On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
> On 14.03.2016 11:04, Chanwoo Choi wrote:
>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>> index d17c28969118..a371baf8536d 100644
>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>> @@ -21,6 +21,22 @@
>>  			"samsung,exynos3250", "samsung,exynos3";
>>  };
>>  
>> +&mshc_2 {
>> +	num-slots = <1>;
>> +	cap-sd-highspeed;
>> +	disable-wp;
>> +	card-detect-delay = <200>;
>> +	clock-frequency = <100000000>;
>> +	clock-freq-min-max = <400000 100000000>;
>> +	samsung,dw-mshc-ciu-div = <1>;
>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>> +	bus-width = <4>;
>> +	status = "okay";
> 
> vqmmc-supply = ldo3?

ldo3 is always on state because ldo3 is used for various IP in exynos3250.
I think that we had better to remain always on state for ldo3.

Best Regards,
Chanwoo Choi

[toc] | [prev] | [next] | [standalone]

#1357102

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-14 10:50 +0100
Message-ID<rcxiq-1YG-9@gated-at.bofh.it>
In reply to#1357068
On 14.03.2016 17:48, Chanwoo Choi wrote:
> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>
>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>> index d17c28969118..a371baf8536d 100644
>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>> @@ -21,6 +21,22 @@
>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>  };
>>>  
>>> +&mshc_2 {
>>> +	num-slots = <1>;
>>> +	cap-sd-highspeed;
>>> +	disable-wp;
>>> +	card-detect-delay = <200>;
>>> +	clock-frequency = <100000000>;
>>> +	clock-freq-min-max = <400000 100000000>;
>>> +	samsung,dw-mshc-ciu-div = <1>;
>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>> +	bus-width = <4>;
>>> +	status = "okay";
>>
>> vqmmc-supply = ldo3?
> 
> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
> I think that we had better to remain always on state for ldo3.

Yes, I wasn't thinking about toggling ldo3 but about taking the
regulator here to model the dependencies between components.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1357125

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-03-14 11:30 +0100
Message-ID<rcxV8-2t9-21@gated-at.bofh.it>
In reply to#1357102
On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote:
> On 14.03.2016 17:48, Chanwoo Choi wrote:
>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>>
>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>> index d17c28969118..a371baf8536d 100644
>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>> @@ -21,6 +21,22 @@
>>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>>  };
>>>>  
>>>> +&mshc_2 {
>>>> +	num-slots = <1>;
>>>> +	cap-sd-highspeed;
>>>> +	disable-wp;
>>>> +	card-detect-delay = <200>;
>>>> +	clock-frequency = <100000000>;
>>>> +	clock-freq-min-max = <400000 100000000>;
>>>> +	samsung,dw-mshc-ciu-div = <1>;
>>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>>> +	pinctrl-names = "default";
>>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>>> +	bus-width = <4>;
>>>> +	status = "okay";
>>>
>>> vqmmc-supply = ldo3?
>>
>> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
>> I think that we had better to remain always on state for ldo3.
> 
> Yes, I wasn't thinking about toggling ldo3 but about taking the
> regulator here to model the dependencies between components.

Okay. I'll add it as following:

	vmmc-supply = <&ldo18_reg>;
	vqmmc-supply = <&ldo3>;


Best Regards,
Chanwoo Choi

[toc] | [prev] | [next] | [standalone]

#1357713

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-15 01:30 +0100
Message-ID<rcL21-2Nm-1@gated-at.bofh.it>
In reply to#1357125
On 14.03.2016 19:22, Chanwoo Choi wrote:
> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote:
>> On 14.03.2016 17:48, Chanwoo Choi wrote:
>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>>>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>
>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>>>
>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>> ---
>>>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>>>  1 file changed, 16 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>> index d17c28969118..a371baf8536d 100644
>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>> @@ -21,6 +21,22 @@
>>>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>>>  };
>>>>>  
>>>>> +&mshc_2 {
>>>>> +	num-slots = <1>;
>>>>> +	cap-sd-highspeed;
>>>>> +	disable-wp;
>>>>> +	card-detect-delay = <200>;
>>>>> +	clock-frequency = <100000000>;
>>>>> +	clock-freq-min-max = <400000 100000000>;
>>>>> +	samsung,dw-mshc-ciu-div = <1>;
>>>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>>>> +	pinctrl-names = "default";
>>>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>>>> +	bus-width = <4>;
>>>>> +	status = "okay";
>>>>
>>>> vqmmc-supply = ldo3?
>>>
>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
>>> I think that we had better to remain always on state for ldo3.
>>
>> Yes, I wasn't thinking about toggling ldo3 but about taking the
>> regulator here to model the dependencies between components.
> 
> Okay. I'll add it as following:
> 
> 	vmmc-supply = <&ldo18_reg>;
> 	vqmmc-supply = <&ldo3>;

ldo18 is not used by mshc2. At least my schematics show that LDO3 goes
to DVDD_MMC2 (on different board revision that would be ldo18 instead of
ldo3, but not both).

The card itself is powered by VDDFLASH_28/MAIN_BAT.

BR,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1357726

FromJaehoon Chung <jh80.chung@samsung.com>
Date2016-03-15 02:00 +0100
Message-ID<rcLv4-2Yx-5@gated-at.bofh.it>
In reply to#1357713
On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote:
> On 14.03.2016 19:22, Chanwoo Choi wrote:
>> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote:
>>> On 14.03.2016 17:48, Chanwoo Choi wrote:
>>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>>>>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>>>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>>
>>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>>>>
>>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>>>>  1 file changed, 16 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>> index d17c28969118..a371baf8536d 100644
>>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>> @@ -21,6 +21,22 @@
>>>>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>>>>  };
>>>>>>  
>>>>>> +&mshc_2 {
>>>>>> +	num-slots = <1>;
>>>>>> +	cap-sd-highspeed;
>>>>>> +	disable-wp;
>>>>>> +	card-detect-delay = <200>;
>>>>>> +	clock-frequency = <100000000>;
>>>>>> +	clock-freq-min-max = <400000 100000000>;
>>>>>> +	samsung,dw-mshc-ciu-div = <1>;
>>>>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>>>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>>>>> +	pinctrl-names = "default";
>>>>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>>>>> +	bus-width = <4>;
>>>>>> +	status = "okay";
>>>>>
>>>>> vqmmc-supply = ldo3?
>>>>
>>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
>>>> I think that we had better to remain always on state for ldo3.
>>>
>>> Yes, I wasn't thinking about toggling ldo3 but about taking the
>>> regulator here to model the dependencies between components.
>>
>> Okay. I'll add it as following:
>>
>> 	vmmc-supply = <&ldo18_reg>;
>> 	vqmmc-supply = <&ldo3>;
> 
> ldo18 is not used by mshc2. At least my schematics show that LDO3 goes
> to DVDD_MMC2 (on different board revision that would be ldo18 instead of
> ldo3, but not both).

It's confusing..but it seems that Krzysztof's opinion is right.

Best Regards,
Jaehoon Chung

> 
> The card itself is powered by VDDFLASH_28/MAIN_BAT.
> 
> BR,
> Krzysztof
> 
>

[toc] | [prev] | [next] | [standalone]

#1357738

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-03-15 02:50 +0100
Message-ID<rcMhs-3vN-3@gated-at.bofh.it>
In reply to#1357726
On 2016년 03월 15일 10:45, Chanwoo Choi wrote:
> On 2016년 03월 15일 09:56, Jaehoon Chung wrote:
>> On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote:
>>> On 14.03.2016 19:22, Chanwoo Choi wrote:
>>>> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote:
>>>>> On 14.03.2016 17:48, Chanwoo Choi wrote:
>>>>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>>>>>>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>>>>>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>>>>
>>>>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>>>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>>>>>>
>>>>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>>>>> ---
>>>>>>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>>>>>>  1 file changed, 16 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>>> index d17c28969118..a371baf8536d 100644
>>>>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>>> @@ -21,6 +21,22 @@
>>>>>>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>>>>>>  };
>>>>>>>>  
>>>>>>>> +&mshc_2 {
>>>>>>>> +	num-slots = <1>;
>>>>>>>> +	cap-sd-highspeed;
>>>>>>>> +	disable-wp;
>>>>>>>> +	card-detect-delay = <200>;
>>>>>>>> +	clock-frequency = <100000000>;
>>>>>>>> +	clock-freq-min-max = <400000 100000000>;
>>>>>>>> +	samsung,dw-mshc-ciu-div = <1>;
>>>>>>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>>>>>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>>>>>>> +	pinctrl-names = "default";
>>>>>>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>>>>>>> +	bus-width = <4>;
>>>>>>>> +	status = "okay";
>>>>>>>
>>>>>>> vqmmc-supply = ldo3?
>>>>>>
>>>>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
>>>>>> I think that we had better to remain always on state for ldo3.
>>>>>
>>>>> Yes, I wasn't thinking about toggling ldo3 but about taking the
>>>>> regulator here to model the dependencies between components.
>>>>
>>>> Okay. I'll add it as following:
>>>>
>>>> 	vmmc-supply = <&ldo18_reg>;
>>>> 	vqmmc-supply = <&ldo3>;
>>>
>>> ldo18 is not used by mshc2. At least my schematics show that LDO3 goes
>>> to DVDD_MMC2 (on different board revision that would be ldo18 instead of
>>> ldo3, but not both).
> 
> ARTIK5 schema document VLDO18 and VLDO3 are connected to DVDD_MMC2_AP.
> But, I'm not sure what is meaning. So, I'll drop the 'vmmc-supply'

VLDO18 is not connected to DVDD_MMC2_AP. It is NC state.
Sorry for confusion.

Best Regards,
Chanwoo Choi

[snip]

[toc] | [prev] | [next] | [standalone]

#1357740

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-03-15 02:50 +0100
Message-ID<rcMhs-3vN-5@gated-at.bofh.it>
In reply to#1357726
On 2016년 03월 15일 09:56, Jaehoon Chung wrote:
> On 03/15/2016 09:25 AM, Krzysztof Kozlowski wrote:
>> On 14.03.2016 19:22, Chanwoo Choi wrote:
>>> On 2016년 03월 14일 18:44, Krzysztof Kozlowski wrote:
>>>> On 14.03.2016 17:48, Chanwoo Choi wrote:
>>>>> On 2016년 03월 14일 17:31, Krzysztof Kozlowski wrote:
>>>>>> On 14.03.2016 11:04, Chanwoo Choi wrote:
>>>>>>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>>>
>>>>>>> This patch adds MSHC (Mobile Storage Host Controller) dt node for
>>>>>>> Exynos3250 SoC. MSHC is an interface between the system and the SD card
>>>>>>>
>>>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>>>> ---
>>>>>>>  arch/arm/boot/dts/exynos3250-artik5-devel.dts | 16 ++++++++++++++++
>>>>>>>  1 file changed, 16 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-devel.dts b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>> index d17c28969118..a371baf8536d 100644
>>>>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-devel.dts
>>>>>>> @@ -21,6 +21,22 @@
>>>>>>>  			"samsung,exynos3250", "samsung,exynos3";
>>>>>>>  };
>>>>>>>  
>>>>>>> +&mshc_2 {
>>>>>>> +	num-slots = <1>;
>>>>>>> +	cap-sd-highspeed;
>>>>>>> +	disable-wp;
>>>>>>> +	card-detect-delay = <200>;
>>>>>>> +	clock-frequency = <100000000>;
>>>>>>> +	clock-freq-min-max = <400000 100000000>;
>>>>>>> +	samsung,dw-mshc-ciu-div = <1>;
>>>>>>> +	samsung,dw-mshc-sdr-timing = <0 1>;
>>>>>>> +	samsung,dw-mshc-ddr-timing = <1 2>;
>>>>>>> +	pinctrl-names = "default";
>>>>>>> +	pinctrl-0 = <&sd2_cmd &sd2_clk &sd2_cd &sd2_bus1 &sd2_bus4>;
>>>>>>> +	bus-width = <4>;
>>>>>>> +	status = "okay";
>>>>>>
>>>>>> vqmmc-supply = ldo3?
>>>>>
>>>>> ldo3 is always on state because ldo3 is used for various IP in exynos3250.
>>>>> I think that we had better to remain always on state for ldo3.
>>>>
>>>> Yes, I wasn't thinking about toggling ldo3 but about taking the
>>>> regulator here to model the dependencies between components.
>>>
>>> Okay. I'll add it as following:
>>>
>>> 	vmmc-supply = <&ldo18_reg>;
>>> 	vqmmc-supply = <&ldo3>;
>>
>> ldo18 is not used by mshc2. At least my schematics show that LDO3 goes
>> to DVDD_MMC2 (on different board revision that would be ldo18 instead of
>> ldo3, but not both).

ARTIK5 schema document VLDO18 and VLDO3 are connected to DVDD_MMC2_AP.
But, I'm not sure what is meaning. So, I'll drop the 'vmmc-supply'

> 
> It's confusing..but it seems that Krzysztof's opinion is right.
> 
> Best Regards,
> Jaehoon Chung
> 
>>
>> The card itself is powered by VDDFLASH_28/MAIN_BAT.

You're right.

OK, I'll modify it with only vqmmc-supply = <&ldo3>;

Best Regards,
Chanwoo Choi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web