Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357704 > unrolled thread
| Started by | Jeffrey Merkey <jeffmerkey@gmail.com> |
|---|---|
| First post | 2016-03-15 01:00 +0100 |
| Last post | 2016-03-17 00:30 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-03-15 01:00 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Joe Perches <joe@perches.com> - 2016-03-15 01:00 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 01:30 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-03-15 01:50 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 03:10 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Theodore Ts'o <tytso@mit.edu> - 2016-03-15 16:20 +0100
Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-03-17 00:30 +0100
| From | Jeffrey Merkey <jeffmerkey@gmail.com> |
|---|---|
| Date | 2016-03-15 01:00 +0100 |
| Subject | [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 |
| Message-ID | <rcKz0-2iI-25@gated-at.bofh.it> |
The following changes since commit b562e44f507e863c6792946e4e1b1449fbbac85d:
Linux 4.5 (2016-03-13 21:28:54 -0700)
are available in the git repository at:
https://github.com/jeffmerkey/linux.git tags/mdb-v4.5-signed
for you to fetch changes up to 2e9c184e1215dca2b4c59c347f40a0986b8e7460:
Add MDB Debugger to linux v4.5 (2016-03-14 15:17:44 -0600)
----------------------------------------------------------------
Signed GPG Tag for mdb-v4.5
Hi Linus,
Please consider one in-kernel debugger for 4.6 with full disassembler
for x86/x86_64 architectures systems. This code is fully checkpatch.pl
compliant and is essentially a complete rewrite of the eariler
version of this debugger. The code conforms to Linux coding standards
and these commits have been digitally signed with my published
GPG key.
Checkpatch results:
./scripts/checkpatch.pl --file --strict arch/x86/kernel/debug/mdb/*.[ch]
------------------------------------
arch/x86/kernel/debug/mdb/mdb-base.c
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 3293 lines checked
arch/x86/kernel/debug/mdb/mdb-base.c has no obvious style problems and is ready for submission.
------------------------------------
arch/x86/kernel/debug/mdb/mdb-base.h
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 447 lines checked
arch/x86/kernel/debug/mdb/mdb-base.h has no obvious style problems and is ready for submission.
-------------------------------
arch/x86/kernel/debug/mdb/mdb.h
-------------------------------
total: 0 errors, 0 warnings, 0 checks, 40 lines checked
arch/x86/kernel/debug/mdb/mdb.h has no obvious style problems and is ready for submission.
---------------------------------------
arch/x86/kernel/debug/mdb/mdb-ia-apic.c
---------------------------------------
total: 0 errors, 0 warnings, 0 checks, 243 lines checked
arch/x86/kernel/debug/mdb/mdb-ia-apic.c has no obvious style problems and is ready for submission.
----------------------------------
arch/x86/kernel/debug/mdb/mdb-ia.c
----------------------------------
total: 0 errors, 0 warnings, 0 checks, 6887 lines checked
arch/x86/kernel/debug/mdb/mdb-ia.c has no obvious style problems and is ready for submission.
----------------------------------
arch/x86/kernel/debug/mdb/mdb-ia.h
----------------------------------
total: 0 errors, 0 warnings, 0 checks, 209 lines checked
arch/x86/kernel/debug/mdb/mdb-ia.h has no obvious style problems and is ready for submission.
---------------------------------------
arch/x86/kernel/debug/mdb/mdb-ia-proc.h
---------------------------------------
total: 0 errors, 0 warnings, 0 checks, 819 lines checked
arch/x86/kernel/debug/mdb/mdb-ia-proc.h has no obvious style problems and is ready for submission.
------------------------------------------
arch/x86/kernel/debug/mdb/mdb-ia-support.c
------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 5342 lines checked
arch/x86/kernel/debug/mdb/mdb-ia-support.c has no obvious style problems and is ready for submission.
------------------------------------------
arch/x86/kernel/debug/mdb/mdb-ia-support.h
------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 76 lines checked
arch/x86/kernel/debug/mdb/mdb-ia-support.h has no obvious style problems and is ready for submission.
----------------------------------------
arch/x86/kernel/debug/mdb/mdb-keyboard.h
----------------------------------------
total: 0 errors, 0 warnings, 0 checks, 127 lines checked
arch/x86/kernel/debug/mdb/mdb-keyboard.h has no obvious style problems and is ready for submission.
------------------------------------
arch/x86/kernel/debug/mdb/mdb-list.c
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 534 lines checked
arch/x86/kernel/debug/mdb/mdb-list.c has no obvious style problems and is ready for submission.
------------------------------------
arch/x86/kernel/debug/mdb/mdb-list.h
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 96 lines checked
arch/x86/kernel/debug/mdb/mdb-list.h has no obvious style problems and is ready for submission.
-------------------------------------
arch/x86/kernel/debug/mdb/mdb-logic.c
-------------------------------------
total: 0 errors, 0 warnings, 0 checks, 2118 lines checked
arch/x86/kernel/debug/mdb/mdb-logic.c has no obvious style problems and is ready for submission.
------------------------------------
arch/x86/kernel/debug/mdb/mdb-main.c
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 786 lines checked
arch/x86/kernel/debug/mdb/mdb-main.c has no obvious style problems and is ready for submission.
-----------------------------------
arch/x86/kernel/debug/mdb/mdb.mod.c
-----------------------------------
total: 0 errors, 0 warnings, 0 checks, 23 lines checked
arch/x86/kernel/debug/mdb/mdb.mod.c has no obvious style problems and is ready for submission.
----------------------------------
arch/x86/kernel/debug/mdb/mdb-os.c
----------------------------------
total: 0 errors, 0 warnings, 0 checks, 1474 lines checked
arch/x86/kernel/debug/mdb/mdb-os.c has no obvious style problems and is ready for submission.
----------------------------------
arch/x86/kernel/debug/mdb/mdb-os.h
----------------------------------
total: 0 errors, 0 warnings, 0 checks, 141 lines checked
arch/x86/kernel/debug/mdb/mdb-os.h has no obvious style problems and is ready for submission.
------------------------------------
arch/x86/kernel/debug/mdb/mdb-proc.h
------------------------------------
total: 0 errors, 0 warnings, 0 checks, 179 lines checked
arch/x86/kernel/debug/mdb/mdb-proc.h has no obvious style problems and is ready for submission.
----------------------------------------------------------------
Jeffrey Merkey (1):
Add MDB Debugger to linux v4.5
Documentation/sysrq.txt | 2 +-
MAINTAINERS | 6 +
arch/x86/include/asm/bug.h | 9 +-
arch/x86/include/uapi/asm/debugreg.h | 1 +
arch/x86/kernel/Makefile | 1 +
arch/x86/kernel/apic/io_apic.c | 2 +
arch/x86/kernel/debug/Makefile | 3 +
arch/x86/kernel/debug/mdb/Makefile | 6 +
arch/x86/kernel/debug/mdb/Makefile.local | 106 +
arch/x86/kernel/debug/mdb/mdb-base.c | 3293 +++++++++++++
arch/x86/kernel/debug/mdb/mdb-base.h | 447 ++
arch/x86/kernel/debug/mdb/mdb-ia-apic.c | 243 +
arch/x86/kernel/debug/mdb/mdb-ia-proc.h | 819 ++++
arch/x86/kernel/debug/mdb/mdb-ia-support.c | 5342 +++++++++++++++++++++
arch/x86/kernel/debug/mdb/mdb-ia-support.h | 76 +
arch/x86/kernel/debug/mdb/mdb-ia.c | 6887 ++++++++++++++++++++++++++++
arch/x86/kernel/debug/mdb/mdb-ia.h | 209 +
arch/x86/kernel/debug/mdb/mdb-keyboard.h | 127 +
arch/x86/kernel/debug/mdb/mdb-list.c | 534 +++
arch/x86/kernel/debug/mdb/mdb-list.h | 96 +
arch/x86/kernel/debug/mdb/mdb-logic.c | 2118 +++++++++
arch/x86/kernel/debug/mdb/mdb-main.c | 786 ++++
arch/x86/kernel/debug/mdb/mdb-os.c | 1474 ++++++
arch/x86/kernel/debug/mdb/mdb-os.h | 141 +
arch/x86/kernel/debug/mdb/mdb-proc.h | 179 +
arch/x86/kernel/debug/mdb/mdb.h | 40 +
arch/x86/kernel/dumpstack_32.c | 6 +-
arch/x86/kernel/dumpstack_64.c | 18 +
arch/x86/kernel/hw_breakpoint.c | 69 +-
arch/x86/kernel/reboot.c | 1 +
arch/x86/kernel/traps.c | 14 +
drivers/tty/vt/vt.c | 4 +
include/asm-generic/bug.h | 4 +
include/linux/console.h | 4 +
kernel/debug/kdb/kdb_debugger.c | 2 +-
kernel/events/hw_breakpoint.c | 2 +
kernel/extable.c | 1 +
kernel/kallsyms.c | 45 +
kernel/module.c | 43 +
kernel/rcu/tree.c | 1 +
kernel/sched/core.c | 13 +-
kernel/time/clocksource.c | 1 +
kernel/watchdog.c | 17 +-
lib/Kconfig.debug | 66 +
44 files changed, 23240 insertions(+), 18 deletions(-)
create mode 100644 arch/x86/kernel/debug/Makefile
create mode 100644 arch/x86/kernel/debug/mdb/Makefile
create mode 100644 arch/x86/kernel/debug/mdb/Makefile.local
create mode 100644 arch/x86/kernel/debug/mdb/mdb-base.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-base.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia-apic.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia-proc.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia-support.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia-support.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-ia.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-keyboard.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-list.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-list.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-logic.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-main.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-os.c
create mode 100644 arch/x86/kernel/debug/mdb/mdb-os.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb-proc.h
create mode 100644 arch/x86/kernel/debug/mdb/mdb.h
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-15 01:00 +0100 |
| Message-ID | <rcKz0-2iI-27@gated-at.bofh.it> |
| In reply to | #1357704 |
On Mon, 2016-03-14 at 17:50 -0600, Jeffrey Merkey wrote: > The following changes since commit b562e44f507e863c6792946e4e1b1449fbbac85d: > > Linux 4.5 (2016-03-13 21:28:54 -0700) > > are available in the git repository at: > > https://github.com/jeffmerkey/linux.git tags/mdb-v4.5-signed > > for you to fetch changes up to 2e9c184e1215dca2b4c59c347f40a0986b8e7460: > > Add MDB Debugger to linux v4.5 (2016-03-14 15:17:44 -0600) If Linus doesn't pull this, Stephen, could you please add this tree to -next so it has some testing and validation done? Maybe the build-bot could do some coverage testing too?
[toc] | [prev] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2016-03-15 01:30 +0100 |
| Message-ID | <rcL22-2Nm-17@gated-at.bofh.it> |
| In reply to | #1357706 |
Hi Joe, On Mon, 14 Mar 2016 16:57:03 -0700 Joe Perches <joe@perches.com> wrote: > > On Mon, 2016-03-14 at 17:50 -0600, Jeffrey Merkey wrote: > > The following changes since commit b562e44f507e863c6792946e4e1b1449fbbac85d: > > > > Linux 4.5 (2016-03-13 21:28:54 -0700) > > > > are available in the git repository at: > > > > https://github.com/jeffmerkey/linux.git tags/mdb-v4.5-signed > > > > for you to fetch changes up to 2e9c184e1215dca2b4c59c347f40a0986b8e7460: > > > > Add MDB Debugger to linux v4.5 (2016-03-14 15:17:44 -0600) > > If Linus doesn't pull this, Stephen, could you please add this > tree to -next so it has some testing and validation done? Well, I really need a request from the ongoing maintainer and also some indication of which kernel release (if any) it is likely to be merged into ... As a general rule, I do not add trees to linux-next during the merge window (there have been some special cases when something was going in during that merge window). I do note that the single commit in that tag has no Signed-off-by, Reviewed-by or Acked-by tags at all. As such I can't see Linus merging it as is. The commit message also has no detail at all. It is also based on v4.5 which was only released yesterday. -- Cheers, Stephen Rothwell
[toc] | [prev] | [next] | [standalone]
| From | Jeffrey Merkey <jeffmerkey@gmail.com> |
|---|---|
| Date | 2016-03-15 01:50 +0100 |
| Subject | Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 |
| Message-ID | <rcLln-2V8-1@gated-at.bofh.it> |
| In reply to | #1357716 |
On 3/14/16, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Joe, > > On Mon, 14 Mar 2016 16:57:03 -0700 Joe Perches <joe@perches.com> wrote: >> >> On Mon, 2016-03-14 at 17:50 -0600, Jeffrey Merkey wrote: >> > The following changes since commit >> > b562e44f507e863c6792946e4e1b1449fbbac85d: >> > >> > Linux 4.5 (2016-03-13 21:28:54 -0700) >> > >> > are available in the git repository at: >> > >> > https://github.com/jeffmerkey/linux.git tags/mdb-v4.5-signed >> > >> > for you to fetch changes up to >> > 2e9c184e1215dca2b4c59c347f40a0986b8e7460: >> > >> > Add MDB Debugger to linux v4.5 (2016-03-14 15:17:44 -0600) >> >> If Linus doesn't pull this, Stephen, could you please add this >> tree to -next so it has some testing and validation done? > > Well, I really need a request from the ongoing maintainer and also some > indication of which kernel release (if any) it is likely to be merged > into ... > > As a general rule, I do not add trees to linux-next during the merge > window (there have been some special cases when something was going in > during that merge window). > > I do note that the single commit in that tag has no Signed-off-by, > Reviewed-by or Acked-by tags at all. As such I can't see Linus merging > it as is. The commit message also has no detail at all. It is also > based on v4.5 which was only released yesterday. > -- > Cheers, > Stephen Rothwell > Hi Stephen, I was sure I told git to put a sign-off line. Well, I'll go fix that and amend the commit as signed. Don't know what happened there. Are you supposed to say git commit -s -a -v -S I just used git commit -S -a -v I'll amend that commit. Folks can review and discuss on this thread. Jeff
[toc] | [prev] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2016-03-15 03:10 +0100 |
| Subject | Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 |
| Message-ID | <rcMAO-3SR-7@gated-at.bofh.it> |
| In reply to | #1357723 |
Hi Jeff, On Mon, 14 Mar 2016 18:40:37 -0600 Jeffrey Merkey <jeffmerkey@gmail.com> wrote: > > I was sure I told git to put a sign-off line. Well, I'll go fix that > and amend the commit as signed. Don't know what happened there. Are > you supposed to say > > git commit -s -a -v -S > > I just used > > git commit -S -a -v > > I'll amend that commit. Folks can review and discuss on this thread. We don't generally PGP (GPG) sign commits in the kernel tree (so "-S" is not required), just tags. However we always require that anyone who handles a patch adds a Signed-off-by line to the final commit. See Documentation/SubmittingPatches Section 11. -- Cheers, Stephen Rothwell
[toc] | [prev] | [next] | [standalone]
| From | Theodore Ts'o <tytso@mit.edu> |
|---|---|
| Date | 2016-03-15 16:20 +0100 |
| Subject | Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 |
| Message-ID | <rcYVk-3MQ-13@gated-at.bofh.it> |
| In reply to | #1357747 |
On Tue, Mar 15, 2016 at 01:03:39PM +1100, Stephen Rothwell wrote: > We don't generally PGP (GPG) sign commits in the kernel tree (so "-S" > is not required), just tags. However we always require that anyone who > handles a patch adds a Signed-off-by line to the final commit. See > Documentation/SubmittingPatches Section 11. In general all commits should have a Signed-Off-By line added. Once the git branch gets merged, it's hard to tell what is the final commit and what isn't, and in general different commits will have different people needing to vouch for the origins for the contents of that commit. Cheers, - Ted
[toc] | [prev] | [next] | [standalone]
| From | Jeffrey Merkey <jeffmerkey@gmail.com> |
|---|---|
| Date | 2016-03-17 00:30 +0100 |
| Subject | Re: [GIT PULL v4.6] MDB Linux Kernel Debugger x86/x86_64 |
| Message-ID | <rdt34-7Be-21@gated-at.bofh.it> |
| In reply to | #1358097 |
On 3/15/16, Theodore Ts'o <tytso@mit.edu> wrote: > On Tue, Mar 15, 2016 at 01:03:39PM +1100, Stephen Rothwell wrote: >> We don't generally PGP (GPG) sign commits in the kernel tree (so "-S" >> is not required), just tags. However we always require that anyone who >> handles a patch adds a Signed-off-by line to the final commit. See >> Documentation/SubmittingPatches Section 11. > > In general all commits should have a Signed-Off-By line added. Once > the git branch gets merged, it's hard to tell what is the final commit > and what isn't, and in general different commits will have different > people needing to vouch for the origins for the contents of that commit. > > Cheers, > > - Ted > > Hi Ted, I will repost this pull request with a signed-off by line for Linus to consider. I am not certain who all should be included in the review and I have to be careful how many email recipients I copy. I will post to the folks Joe Perches copied. Jeff
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web